- Developers - lists.chirpmyradio.com

Re: [chirp_devel] Proposal to make use of TSQL in csv import friendlier
by chirp.cordless＠xoxy.net 24 Apr '14

24 Apr '14

Responses inline. On Apr 24, 2014, at 8:33 AM, Tom Hayward - esarfl(a)gmail.com wrote: > On Thu, Apr 24, 2014 at 8:15 AM, <chirp.cordless(a)xoxy.net> wrote: >> Tom, >> >> Thanks for the agreement on the direction, and I'll be happy to >> implement any way that makes sense. >> >> The import_logic function _import_tone() isn't setting rtone to 88.5, >> it's setting it it to ctone, which csv import set to 88.5 because there >> isn't any such column in the csv, and then because the CSV pseudo >> radio is defined as having both rtone and ctone: > > Let me try to understand this a little more thoroughly. Correct me if > any of the following is not true. > - The logic you are suggesting already exists in import logic No, that's not the case. The current import_logic is what's actually breaking it, although I don't think it needs to change. The current import_logic code sets rtone = ctone if tmode is TSQL, without any concern that rtone is a user-suppled value and ctone is an 88.5 default supplied by csv import because there is no cToneFreq column. > - Import logic doesn't help in your case because you have an out-of-spec CSV If there were a cToneFreq column, import_logic would be a no-op, which would not so much 'help it' as 'not break it'. I think it would actually save the day here if cToneFreq were present but rToneFreq wasn't. > Where'd you get a CSV without all the Chirp columns? (just curious) I created a spreadsheet in Libre Office with the memories I want to load in my radio, and saved as csv. The column heading values were obtained by exporting something from Chirp some time ago. Recognizing that for me, and Id expect 90+% of users, there is no utility, just cruft, in having separate rToneFreq and cToneFreq columns, making my speadsheet wider and harder to maintain etc., I just left cToneFreq out. It worked fine until I wanted TSQL. I also leave out URCALL,RPT1CALL,RPT2CALL and a few others. It's great that Chirp provides an extensible input method that handles a lot of user's requirements, but smart defaults make for a good user interface. > We already have lots of support for interpreting various differences > in CSV. I don't see how supporting more oddities (like a missing > column) is a problem--go for it! I'll take that as a go-ahead. Bug and patch coming, probably later today if I can get to it. > I wonder if there is a better way to handle this. Like, if a CSV file > is detected as to not be the standard format, maybe we pipe it through > import logic so we don't have to essentially duplicate those rules in > the CSV driver. Again, import_logic doesn't fix this problem, it actually triggers it. I think it's actually doing what it's supposed to be doing. Imagine someone with a radio with separate rtone/ctone importing to a radio like my FT-60 that only has one, with a TSQL channel. That, and the reverse, is what _import_tone() in import_logic.py is there to handle, and nothing else. Now suppose that one of the defined memories uses TSQL, rtone = 107.2, and ctone = 88.5 (deliberately). The existing code sets rtone = ctone. I assume that that's what's wanted, since that's how it's coded. How can this piece of code tell the difference between this case with a real radio, and mine with a CSV pseudo-radio? Why should it? IMO, the place to recognize a "missing column oddity" in a csv file is the csv import. The csv import code is already handling the case of the missing column, just sub-optimally. -dan

1 0

Re: [chirp_devel] Proposal to make use of TSQL in csv import friendlier
by chirp.cordless＠xoxy.net 24 Apr '14

24 Apr '14

Tom, Thanks for the agreement on the direction, and I'll be happy to implement any way that makes sense. The import_logic function _import_tone() isn't setting rtone to 88.5, it's setting it it to ctone, which csv import set to 88.5 because there isn't any such column in the csv, and then because the CSV pseudo radio is defined as having both rtone and ctone: # If copying from a radio with separate rtone/ctone to a radio # without, and the tmode is TSQL, then use the ctone value I figured that's there for the case of real radios with separate rtone/ctone and don't want to break that. I considered having the csv import logic do the same check for a "cToneFreq" column I did in my suggested patch, and then if not present, set rf.has_ctone = False in the CSV pseudo-radio's features. But I thought the symmetric "if there's only one of [ rtoneFreq, cToneFreq ] use it for both" approach would cover a multitude of user confusion. As you said, if one tone value is supplied, it's likely to be a better default for the other than 88.5. If you still want it in import_logic, outline an approach that doesn't break the general case and I'll get to work on it. -dan On Apr 23, 2014, at 11:11 PM, Tom Hayward - esarfl(a)gmail.com wrote: > On Apr 22, 2014 12:49 PM, <chirp.cordless(a)xoxy.net> wrote: > > But I'd like to propose a very specific change to csv import, such > > that if exactly one of the columns rToneFreq and cToneFreq exists > > in the csv file, that the value in that column be used for both rtone > > and ctone. > > Makes sense to me. The rTone value is a much more useful default than 88.5. > > This could probably be done in import logic, not CSV. > > Tom KD7LXL

2 1

[chirp_devel] Proposal to make use of TSQL in csv import friendlier
by chirp.cordless＠xoxy.net 23 Apr '14

23 Apr '14

Hi, I recently tried creating a TSQL channel for a couple of the local repeaters I was told transmit the PL tone. My spreadsheet only has the rToneFreq column. It ended up with a PL tone of 88.5. I don't need an explanation, I've found the documentation of this behavior in http://chirp.danplanet.com/projects/chirp/wiki/MemoryEditorColumns although I note that my FT-60, defined as "rf.has_ctone = False", doesn't have a ToneSql column in the editor. But it looks like I could add a cToneFreq column to my spreadsheet and get this working. And I see where the input rtone value is overwritten with the default ctone value in import_logic.py, because the FT-60 doesn't have a cTone and the csv pseudo-radio does. I understand the general case, and don't want or need to break it. But I'd like to propose a very specific change to csv import, such that if exactly one of the columns rToneFreq and cToneFreq exists in the csv file, that the value in that column be used for both rtone and ctone. This solves the TSQL problem without requiring another essentially informationless column in the spreadsheet. It also generally mirrors the behavior in other cases where one is used for the other if only one is provided or exists. I can see a couple of approaches. I'll be happy to open the bug and submit the patch, but I wanted to see how the direction and specific approach would be accepted. I'm adding a _clean_tmode method to the generic CSVRadio class in generic_csv.py =============== def _clean_tmode(self, headers, line, mem): # If there is only one of [ rToneFreq, cToneFreq ] columns in the # csv file, use it for both rtone & ctone. Makes TSQL use friendlier. _file_has_rTone = 0 _file_has_cTone = 0 for header in headers: if header == "rToneFreq": _file_has_rTone = 1 elif header == "cToneFreq": _file_has_cTone = 1 if _file_has_rTone and not _file_has_cTone: mem.ctone = mem.rtone elif _file_has_cTone and not _file_has_rTone: mem.rtone = mem.ctone return mem ============================= The requirement that one of them exists should avoid problems with a child class that doesn't supply a _clean_tmode() and inherits this one - I think. I understand that it's possible somebody that has a radio that supports Tone->Tone doesn't realize they need two columns, but with the current code they won't get what they want either. It's more likely that someone who just wants TSQL and provides the tone ends up with 88.5 instead. Shall I move forward with this? -dan

2 1

[chirp_devel] [PATCH 0 of 1 ] BF-888 BCL and Scramble - Third try (and last I hope)
by Marco Filippi IZ3GME 23 Apr '14

23 Apr '14

I forget to refresh the patch in my queue before sending the second try, as result a not bool(setting.value) was in the code insted of the right not int(setting.value). Really hope this is the last try .... 73 de IZ3GME Marco

1 1

[chirp_devel] [PATCH 0 of 1 ] BF-888 BCL and Scramble - second try
by Marco Filippi IZ3GME 17 Apr '14

17 Apr '14

I elaborated the commit message a little more, for me there's still some obscure pythonic magic in this bug but at least it should be clear that both not setting.value not bool(setting.value) doesn't work 73 de IZ3GME Marco

1 1

[chirp_devel] [FT-60] The implementation of memory skip is incorrect. - Fixes #1557
by chirp.cordless＠xoxy.net 12 Apr '14

12 Apr '14

Patch attached. -dan

1 0

[chirp_devel] Build test results: Successful
by Build System 12 Apr '14

12 Apr '14

Tested changes: [Dan Drogichen <chirp.cordless(a)xoxy.net>] [FT-60] Chirp should check parity on download - Fixes #1547 [Jim Unroe <rock.unroe(a)gmail.com>] [UV-B5] Update Frequency Ranges Update rf.valid_bands 130.000-175.000 MHz (expanded range) 220.000-269.000 MHz (added range) 400.000-520.000 MHz (unchanged) Expand the VHF Lower Limit setting range 128-270 Expand the VHF Upper Limit setting range 128-270 #1559 Full log: [...truncated 26 lines...] test_type_u24 (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_type_u32 (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_type_u8 (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_type_ul16 (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_type_ul24 (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_type_ul32 (tests.unit.test_bitwise.TestBitwiseBaseIntTypes) ... ok test_char (tests.unit.test_bitwise.TestBitwiseCharTypes) ... ok test_string (tests.unit.test_bitwise.TestBitwiseCharTypes) ... ok test_string_invalid_chars (tests.unit.test_bitwise.TestBitwiseCharTypes) ... ok test_string_wrong_length (tests.unit.test_bitwise.TestBitwiseCharTypes) ... ok test_comment_cppstyle (tests.unit.test_bitwise.TestBitwiseComments) ... ok test_comment_inline_cppstyle (tests.unit.test_bitwise.TestBitwiseComments) ... ok test_missing_semicolon (tests.unit.test_bitwise.TestBitwiseErrors) ... ok test_seek (tests.unit.test_bitwise.TestBitwiseSeek) ... ok test_seekto (tests.unit.test_bitwise.TestBitwiseSeek) ... ok test_struct_one_element (tests.unit.test_bitwise.TestBitwiseStructTypes) ... ok test_struct_two_elements (tests.unit.test_bitwise.TestBitwiseStructTypes) ... ok test_struct_writes (tests.unit.test_bitwise.TestBitwiseStructTypes) ... ok split_tone_encode_test_cross_dtcs_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_cross_none_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_cross_none_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_cross_tone_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_cross_tone_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_none (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok split_tone_encode_test_tsql (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_cross_dtcs_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_cross_dtcs_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_cross_none_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_cross_none_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_cross_tone_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_cross_tone_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_dtcs (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_none (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_tone (tests.unit.test_chirp_common.TestSplitTone) ... ok test_split_tone_decode_tsql (tests.unit.test_chirp_common.TestSplitTone) ... ok test_fix_rounded_step_250 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_fix_rounded_step_500 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_fix_rounded_step_750 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_is_12_5 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_is_2_5 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_is_5_0 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_is_6_25 (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_is_fractional_step (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_required_step (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_required_step_fail (tests.unit.test_chirp_common.TestStepFunctions) ... ok test_format_freq (tests.unit.test_chirp_common.TestUtilityFunctions) ... ok test_parse_freq_bad (tests.unit.test_chirp_common.TestUtilityFunctions) ... ok test_parse_freq_decimal (tests.unit.test_chirp_common.TestUtilityFunctions) ... ok test_parse_freq_whitespace (tests.unit.test_chirp_common.TestUtilityFunctions) ... ok test_parse_freq_whole (tests.unit.test_chirp_common.TestUtilityFunctions) ... ok test_ensure_has_calls_almost_full (tests.unit.test_import_logic.DstarTests) ... ok test_ensure_has_calls_empty (tests.unit.test_import_logic.DstarTests) ... ok test_ensure_has_calls_partial (tests.unit.test_import_logic.DstarTests) ... ok test_ensure_has_calls_rptcall_full1 (tests.unit.test_import_logic.DstarTests) ... ok test_ensure_has_calls_rptcall_full2 (tests.unit.test_import_logic.DstarTests) ... ok test_ensure_has_calls_urcall_full (tests.unit.test_import_logic.DstarTests) ... ok test_import_bank (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_dtcs_diffA_dtcs (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_dtcs_diffB_dtcs (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_duplex_negative (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_duplex_too_big_vhf (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_duplex_uhf (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_duplex_vhf (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_mem (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_mem_with_errors (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_mem_with_warnings (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_mode_invalid (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_mode_valid_am (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_mode_valid_fm (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_name (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_power_closest (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_power_no_dst (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_power_no_src (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_power_same (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_tone_diffA_tsql (tests.unit.test_import_logic.ImportFieldTests) ... ok test_import_tone_diffB_tsql (tests.unit.test_import_logic.ImportFieldTests) ... ok test_mapping (tests.unit.test_mappingmodel.TestBaseBank) ... ok test_mapping_eq (tests.unit.test_mappingmodel.TestBaseBank) ... ok test_base_class (tests.unit.test_mappingmodel.TestBaseBankModel) ... ok test_get_name (tests.unit.test_mappingmodel.TestBaseBankModel) ... ok test_mapping (tests.unit.test_mappingmodel.TestBaseMapping) ... ok test_mapping_eq (tests.unit.test_mappingmodel.TestBaseMapping) ... ok test_base_class (tests.unit.test_mappingmodel.TestBaseMappingModel) ... ok test_get_name (tests.unit.test_mappingmodel.TestBaseMappingModel) ... ok test_base_class (tests.unit.test_mappingmodel.TestBaseMappingModelIndexInterface) ... ok test_add_memory_to_mapping (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_get_mapping_memories (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_get_mappings (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_get_memory_mappings (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_get_num_mappings (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_remove_memory_from_mapping (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_remove_memory_from_mapping_no_bank (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_remove_memory_from_mapping_wrong_bank (tests.unit.test_mappingmodel.TestIcomBankModel) ... ok test_icom_bank (tests.unit.test_mappingmodel.TestIcomBanks) ... ok test_mapping (tests.unit.test_mappingmodel.TestIcomBanks) ... ok test_mapping_eq (tests.unit.test_mappingmodel.TestIcomBanks) ... ok test_add_memory_to_mapping (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_index_bounds (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_mapping_memories (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_mappings (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_memory_index (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_memory_mappings (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_next_mapping_index (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_get_num_mappings (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_remove_memory_from_mapping (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_remove_memory_from_mapping_no_bank (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_remove_memory_from_mapping_wrong_bank (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_set_memory_index (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_set_memory_index_bad_bank (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_set_memory_index_bad_index (tests.unit.test_mappingmodel.TestIcomIndexedBankModel) ... ok test_auto_tone_mode_cross (tests.unit.test_memedit_edits.TestEdits) ... ok test_auto_tone_mode_dtcs (tests.unit.test_memedit_edits.TestEdits) ... ok test_auto_tone_mode_dtcs_pol (tests.unit.test_memedit_edits.TestEdits) ... ok test_auto_tone_mode_dtcs_rx (tests.unit.test_memedit_edits.TestEdits) ... ok test_auto_tone_mode_tone (tests.unit.test_memedit_edits.TestEdits) ... ok test_auto_tone_mode_tsql (tests.unit.test_memedit_edits.TestEdits) ... ok test_init (tests.unit.test_platform.Win32PlatformTest) ... ok test_serial_ports_bad_portnames (tests.unit.test_platform.Win32PlatformTest) ... ok test_serial_ports_sorted (tests.unit.test_platform.Win32PlatformTest) ... ok test_apply_callback (tests.unit.test_settings.TestSettingContainers) ... ok test_radio_setting (tests.unit.test_settings.TestSettingContainers) ... ok test_radio_setting_group (tests.unit.test_settings.TestSettingContainers) ... ok test_radio_setting_multi (tests.unit.test_settings.TestSettingContainers) ... ok test_changed (tests.unit.test_settings.TestSettingValues) ... ok test_radio_setting_value_boolean (tests.unit.test_settings.TestSettingValues) ... ok test_radio_setting_value_float (tests.unit.test_settings.TestSettingValues) ... ok test_radio_setting_value_integer (tests.unit.test_settings.TestSettingValues) ... ok test_radio_setting_value_list (tests.unit.test_settings.TestSettingValues) ... ok test_radio_setting_value_string (tests.unit.test_settings.TestSettingValues) ... ok test_validate_callback (tests.unit.test_settings.TestSettingValues) ... ok test_delete_hole_with_all (tests.unit.test_shiftdialog.ShiftDialogTest) ... ok test_delete_hole_with_all_full (tests.unit.test_shiftdialog.ShiftDialogTest) ... ok test_delete_hole_with_hole (tests.unit.test_shiftdialog.ShiftDialogTest) ... ok test_delete_hole_without_hole (tests.unit.test_shiftdialog.ShiftDialogTest) ... ok test_insert_hole_with_space (tests.unit.test_shiftdialog.ShiftDialogTest) ... ok test_insert_hole_without_space (tests.unit.test_shiftdialog.ShiftDialogTest) ... ok ---------------------------------------------------------------------- Ran 151 tests in 0.076s OK Registered Icom_IC-2820H = IC2820Radio Registered TYT_TH-UVF8D = TYTUVF8DRadio Registered AnyTone_5888UV = AnyTone5888UVRadio Registered Intek_HR-2040 = IntekHR2040Radio Registered Polmar_DB-50M = PolmarDB50MRadio Registered Powerwerx_DB-750X = PowerwerxDB750XRadio Registered Icom_IC-2200H = IC2200Radio Registered Yaesu_FT-2800M = FT2800Radio Registered Yaesu_VX-3 = VX3Radio Registered Icom_IC-2100H = IC2100Radio Registered Yaesu_FTM-350 = FTM350Radio Registered Icom_IC-91_92AD_ICF_File = IC9xICFRadio Registered Icom_IC-V82_U82 = ICx8xRadio Registered Yaesu_VX-6 = VX6Radio Registered Yaesu_VX-5 = VX5Radio Registered Yaesu_FT-60 = FT60Radio Registered Yaesu_VX-7 = VX7Radio Registered Baofeng_UV-5R = BaofengUV5R Registered Baofeng_F-11 = BaofengF11Radio Registered Baofeng_UV-82 = BaofengUV82Radio Registered Baofeng_UV-6 = BaofengUV6Radio Registered Intek_KT-980HP = IntekKT980Radio Registered Yaesu_FT-1802M = FT1802Radio Registered Kenwood_TK-7102 = KenwoodTK7102Radio Registered Kenwood_TK-8102 = KenwoodTK8102Radio Registered Kenwood_TK-7108 = KenwoodTK7108Radio Registered Kenwood_TK-8108 = KenwoodTK8108Radio Registered Icom_ID-31A = ID31Radio Registered Icom_ID-51A = ID51Radio Registered Icom_IC-2720H = IC2720Radio Registered Icom_IC-T8A = ICT8ARadio Registered Wouxun_KG-UVD1P = KGUVD1PRadio Registered Wouxun_KG-UV6 = KGUV6DRadio Registered Wouxun_KG-816 = KG816Radio Registered Wouxun_KG-818 = KG818Radio Registered TYT_TH-UVF1 = TYTTHUVF1Radio Registered Yaesu_FT-90 = FT90Radio Registered Generic_CSV = CSVRadio Registered Commander_KG-UV = CommanderCSVRadio Registered RT_Systems_CSV = RTCSVRadio Registered Kenwood_ITM = ITMRadio Registered Alinco_DR03T = DR03Radio Registered Alinco_DR06T = DR06Radio Registered Alinco_DR135T = DR135Radio Registered Alinco_DR235T = DR235Radio Registered Alinco_DR435T = DR435Radio Registered Alinco_DJ596 = DJ596Radio Registered Jetstream_JT220M = JT220MRadio Registered Alinco_DJ175 = DJ175Radio Registered Kenwood_TH-D7 = THD7Radio Registered Kenwood_TH-D7G = THD7GRadio Registered Kenwood_TM-D700 = TMD700Radio Registered Kenwood_TM-V7 = TMV7Radio Registered Kenwood_TM-G707 = TMG707Radio Registered Kenwood_TH-G71 = THG71Radio Registered Kenwood_TH-F6 = THF6ARadio Registered Kenwood_TH-F7 = THF7ERadio Registered Kenwood_TM-D710 = TMD710Radio Registered Kenwood_TH-D72_live_mode = THD72Radio Registered Kenwood_TM-V71 = TMV71Radio Registered Kenwood_TH-K2 = THK2Radio Registered Kenwood_TM-271 = TM271Radio Registered Kenwood_TM-281 = TM281Radio Registered Kenwood_TM-471 = TM471Radio Registered Yaesu_VX-8_R = VX8Radio Registered Yaesu_VX-8_DR = VX8DRadio Registered Yaesu_VX-8_GE = VX8GERadio Registered Icom_IC-T7H = ICT7HRadio Registered Icom_IC-Q7A = ICQ7Radio Registered Baofeng_UV-B5 = BaofengUVB5 Registered Generic_XML = XMLRadio Registered Kenwood_HMK = HMKRadio Registered Kenwood_TH-D72_clone_mode = THD72Radio Registered Icom_IC-91_92AD = IC9xRadio Registered Icom_IC-T70 = ICT70Radio Registered Icom_IC-208H = IC208Radio Registered Icom_ID-800H_v2 = ID800v2Radio Registered Icom_7200 = Icom7200Radio Registered Icom_7000 = Icom7000Radio Registered Icom_746 = Icom746Radio Registered ARRL_Travel_Plus = TpeRadio Registered Vertex_Standard_VXA-700 = VXA700Radio Registered Icom_IC-W32A = ICW32ARadio Registered Baofeng_UV-3R = UV3RRadio Registered Yaesu_VX-2 = VX2Radio Registered Puxing_PX-777 = Puxing777Radio Registered Puxing_PX-2R = Puxing2RRadio Registered Baojie_BJ-UV55 = BaojieBJUV55Radio Registered Baofeng_BF-888 = H777Radio Registered Yaesu_FT-7800_7900 = FT7800Radio Registered Yaesu_FT-8800 = FT8800Radio Registered Yaesu_FT-8900 = FT8900Radio Registered KYD_NC-630A = NC630aRadio Registered Yaesu_FT-817 = FT817Radio Registered Yaesu_FT-817ND = FT817NDRadio Registered Yaesu_FT-817ND_US = FT817NDUSRadio Registered Yaesu_FT-857_897 = FT857Radio Registered Yaesu_FT-857_897_US = FT857USRadio Registered Yaesu_VX-170 = VX170Radio Registered Icom_ID-880H = ID880Radio Registered Icom_ID-80H = ID80Radio Registered TYT_TH-UV3R = TYTUV3RRadio Alinco DJ175 Detect PASSED: All tests Alinco DJ175 CopyAll PASSED: All tests Alinco DJ175 Clone PASSED: All tests Alinco DJ175 BruteForce PASSED: All tests Alinco DJ175 Edges PASSED: All tests Alinco DJ175 Banks SKIPPED: Banks not supported Alinco DJ596 Detect PASSED: All tests Alinco DJ596 CopyAll PASSED: All tests Alinco DJ596 Clone PASSED: All tests Alinco DJ596 BruteForce PASSED: All tests Alinco DJ596 Edges PASSED: All tests Alinco DJ596 Banks SKIPPED: Banks not supported Alinco DR235T Detect PASSED: All tests Alinco DR235T CopyAll PASSED: All tests Alinco DR235T Clone PASSED: All tests Alinco DR235T BruteForce PASSED: All tests Alinco DR235T Edges PASSED: All tests Alinco DR235T Banks SKIPPED: Banks not supported Baofeng BF-888 Detect PASSED: All tests Baofeng BF-888 CopyAll PASSED: All tests Baofeng BF-888 Clone PASSED: All tests Baofeng BF-888 BruteForce PASSED: All tests Baofeng BF-888 Edges PASSED: All tests Baofeng BF-888 Banks SKIPPED: Banks not supported Baofeng F-11 Detect PASSED: All tests Baofeng F-11 CopyAll PASSED: All tests Baofeng F-11 Clone PASSED: All tests Baofeng F-11 BruteForce PASSED: All tests Baofeng F-11 Edges PASSED: All tests Baofeng F-11 Banks SKIPPED: Banks not supported Baofeng UV-3R Detect PASSED: All tests Baofeng UV-3R CopyAll PASSED: All tests Baofeng UV-3R Clone PASSED: All tests Baofeng UV-3R BruteForce PASSED: All tests Baofeng UV-3R Edges PASSED: All tests Baofeng UV-3R Banks SKIPPED: Banks not supported Baofeng UV-5R Detect PASSED: All tests Baofeng UV-5R CopyAll PASSED: All tests Baofeng UV-5R Clone PASSED: All tests Baofeng UV-5R BruteForce PASSED: All tests Baofeng UV-5R Edges PASSED: All tests Baofeng UV-5R Banks SKIPPED: Banks not supported Baofeng UV-B5 Detect PASSED: All tests Baofeng UV-B5 CopyAll PASSED: All tests Baofeng UV-B5 Clone PASSED: All tests Baofeng UV-B5 BruteForce PASSED: All tests Baofeng UV-B5 Edges PASSED: All tests Baofeng UV-B5 Banks SKIPPED: Banks not supported Icom IC-208H Detect PASSED: All tests Icom IC-208H CopyAll PASSED: All tests Icom IC-208H Clone PASSED: All tests Icom IC-208H BruteForce PASSED: All tests Icom IC-208H Edges PASSED: All tests Icom IC-208H Banks PASSED: All tests Icom IC-2100H Detect PASSED: All tests Icom IC-2100H CopyAll PASSED: All tests Icom IC-2100H Clone PASSED: All tests Icom IC-2100H BruteForce PASSED: All tests Icom IC-2100H Edges PASSED: All tests Icom IC-2100H Banks SKIPPED: Banks not supported Icom IC-2200H Detect PASSED: All tests Icom IC-2200H CopyAll PASSED: All tests Icom IC-2200H Clone PASSED: All tests Icom IC-2200H BruteForce PASSED: All tests Icom IC-2200H Edges PASSED: All tests Icom IC-2200H Banks PASSED: All tests Icom IC-2720H Detect PASSED: All tests Icom IC-2720H CopyAll PASSED: All tests Icom IC-2720H Clone PASSED: All tests Icom IC-2720H BruteForce PASSED: All tests Icom IC-2720H Edges PASSED: All tests Icom IC-2720H Banks PASSED: All tests Icom IC-2820H Detect PASSED: All tests Icom IC-2820H CopyAll PASSED: All tests Icom IC-2820H Clone PASSED: All tests Icom IC-2820H BruteForce PASSED: All tests Icom IC-2820H Edges PASSED: All tests Icom IC-2820H Banks PASSED: All tests Icom IC-Q7A Detect PASSED: All tests Icom IC-Q7A CopyAll PASSED: All tests Icom IC-Q7A Clone PASSED: All tests Icom IC-Q7A BruteForce PASSED: All tests Icom IC-Q7A Edges PASSED: All tests Icom IC-Q7A Banks SKIPPED: Banks not supported Icom IC-T70 Detect PASSED: All tests Icom IC-T70 CopyAll PASSED: All tests Icom IC-T70 Clone PASSED: All tests Icom IC-T70 BruteForce PASSED: All tests Icom IC-T70 Edges PASSED: All tests Icom IC-T70 Banks PASSED: All tests Icom IC-T7H Detect PASSED: All tests Icom IC-T7H CopyAll PASSED: All tests Icom IC-T7H Clone PASSED: All tests Icom IC-T7H BruteForce PASSED: All tests Icom IC-T7H Edges PASSED: All tests Icom IC-T7H Banks SKIPPED: Banks not supported Icom IC-T8A Detect PASSED: All tests Icom IC-T8A CopyAll PASSED: All tests Icom IC-T8A Clone PASSED: All tests Icom IC-T8A BruteForce PASSED: All tests Icom IC-T8A Edges PASSED: All tests Icom IC-T8A Banks SKIPPED: Banks not supported Icom IC-V82/U82 Detect PASSED: All tests Icom IC-V82/U82 CopyAll PASSED: All tests Icom IC-V82/U82 Clone PASSED: All tests Icom IC-V82/U82 BruteForce PASSED: All tests Icom IC-V82/U82 Edges PASSED: All tests Icom IC-V82/U82 Banks PASSED: All tests Icom IC-W32A VHF Detect PASSED: All tests Icom IC-W32A VHF CopyAll PASSED: All tests Icom IC-W32A VHF Clone PASSED: All tests Icom IC-W32A VHF BruteForce PASSED: All tests Icom IC-W32A VHF Edges PASSED: All tests Icom IC-W32A VHF Banks SKIPPED: Banks not supported Icom IC-W32A UHF Detect PASSED: All tests Icom IC-W32A UHF CopyAll PASSED: All tests Icom IC-W32A UHF Clone PASSED: All tests Icom IC-W32A UHF BruteForce PASSED: All tests Icom IC-W32A UHF Edges PASSED: All tests Icom IC-W32A UHF Banks SKIPPED: Banks not supported Icom ID-31A Detect PASSED: All tests Icom ID-31A CopyAll PASSED: All tests Icom ID-31A Clone PASSED: All tests Icom ID-31A BruteForce PASSED: All tests Icom ID-31A Edges PASSED: All tests Icom ID-31A Banks PASSED: All tests Icom ID-51A Detect PASSED: All tests Icom ID-51A CopyAll PASSED: All tests Icom ID-51A Clone PASSED: All tests Icom ID-51A BruteForce PASSED: All tests Icom ID-51A Edges PASSED: All tests Icom ID-51A Banks PASSED: All tests Icom ID-800H v2 Detect PASSED: All tests Icom ID-800H v2 CopyAll PASSED: All tests Icom ID-800H v2 Clone PASSED: All tests Icom ID-800H v2 BruteForce PASSED: All tests Icom ID-800H v2 Edges PASSED: All tests Icom ID-800H v2 Banks PASSED: All tests Icom ID-880H Detect PASSED: All tests Icom ID-880H CopyAll PASSED: All tests Icom ID-880H Clone PASSED: All tests Icom ID-880H BruteForce PASSED: All tests Icom ID-880H Edges PASSED: All tests Icom ID-880H Banks PASSED: All tests Jetstream JT220M Detect PASSED: All tests Jetstream JT220M CopyAll PASSED: All tests Jetstream JT220M Clone PASSED: All tests Jetstream JT220M BruteForce PASSED: All tests Jetstream JT220M Edges PASSED: All tests Jetstream JT220M Banks SKIPPED: Banks not supported Kenwood TH-D72 (clone Detect PASSED: All tests Kenwood TH-D72 (clone CopyAll PASSED: All tests Kenwood TH-D72 (clone Clone PASSED: All tests Kenwood TH-D72 (clone BruteForce PASSED: All tests Kenwood TH-D72 (clone Edges PASSED: All tests Kenwood TH-D72 (clone Banks SKIPPED: Banks not supported Kenwood TK-8102 Detect PASSED: All tests Kenwood TK-8102 CopyAll PASSED: All tests Kenwood TK-8102 Clone PASSED: All tests Kenwood TK-8102 BruteForce PASSED: All tests Kenwood TK-8102 Edges PASSED: All tests Kenwood TK-8102 Banks SKIPPED: Banks not supported Polmar DB-50M Detect PASSED: All tests Polmar DB-50M CopyAll PASSED: All tests Polmar DB-50M Clone PASSED: All tests Polmar DB-50M BruteForce PASSED: All tests Polmar DB-50M Edges PASSED: All tests Polmar DB-50M Banks SKIPPED: Banks not supported Puxing PX-2R Detect PASSED: All tests Puxing PX-2R CopyAll PASSED: All tests Puxing PX-2R Clone PASSED: All tests Puxing PX-2R BruteForce PASSED: All tests Puxing PX-2R Edges PASSED: All tests Puxing PX-2R Banks SKIPPED: Banks not supported Puxing PX-777 Detect PASSED: All tests Puxing PX-777 CopyAll PASSED: All tests Puxing PX-777 Clone PASSED: All tests Puxing PX-777 BruteForce PASSED: All tests Puxing PX-777 Edges PASSED: All tests Puxing PX-777 Banks SKIPPED: Banks not supported TYT TH-UV3R Detect PASSED: All tests TYT TH-UV3R CopyAll PASSED: All tests TYT TH-UV3R Clone PASSED: All tests TYT TH-UV3R BruteForce PASSED: All tests TYT TH-UV3R Edges PASSED: All tests TYT TH-UV3R Banks SKIPPED: Banks not supported TYT TH-UVF1 Detect PASSED: All tests TYT TH-UVF1 CopyAll PASSED: All tests TYT TH-UVF1 Clone PASSED: All tests TYT TH-UVF1 BruteForce PASSED: All tests TYT TH-UVF1 Edges PASSED: All tests TYT TH-UVF1 Banks SKIPPED: Banks not supported Vertex VXA-700 Detect PASSED: All tests Vertex VXA-700 CopyAll PASSED: All tests Vertex VXA-700 Clone PASSED: All tests Vertex VXA-700 BruteForce PASSED: All tests Vertex VXA-700 Edges PASSED: All tests Vertex VXA-700 Banks SKIPPED: Banks not supported Wouxun KG-816 Detect PASSED: All tests Wouxun KG-816 CopyAll PASSED: All tests Wouxun KG-816 Clone PASSED: All tests Wouxun KG-816 BruteForce PASSED: All tests Wouxun KG-816 Edges PASSED: All tests Wouxun KG-816 Banks SKIPPED: Banks not supported Wouxun KG-818 Detect PASSED: All tests Wouxun KG-818 CopyAll PASSED: All tests Wouxun KG-818 Clone PASSED: All tests Wouxun KG-818 BruteForce PASSED: All tests Wouxun KG-818 Edges PASSED: All tests Wouxun KG-818 Banks SKIPPED: Banks not supported Wouxun KG-UV6 Detect PASSED: All tests Wouxun KG-UV6 CopyAll PASSED: All tests Wouxun KG-UV6 Clone PASSED: All tests Wouxun KG-UV6 BruteForce PASSED: All tests Wouxun KG-UV6 Edges PASSED: All tests Wouxun KG-UV6 Banks SKIPPED: Banks not supported Wouxun KG-UVD1P Detect PASSED: All tests Wouxun KG-UVD1P CopyAll PASSED: All tests Wouxun KG-UVD1P Clone PASSED: All tests Wouxun KG-UVD1P BruteForce PASSED: All tests Wouxun KG-UVD1P Edges PASSED: All tests Wouxun KG-UVD1P Banks SKIPPED: Banks not supported Yaesu FT-1802M Detect PASSED: All tests Yaesu FT-1802M CopyAll PASSED: All tests Yaesu FT-1802M Clone PASSED: All tests Yaesu FT-1802M BruteForce PASSED: All tests Yaesu FT-1802M Edges PASSED: All tests Yaesu FT-1802M Banks SKIPPED: Banks not supported Yaesu FT-2800M Detect PASSED: All tests Yaesu FT-2800M CopyAll PASSED: All tests Yaesu FT-2800M Clone PASSED: All tests Yaesu FT-2800M BruteForce PASSED: All tests Yaesu FT-2800M Edges PASSED: All tests Yaesu FT-2800M Banks SKIPPED: Banks not supported Yaesu FT-60 Detect PASSED: All tests Yaesu FT-60 CopyAll PASSED: All tests Yaesu FT-60 Clone PASSED: All tests Yaesu FT-60 BruteForce PASSED: All tests Yaesu FT-60 Edges PASSED: All tests Yaesu FT-60 Banks SKIPPED: Banks not supported Yaesu FT-7800/7900 Detect PASSED: All tests Yaesu FT-7800/7900 CopyAll PASSED: All tests Yaesu FT-7800/7900 Clone PASSED: All tests Yaesu FT-7800/7900 BruteForce PASSED: All tests Yaesu FT-7800/7900 Edges PASSED: All tests Yaesu FT-7800/7900 Banks PASSED: All tests Yaesu FT-817 Detect PASSED: All tests Yaesu FT-817 CopyAll PASSED: All tests Yaesu FT-817 Clone PASSED: All tests Yaesu FT-817 BruteForce PASSED: All tests Yaesu FT-817 Edges PASSED: All tests Yaesu FT-817 Banks SKIPPED: Banks not supported Yaesu FT-817ND Detect PASSED: All tests Yaesu FT-817ND CopyAll PASSED: All tests Yaesu FT-817ND Clone PASSED: All tests Yaesu FT-817ND BruteForce PASSED: All tests Yaesu FT-817ND Edges PASSED: All tests Yaesu FT-817ND Banks SKIPPED: Banks not supported Yaesu FT-817ND (US) Detect PASSED: All tests Yaesu FT-817ND (US) CopyAll PASSED: All tests Yaesu FT-817ND (US) Clone PASSED: All tests Yaesu FT-817ND (US) BruteForce PASSED: All tests Yaesu FT-817ND (US) Edges PASSED: All tests Yaesu FT-817ND (US) Banks SKIPPED: Banks not supported Yaesu FT-857/897 Detect PASSED: All tests Yaesu FT-857/897 CopyAll PASSED: All tests Yaesu FT-857/897 Clone PASSED: All tests Yaesu FT-857/897 BruteForce PASSED: All tests Yaesu FT-857/897 Edges PASSED: All tests Yaesu FT-857/897 Banks SKIPPED: Banks not supported Yaesu FT-857/897 (U Detect PASSED: All tests Yaesu FT-857/897 (U CopyAll PASSED: All tests Yaesu FT-857/897 (U Clone PASSED: All tests Yaesu FT-857/897 (U BruteForce PASSED: All tests Yaesu FT-857/897 (U Edges PASSED: All tests Yaesu FT-857/897 (U Banks SKIPPED: Banks not supported Yaesu FT-8800 Left Detect PASSED: All tests Yaesu FT-8800 Left CopyAll PASSED: All tests Yaesu FT-8800 Left Clone PASSED: All tests Yaesu FT-8800 Left BruteForce PASSED: All tests Yaesu FT-8800 Left Edges PASSED: All tests Yaesu FT-8800 Left Banks PASSED: All tests Yaesu FT-8800 Right Detect PASSED: All tests Yaesu FT-8800 Right CopyAll PASSED: All tests Yaesu FT-8800 Right Clone PASSED: All tests Yaesu FT-8800 Right BruteForce PASSED: All tests Yaesu FT-8800 Right Edges PASSED: All tests Yaesu FT-8800 Right Banks PASSED: All tests Yaesu FT-8900 Detect PASSED: All tests Yaesu FT-8900 CopyAll PASSED: All tests Yaesu FT-8900 Clone PASSED: All tests Yaesu FT-8900 BruteForce PASSED: All tests Yaesu FT-8900 Edges PASSED: All tests Yaesu FT-8900 Banks SKIPPED: Banks not supported Yaesu FTM-350 Left Detect PASSED: All tests Yaesu FTM-350 Left CopyAll PASSED: All tests Yaesu FTM-350 Left Clone PASSED: All tests Yaesu FTM-350 Left BruteForce PASSED: All tests Yaesu FTM-350 Left Edges PASSED: All tests Yaesu FTM-350 Left Banks SKIPPED: Banks not supported Yaesu FTM-350 Right Detect PASSED: All tests Yaesu FTM-350 Right CopyAll PASSED: All tests Yaesu FTM-350 Right Clone PASSED: All tests Yaesu FTM-350 Right BruteForce PASSED: All tests Yaesu FTM-350 Right Edges PASSED: All tests Yaesu FTM-350 Right Banks SKIPPED: Banks not supported Yaesu VX-2 Detect PASSED: All tests Yaesu VX-2 CopyAll PASSED: All tests Yaesu VX-2 Clone PASSED: All tests Yaesu VX-2 BruteForce PASSED: All tests Yaesu VX-2 Edges PASSED: All tests Yaesu VX-2 Banks PASSED: All tests Yaesu VX-3 Detect PASSED: All tests Yaesu VX-3 CopyAll PASSED: All tests Yaesu VX-3 Clone PASSED: All tests Yaesu VX-3 BruteForce PASSED: All tests Yaesu VX-3 Edges PASSED: All tests Yaesu VX-3 Banks PASSED: All tests Yaesu VX-5 Detect PASSED: All tests Yaesu VX-5 CopyAll PASSED: All tests Yaesu VX-5 Clone PASSED: All tests Yaesu VX-5 BruteForce PASSED: All tests Yaesu VX-5 Edges PASSED: All tests Yaesu VX-5 Banks PASSED: All tests Yaesu VX-6 Detect PASSED: All tests Yaesu VX-6 CopyAll PASSED: All tests Yaesu VX-6 Clone PASSED: All tests Yaesu VX-6 BruteForce PASSED: All tests Yaesu VX-6 Edges PASSED: All tests Yaesu VX-6 Banks PASSED: All tests Yaesu VX-7 Detect PASSED: All tests Yaesu VX-7 CopyAll PASSED: All tests Yaesu VX-7 Clone PASSED: All tests Yaesu VX-7 BruteForce PASSED: All tests Yaesu VX-7 Edges PASSED: All tests Yaesu VX-7 Banks PASSED: All tests Yaesu VX-8 R Detect PASSED: All tests Yaesu VX-8 R CopyAll PASSED: All tests Yaesu VX-8 R Clone PASSED: All tests Yaesu VX-8 R BruteForce PASSED: All tests Yaesu VX-8 R Edges PASSED: All tests Yaesu VX-8 R Banks PASSED: All tests ---------------------------------------------------------------------- Results: TOTAL : 342 FAILED : 0 SKIPPED: 38 PASSED : 304 CRASHED: 0 Patch 'tip' is OK ================================================ Tests OK Email was triggered for: Success Sending email for trigger: Success

1 0

Re: [chirp_devel] [FT-60] Chirp should check parity on download Fixes #1547
by chirp.cordless＠xoxy.net 12 Apr '14

12 Apr '14

On Apr 12, 2014, at 9:25 AM, Dan Smith - dsmith(a)danplanet.com wrote: > This looks like an obvious thing we should be doing. However, I'd rather > not have the commented-out code in the tree. If we want to validate that > it works, we should have a test case that mocks out something so that > the checksum fails. > > Can you re-spin this with just the check_checksums() line? Attached. -dan

2 1

[chirp_devel] [PATCH] [UV-B5] Update Frequency Ranges
by Jim Unroe 12 Apr '14

12 Apr '14

# HG changeset patch # User Jim Unroe <rock.unroe(a)gmail.com> # Date 1397324846 14400 # Node ID 09a238f1f79e303dbaf3673a551d349427f959fa # Parent c5cf3c72377a8dc151d06f08a23a22ec800971cf [UV-B5] Update Frequency Ranges Update rf.valid_bands 130.000-175.000 MHz (expanded range) 220.000-269.000 MHz (added range) 400.000-520.000 MHz (unchanged) Expand the VHF Lower Limit setting range 128-270 Expand the VHF Upper Limit setting range 128-270 #1559 diff -r c5cf3c72377a -r 09a238f1f79e chirp/uvb5.py --- a/chirp/uvb5.py Thu Apr 03 16:54:50 2014 +0200 +++ b/chirp/uvb5.py Sat Apr 12 13:47:26 2014 -0400 @@ -289,7 +289,8 @@ rf.valid_skips = ["", "S"] rf.valid_characters = CHARSET rf.valid_name_length = 5 - rf.valid_bands = [(136000000, 174000000), + rf.valid_bands = [(130000000, 175000000), + (220000000, 269000000), (400000000, 520000000)] rf.valid_modes = ["FM", "NFM"] rf.valid_special_chans = SPECIALS.keys() @@ -617,7 +618,7 @@ _limit = int(self._memobj.limits.lower_vhf) / 10 rs = RadioSetting("limits.lower_vhf", "VHF Lower Limit (MHz)", - RadioSettingValueInteger(136, 174, _limit)) + RadioSettingValueInteger(128, 270, _limit)) def apply_limit(setting, obj): value = int(setting.value) * 10 obj.lower_vhf = value @@ -626,7 +627,7 @@ _limit = int(self._memobj.limits.upper_vhf) / 10 rs = RadioSetting("limits.upper_vhf", "VHF Upper Limit (MHz)", - RadioSettingValueInteger(136, 174, _limit)) + RadioSettingValueInteger(128, 270, _limit)) def apply_limit(setting, obj): value = int(setting.value) * 10 obj.upper_vhf = value

1 0

Re: [chirp_devel] [CHIRP - Bug #1557] and some procedural questions.
by chirp.cordless＠xoxy.net 12 Apr '14

12 Apr '14

On Apr 11, 2014, at 6:36 PM, donotreply(a)danplanet.com wrote: > Issue #1557 has been updated by Tom Hayward. > • Description updated Tom, thanks for updating the formatting of that. But let me know the secret to escaping [] so it doesn't become a superscript. More generally, I couldn't find any way to edit a bug, change bug state, or anything else. Just create, and add more comments. I'm assuming that's because I don't have the appropriate admin privileges, and I'm fine with that. I just want to be sure I'm not missing something and I could have fixed this formatting myself, and/or I'm expected to change the bug state after submitting the patch. The patch for 1557 is ready to go, but I was waiting for some visible disposition / feedback on the 1447 patch I sent Wednesday. To make sure I did that one correctly before doing another. Regarding the patch email: Is it necessary to include all the run_tests output? Just the summary? Just assume it ran because that's SOP? Thanks and regards, -dan

3 2