- Developers - lists.chirpmyradio.com

[chirp_devel] [bj-uv55] patch for initial support - need help from UV-5R experts/testers
by Jens J. 15 Nov '13

15 Nov '13

[bj-uv55] initial channel editing support #1201 patch attached. This is definately a UV-5R clone (in terms of architecture), but in a mobile form-factor. Therefore, there are several differences in terms of offsets of settings locations, id/band-range, etc in the memory map. I have made a few changes to the uv5r.py driver which I am hoping wont impact other covered models, but ask for some help in testing, as I do not have an UV-5R (or similar) to do regression tests against. Also, I'm trying to understand what to modify so that when opening a radio image file, it will recognize this image as being BJ-UV55. I assume this has something to do with header bytes, but it wasnt so clear to me reading over the code. I have also tried to simplify a few areas with list comprehension, like: - if "BFB" not in radio_version and "82" not in radio_version and "USA" not in radio_version: + if not any(type in radio_version for type in ["BFB", "82", "USA", "BJ55"]): however, it appears to me these should be simplified further to something like: if radio._basetype not in radio_version: // make better use of _basetype! -Jens AF5MI

3 8

Re: [chirp_devel] TYT TH-UVF8D support
by Eric Allen 15 Nov '13

15 Nov '13

> > Cool, thanks! Just a few comments from a quick skim: > > - return "Memory %i: %s%s%s %s (%s) r%.1f%s c%.1f%s d%03i%s%s > [%.2f]"% \ > > + return "Memory %s: %s%s%s %s (%s) r%.1f%s c%.1f%s d%03i%s%s > [%.2f]"% \ > The number is an integer, so this doesn't make sense, AFAICT. > aw shucks, you're totally right. I had it in there before I figured out how to use special channels correctly. > > + #if data != radio._mmap[:32]: > > + #raise errors.RadioError("Model mis-match: \n%s\n%s" % > (util.hexprint(data), > > + > #util.hexprint(radio._mmap[:32]))) > Why is this commented-out? > Thanks for catching that! Disabled it while getting the hang of the memory layout and forgot to re-enable > > + > > + for i in range(0, 0x4000, 0x20): > > + addr = i + 0x20 > > + msg = struct.pack(">cHb", "W", i, 0x20) > > + msg += radio._mmap[addr:addr+0x20] > Need space around the + operator here > Fixed. > > + def _decode_tone(self, toneval): > > + pol = "N" > > + rawval = (toneval[1].get_bits(0xFF) << 8) | > toneval[0].get_bits(0xFF) > Doesn't this just mean you need to use the other endianess of your toneval? > I copy-pasted from thuv1f.py without thinking too hard about it. There's a bunch more code in _decode_tone and _encode_tone that rely on this particular endianness. Can we just leave it as-is, since the other code does it this way? > > + if isinstance(number, int): > > + enabled = self._memobj.enable[(number - 1) / > 8].flags[7-((number - 1) % 8)] > > + dont_skip = self._memobj.skip[(number - 1) / > 8].flags[7-((number - 1) % 8)] > Need space around the - operator. > fixed > > + if dont_skip: > > + mem.skip = "" > > + else: > > + mem.skip = "S" > This should be four-space indented. > fixed > Also, this could be compacted to: > mem.skip = "S" if not dont_skip else "" > Thanks! fixed > > + if mem.empty: > > + _mem.set_raw("\xFF" * 32) > > + self._memobj.enable[(mem.number - 1) / > 8].flags[7-((mem.number - 1) % 8)] = False > > + self._memobj.skip[(mem.number - 1) / > 8].flags[7-((mem.number - 1) % 8)] = False > > + return > > + else: > > + self._memobj.enable[(mem.number - 1) / > 8].flags[7-((mem.number - 1) % 8)] = True Need spaces around the - operator. > fixed > > + self._memobj.skip[(mem.number - 1) / 8].flags[7-((mem.number - > 1) % 8)] = (mem.skip == "") > Here too. > fixed On Mon, Oct 7, 2013 at 8:00 AM, Dan Smith <dsmith(a)danplanet.com> wrote: > > I acquired a TYT TH-UVF8D several months back, and I've finally found > > the time to finish off adding support for it to CHIRP. In adding support > > for editing the VFO channels as "Special Channels", I had to make a > > small tweak to the command-line utility so it didn't choke on > > non-numeric channel names. Attached is the patch for that, the patch for > > the radio, and an image file dumped from the radio for testing purposes. > > Cool, thanks! Just a few comments from a quick skim: > > > - return "Memory %i: %s%s%s %s (%s) r%.1f%s c%.1f%s d%03i%s%s > [%.2f]"% \ > > + return "Memory %s: %s%s%s %s (%s) r%.1f%s c%.1f%s d%03i%s%s > [%.2f]"% \ > > The number is an integer, so this doesn't make sense, AFAICT. > > > + #if data != radio._mmap[:32]: > > + #raise errors.RadioError("Model mis-match: \n%s\n%s" % > (util.hexprint(data), > > + > #util.hexprint(radio._mmap[:32]))) > > Why is this commented-out? > > > + > > + for i in range(0, 0x4000, 0x20): > > + addr = i + 0x20 > > + msg = struct.pack(">cHb", "W", i, 0x20) > > + msg += radio._mmap[addr:addr+0x20] > > Need space around the + operator here > > > + def _decode_tone(self, toneval): > > + pol = "N" > > + rawval = (toneval[1].get_bits(0xFF) << 8) | > toneval[0].get_bits(0xFF) > > Doesn't this just mean you need to use the other endianess of your toneval? > > > + if isinstance(number, int): > > + enabled = self._memobj.enable[(number - 1) / > 8].flags[7-((number - 1) % 8)] > > + dont_skip = self._memobj.skip[(number - 1) / > 8].flags[7-((number - 1) % 8)] > > Need space around the - operator. > > > + if dont_skip: > > + mem.skip = "" > > + else: > > + mem.skip = "S" > > This should be four-space indented. > > Also, this could be compacted to: > > mem.skip = "S" if not dont_skip else "" > > > + if mem.empty: > > + _mem.set_raw("\xFF" * 32) > > + self._memobj.enable[(mem.number - 1) / > 8].flags[7-((mem.number - 1) % 8)] = False > > + self._memobj.skip[(mem.number - 1) / > 8].flags[7-((mem.number - 1) % 8)] = False > > + return > > + else: > > + self._memobj.enable[(mem.number - 1) / > 8].flags[7-((mem.number - 1) % 8)] = True > > Need spaces around the - operator. > > > + self._memobj.skip[(mem.number - 1) / 8].flags[7-((mem.number - > 1) % 8)] = (mem.skip == "") > > Here too. > > -- > Dan Smith > www.danplanet.com > KK7DS > > > _______________________________________________ > chirp_devel mailing list > chirp_devel(a)intrepid.danplanet.com > http://intrepid.danplanet.com/mailman/listinfo/chirp_devel > Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers >

2 1

[chirp_devel] [BJ-UV55] help with uv5r.py
by Jens J. 09 Nov '13

09 Nov '13

I'm working on the BJ-UV55, and after inspecting the serial comms and memory format, I have concluded that this is essentially a clone (at least memory/program-wise) of UV5R. It uses the same memory format, similar ident string, and same programming protocol. So I have set this ident string as follows: BJUV55_MODEL = "\x50\xBB\xDD\x55\x63\x98\x4D" However, when using chirp, the radio never acks this (with 0x06) Looking at portmon, etc, I see that the baud and settings (9600, 8N1) are correct. It's not just chirp. If I try to interrogate with ident string from something like realterm, the radio never responds. I'm sure that everything is correct, but the radio still refuses to respond. (I've tried this on linux and windows.) I have also tried doing a factory reset on the radio. The radio will continue to respond just fine to the OEM (but extremely crappy) software with same handshake. Has anyone else encountered this sort of behavior with the UV5R clone or similar families? Any thoughts or ideas? PS. one thought was maybe the oem software is doing some tricks with toggling DTR/RTS. I did try to fiddle around with various combinations, but so far no luck. (One oddity I did notice was that when serial line was set to BREAK, the radio keyed up PTT! Maybe this is something to do with the cable pinout?) -Jens AF5MI

1 1

[chirp_devel] FYI, new instruction dialog break with old version of GTK
by Robert Terzi 05 Nov '13

05 Nov '13

Just an FYI, because I don't think it's worthy of a bug report: The new download/upload instruction dialogs seems to break things with the old version of GTK+ 2.0 (2.18.9) on the old linux box I've been using for radio programming. The problematic code is for forcing the input focus to the OK button. The work around is to either comment out the 3 lines that set the focus or to enable the "No Confirm" feature, which needs to be done by manually editing your ~/.chirp/chirp.config file to add the following lines. [noconfirm] clone_instructions = True Alternatively, comment out the following 3 lines. The dialog box will work still work the same but the default input focus will unfortunately be on the "don't show" check box since it appears before the OK button. diff -r 1c8ef954a71b chirpui/mainapp.py --- a/chirpui/mainapp.py Wed Oct 30 08:22:46 2013 -0500 +++ b/chirpui/mainapp.py Sat Nov 02 10:28:01 2013 -0400 @@ -592,9 +592,9 @@ again.show() d.vbox.pack_start(again, 0, 0, 0) h_button_box=d.vbox.get_children()[2] - ok_button=h_button_box.get_children()[0] - ok_button.grab_default() - ok_button.grab_focus() +# ok_button=h_button_box.get_children()[0] +# ok_button.grab_default() +# ok_button.grab_focus() d.run() d.destroy() CONF.set_bool("clone_instructions", again.get_active(), "noconfirm") Here's the error message: Traceback (most recent call last): File "/home/rct/tmp/chirp.hg/chirpui/mainapp.py", line 1338, in mh self.do_download(*args) File "/home/rct/tmp/chirp.hg/chirpui/mainapp.py", line 615, in do_download self._show_instructions(rclass, rclass.get_prompts().pre_download) File "/home/rct/tmp/chirp.hg/chirpui/mainapp.py", line 595, in _show_instructions ok_button=h_button_box.get_children()[0] AttributeError: 'gtk.HSeparator' object has no attribute 'get_children' Hope this helps, --Rob

2 3

[chirp_devel] [PATCH] GTK+ 2.0 can't grab button focus, handle gracefully. Fixes #1219
by Tom Hayward 05 Nov '13

05 Nov '13

# HG changeset patch # User Tom Hayward <tom(a)tomh.us> # Date 1383678660 28800 # Node ID d57bc05a9dd64c57e3246e74d12fe04bcf640526 # Parent b989118832cb7d4a7586f026f9f205313234ea69 GTK+ 2.0 can't grab button focus, handle gracefully. Fixes #1219 diff -r b989118832cb -r d57bc05a9dd6 chirpui/mainapp.py --- a/chirpui/mainapp.py Thu Oct 10 17:17:20 2013 -0700 +++ b/chirpui/mainapp.py Tue Nov 05 11:11:00 2013 -0800 @@ -591,10 +591,14 @@ again = gtk.CheckButton(_("Don't show instructions for any radio again")) again.show() d.vbox.pack_start(again, 0, 0, 0) - h_button_box=d.vbox.get_children()[2] - ok_button=h_button_box.get_children()[0] - ok_button.grab_default() - ok_button.grab_focus() + h_button_box = d.vbox.get_children()[2] + try: + ok_button = h_button_box.get_children()[0] + ok_button.grab_default() + ok_button.grab_focus() + except AttributeError: + # don't grab focus on GTK+ 2.0 + pass d.run() d.destroy() CONF.set_bool("clone_instructions", again.get_active(), "noconfirm")

1 0

[chirp_devel] [ft-90] fixes for import/export errors #1217
by Jens J. 05 Nov '13

05 Nov '13

patch attached

1 0

[chirp_devel] [PATCH] GTK+ 2.0 can't grab button focus, handle gracefully
by Tom Hayward 02 Nov '13

02 Nov '13

# HG changeset patch # User Tom Hayward <tom(a)tomh.us> # Date 1383404558 25200 # Node ID 57ec665333eb8c0757fbbfb6a37f7d1a40c727e4 # Parent b989118832cb7d4a7586f026f9f205313234ea69 GTK+ 2.0 can't grab button focus, handle gracefully. diff -r b989118832cb -r 57ec665333eb chirpui/mainapp.py --- a/chirpui/mainapp.py Thu Oct 10 17:17:20 2013 -0700 +++ b/chirpui/mainapp.py Sat Nov 02 08:02:38 2013 -0700 @@ -591,10 +591,14 @@ again = gtk.CheckButton(_("Don't show instructions for any radio again")) again.show() d.vbox.pack_start(again, 0, 0, 0) - h_button_box=d.vbox.get_children()[2] - ok_button=h_button_box.get_children()[0] - ok_button.grab_default() - ok_button.grab_focus() + h_button_box = d.vbox.get_children()[2] + try: + ok_button = h_button_box.get_children()[0] + ok_button.grab_default() + ok_button.grab_focus() + except AttributeError: + # don't grab focus on GTK+ 2.0 + pass d.run() d.destroy() CONF.set_bool("clone_instructions", again.get_active(), "noconfirm")

1 0

[chirp_devel] [vx-6] implement bank support #151
by Jens J. 31 Oct '13

31 Oct '13

patch attached

1 0

[chirp_devel] TYT TH-UVF8D support
by Eric Allen 31 Oct '13

31 Oct '13

Hey guys, I acquired a TYT TH-UVF8D several months back, and I've finally found the time to finish off adding support for it to CHIRP. In adding support for editing the VFO channels as "Special Channels", I had to make a small tweak to the command-line utility so it didn't choke on non-numeric channel names. Attached is the patch for that, the patch for the radio, and an image file dumped from the radio for testing purposes. Tests: TYT TH-UVF8D Detect PASSED: All tests TYT TH-UVF8D CopyAll PASSED: All tests TYT TH-UVF8D Clone PASSED: All tests TYT TH-UVF8D BruteForce PASSED: All tests TYT TH-UVF8D Edges PASSED: All tests TYT TH-UVF8D Banks SKIPPED: Banks not supported ---------------------------------------------------------------------- Results: TOTAL : 6 FAILED : 0 SKIPPED: 1 PASSED : 5 CRASHED: 0 -Eric

2 2

[chirp_devel] little utility to watch and print binary changes to files
by Jens J. 31 Oct '13

31 Oct '13

Here is a quick and dirty "binary diff watcher" to show hex and binary differences and the offsets of two files. The general idea is to take control sample image file, and then edit a second copy of it in whatever program so that you can see what is getting twiddled. This is a little bit faster cycle than looking at in a hex editor. If we can refine this a bit and make it more useful, perhaps it's worthy of committing to tools folder... -Jens AF5MI usage: bincmp.py [--offset <start_at_hex_offset>] [--watch] -1 <file1> -2 <file2> example: $./bincmp.py -1 ft90-test.img -2 ft90-test2.img 1: ft90-test.img 2: ft90-test2.img @0105h 1:41h, 01000001b 2:44h, 01000100b @010Fh 1:00h, 00000000b 2:33h, 00110011b bytes read: 4063

3 3