February 2021 - Developers - lists.chirpmyradio.com

[chirp_devel] [PATCH] [thd74] Add a Kenwood d74 driver
by Angus Ainslie 14 Nov '21

14 Nov '21

# HG changeset patch # User Angus Ainslie <angus(a)akkea.ca> # Date 1592188302 25200 # Sun Jun 14 19:31:42 2020 -0700 # Branch py3 # Node ID eb35a46c5f7e43518f6adc88768107efc0a3d402 # Parent b1e01577ff2505de7fcca665bf3d6af296f0f7ca [thd74] Add a Kenwood d74 driver Based on code from Tom Hayward, Eric Wolak, William McKeehan https://chirp.danplanet.com/issues/4129 This works with python3 no idea about python2 diff --git a/chirp/drivers/thd74.py b/chirp/drivers/thd74.py new file mode 100644 --- /dev/null +++ b/chirp/drivers/thd74.py @@ -0,0 +1,571 @@ +import logging +import struct +import binascii + +import time + +from chirp import directory, bitwise, errors, chirp_common, memmap +from chirp.settings import RadioSettingGroup, RadioSetting, RadioSettings, \ + RadioSettingValueInteger, RadioSettingValueString, \ + RadioSettingValueList, RadioSettingValueBoolean, \ + InvalidValueError + +from . import thd72 +from chirp.util import hexprint + +LOG = logging.getLogger(__name__) + +# Save files from MCP-D74 have a 256-byte header, and possibly some oddness +# TH-D74 memory map + +# 0x02000: memory flags, 4 bytes per memory +# 0x04000: memories, each 40 bytes long +# 0x10000: names, each 16 bytes long, null padded, ascii encoded + +# memory channel +# 0 1 2 3 4 5 6 7 8 9 a b c d e f +# [freq ] ? mode tmode/duplex rtone ctone dtcs cross_mode [offset] ? + +# frequency is 32-bit unsigned little-endian Hz + +DEFAULT_PROG_VFO = ( + (136000000, 174000000), + (410000000, 470000000), + (118000000, 136000000), + (136000000, 174000000), + (320000000, 400000000), + (400000000, 524000000), +) + +# Some of the blocks written by MCP have a length set of less than 0x00/256 +BLOCK_SIZES = { + 0x0003: 0x00B4, + 0x0007: 0x0068, +} + +mem_format = """ +// TODO: find lockout + +#seekto 0x10c0; +struct { + char power_on_msg[16]; + char modem_name[16]; +} onmsg_name; + +#seekto 0x1200; +struct { + char callsign[8]; +} callsign; + +#seekto 0x02000; +struct { +// 4 bytes long + u8 disabled; + u8 unk; + u8 group; + u8 unk2; +} flag[1032]; + +#seekto 0x04000; +// TODO: deal with the 16-byte trailers of every block +struct { + struct { + ul32 freq; + ul32 offset; + + u8 tuning_step:4, + unk:4; + u8 mode:4, + unk1:4; + u8 tone_mode:4, + duplex:4; + u8 rtone; + + u8 ctone; + u8 dtcs; + u8 cross_mode:4 + digital_squelch:4; + char urcall[8]; + char rpt1[8]; + char rpt2[8]; + + u8 digital_squelch_code; + + } mem[6]; + + u8 pad[16]; +} memory[1167]; // TODO: correct number of memories + +#seekto 0x10000; +struct { + char name[16]; +} channel_name[1000]; + +#seekto 0x14700; +struct { + char name[16]; +} wx_name[10]; + +#seekto 0x144d0; +struct { + char name[16]; +} call_name[6]; + +#seekto 0x14800; +struct { + char name[16]; +} group_name[31]; +""" + +STEPS = [5.0, 6.25, None, None, 10.0, 12.5, 15.0, 20.0, 25.0, 50.0, 100.0, 9.0] +MODES = [ + "FM", + "DV", + "AM", + "LSB", + "USB", + "CW", + "NFM", + "DV" +] + +def hex(data): + data_txt = "" + for idx in range(0, len(data), 16): + bytes = binascii.hexlify(str(data[idx:idx+16]).encode('utf8')).upper() + for idx in range(0, len(bytes), 2): + data_txt += str(bytes[idx:idx+2]) + " " + data_txt += "\n" + return data_txt.strip() + +class SProxy(object): + def __init__(self, delegate): + self.delegate = delegate + + def read(self, len): + r = self.delegate.read(len) + LOG.debug("READ\n" + hex(r)) + return r + + def write(self, data): + LOG.debug("WRITE\n" + hex(data)) + return self.delegate.write(str(data)) + + @property + def timeout(self): + return self.delegate.timeout + + @timeout.setter + def timeout(self, timeout): + self.delegate.timeout = timeout + + + +(a)directory.register +class THD74Radio(thd72.THD72Radio): + MODEL = "TH-D74 (clone mode)" + #MODEL = "TH-D74" + _memsize = 500480 + # I think baud rate might be ignored by USB-Serial stack of the D74's + # on-board FTDI chip, but it doesn't seem to hurt. + BAUD_RATE = 115200 + + + #def __init__(self, pipe): + # pipe = SProxy(pipe) + # super(THD74Radio, self).__init__(pipe) + + def get_features(self): + rf = super(THD74Radio, self).get_features() + rf.has_tuning_step = True + return rf + + def process_mmap(self): + self._memobj = bitwise.parse(mem_format, self._mmap) + self._dirty_blocks = [] + + def sync_in(self): + # self._detect_baud() + self._mmap = self.download() + self.process_mmap() + + def sync_out(self): + if len(self._dirty_blocks): + self.upload(self._dirty_blocks) + else: + self.upload() + + def read_block(self, block, count=256): + cmd = struct.pack(">cHH", b"R", block, count%256) + print( "Read cmd %s" % cmd ) + self.pipe.write(''.join(chr(b) for b in cmd)) + + r = self.pipe.read(5) + if len(r) != 5: + raise Exception("Did not receive block response") + + print( "Read input %s %i %i %i %i" % ( r, ord(r[1]), ord(r[2]), ord(r[3]), ord(r[4] ))) + + #cmd, _block, _ = struct.unpack(">cHH", b''.join(ord(b) for b in r)) + cmd = r[0] + _block = (ord(r[1]) << 8) + ord(r[2]) + if cmd != 'W' or _block != block: + raise Exception("Invalid response: %s %i %i" % (cmd, block, _block)) + + data = "" + while len(data) < count: + data += self.pipe.read(count - len(data)) + + self.pipe.write(chr(0x06)) + if self.pipe.read(1) != chr(0x06): + raise Exception("Did not receive post-block ACK!") + + return data + + def write_block(self, block, map, count=256): + #print("Write block ", block ) + c = struct.pack(">cHH", b"W", block, count%256) + base = block * 256 + data = map[base:base + count] + # It's crucial that these are written together. Otherwise the radio + # will fail to ACK under some conditions. + c_d = ''.join(chr(b) for b in c) + data + self.pipe.write(c_d) + + ack = self.pipe.read(1) + + if len(ack) == 0: + print("read timed out block %d - trying again" % block ) + time.sleep(0.5) + ack = self.pipe.read(1) + + if ack != chr(0x06): + print("Block %d write failed %d" % ( block, ord(ack))) + + return ack == chr(0x06) + + def _unlock(self): + """Voodoo sequence of operations to get the radio to accept our programming.""" + + h = self.read_block(0, 6) + + unlock = ("\x57\x00\x00\x00\x30\xff\x01\xff\x00\x00\xff\xff\xff\xff\xff\x01" + + "\x00\x00\x00\x03\x01\x00\x00\x00\x00\x02\x00\x30\x30\x30\x00\xff" + + "\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff" + + "\xff\xff\xff\xff\xff") + + self.pipe.write(unlock) + + ack = self.pipe.read(1) + + if ack != chr(0x06): + raise errors.RadioError("Expected ack but got {} ({})".format(ord(ack), type(ack))) + + c = struct.pack(">cHH", b"W", 0, 0x38C8) + self.pipe.write(''.join(chr(b) for b in c)) + # magic unlock sequence + unlock = [0xFF] * 8 + [0] * 160 + [0xFF] * 32 + unlock = "".join([chr(x) for x in unlock]) + self.pipe.write(unlock) + + time.sleep(0.01) + ack = self.pipe.read(1) + + if ack != chr(0x06): + raise errors.RadioError("Expected ack but got {} ({})".format(ord(ack), type(ack))) + + def download(self, raw=False, blocks=None): + if blocks is None: + blocks = list(range(int(self._memsize / 256))) + else: + blocks = [b for b in blocks if b < int(self._memsize / 256)] + + if self.command("0M PROGRAM", 2, timeout=1.5) != "0M": + raise errors.RadioError("Radio didn't go into PROGRAM mode") + + allblocks = list(range(int(self._memsize / 256))) + self.pipe.baudrate = 57600 + try: + self.pipe.setRTS() + except AttributeError: + self.pipe.rts = True + self.pipe.read(1) + data = "" + LOG.debug("reading blocks %d..%d" % (blocks[0], blocks[-1])) + total = len(blocks) + count = 0 + for i in allblocks: + if i not in blocks: + data += 256 * '\xff' + continue + data += self.read_block(i) + count += 1 + if self.status_fn: + s = chirp_common.Status() + s.msg = "Cloning from radio" + s.max = total + s.cur = count + self.status_fn(s) + + + self.pipe.write("E") + if raw: + return data + return memmap.MemoryMap(data) + + def upload(self, blocks=None): + # MCP-D74 sets DTR, so we should too + try: + self.pipe.setDTR() + except AttributeError: + self.pipe.dtr = True + + if blocks is None: + blocks = list(range((int(self._memsize / 256)) - 2)) + else: + blocks = [b for b in blocks if b < int(self._memsize / 256)] + + if self.command("0M PROGRAM", 2, timeout=1.5) != "0M": + raise errors.RadioError("Radio didn't go into PROGRAM mode") + + if self._unlock(): + raise errors.RadioError("Unlock failed") + + # This block definitely isn't written conventionally, so we let _unlock + # handle it and skip. + if 0 in blocks: + blocks.remove(0) + + # For some reason MCP-D74 skips this block. If we don't, we'll get a NACK + # on the next one. There is also a more than 500 ms delay for the ACK. + if 1279 in blocks: + blocks.remove(1279) + + print("writing blocks %d..%d" % (blocks[0], blocks[-1])) + total = len(blocks) + count = 0 + for i in blocks: + time.sleep(0.001) + r = self.write_block(i, self._mmap, BLOCK_SIZES.get(i, 256)) + count += 1 + if not r: + raise errors.RadioError("write of block %i failed" % i) + if self.status_fn: + s = chirp_common.Status() + s.msg = "Cloning to radio" + s.max = total + s.cur = count + self.status_fn(s) + + lock = ("\x57\x00\x00\x00\x06\x02\x01\xff\x00\x00\xff") + self.pipe.write(lock) + + self.pipe.write("F") + # clear out blocks we uploaded from the dirty blocks list + self._dirty_blocks = [b for b in self._dirty_blocks if b not in blocks] + + def command(self, cmd, response_length, timeout=0.5): + start = time.time() + + LOG.debug("PC->D72: %s" % cmd) + default_timeout = self.pipe.timeout + self.pipe.write(cmd + "\r") + self.pipe.timeout = timeout + try: + data = self.pipe.read(response_length + 1) + LOG.debug("D72->PC: %s" % data.strip()) + finally: + self.pipe.timeout = default_timeout + return data.strip() + + def get_raw_memory(self, number): + bank = number // 6 + idx = number % 6 + + _mem = self._memobj.memory[bank].mem[idx] + return repr(_mem) + \ + repr(self._memobj.flag[number]) + + def get_id(self): + r = self.command("ID", 9) + if r.startswith("ID "): + return r.split(" ")[1] + else: + raise errors.RadioError("No response to ID command") + + def set_channel_name(self, number, name): + name = name[:16] + '\x00' * 16 + if number < 999: + self._memobj.channel_name[number].name = name[:16] + self.add_dirty_block(self._memobj.channel_name[number]) + elif number >= 1020 and number < 1030: + number -= 1020 + self._memobj.wx_name[number].name = name[:16] + self.add_dirty_block(self._memobj.wx_name[number]) + + def get_memory(self, number): + if isinstance(number, str): + try: + number = thd72.THD72_SPECIAL[number] + except KeyError: + raise errors.InvalidMemoryLocation("Unknown channel %s" % + number) + + if number < 0 or number > (max(thd72.THD72_SPECIAL.values()) + 1): + raise errors.InvalidMemoryLocation( + "Number must be between 0 and 999") + + bank = number // 6 + idx = number % 6 + + #print("reading memory #%d bank %d entry %d" %(number, bank, idx)) + _mem = self._memobj.memory[bank].mem[idx] + flag = self._memobj.flag[number] + + #print("Memory mode %d" % _mem.mode) + if _mem.mode < len( MODES ) and MODES[_mem.mode] == "DV": + mem = chirp_common.DVMemory() + else: + mem = chirp_common.Memory() + + mem.number = number + + if number > 999: + mem.extd_number = thd72.THD72_SPECIAL_REV[number] + if flag.disabled == 0xFF: + mem.empty = True + return mem + + mem.name = self.get_channel_name(number) + mem.freq = int(_mem.freq) + mem.tmode = thd72.TMODES[int(_mem.tone_mode)] + mem.rtone = chirp_common.TONES[_mem.rtone] + mem.ctone = chirp_common.TONES[_mem.ctone] + mem.dtcs = chirp_common.DTCS_CODES[_mem.dtcs] + mem.duplex = thd72.DUPLEX[int(_mem.duplex)] + mem.offset = _mem.offset + mem.mode = MODES[int(_mem.mode)] + mem.tuning_step = STEPS[_mem.tuning_step] + + if mem.mode == "DV": + mem.dv_urcall = _mem.urcall + mem.dv_rpt1call = _mem.rpt1 + mem.dv_rpt2call = _mem.rpt2 + mem.dv_code = _mem.digital_squelch_code + + if number < 999: + # mem.skip = chirp_common.SKIP_VALUES[int(flag.skip)] + mem.cross_mode = chirp_common.CROSS_MODES[_mem.cross_mode] + if number > 999: + mem.cross_mode = chirp_common.CROSS_MODES[0] + mem.immutable = ["number", "bank", "extd_number", "cross_mode"] + if number >= 1020 and number < 1030: + mem.immutable += ["freq", "offset", "tone", "mode", + "tmode", "ctone", "skip"] # FIXME: ALL + else: + mem.immutable += ["name"] + + return mem + + def set_memory(self, mem): + LOG.debug("set_memory(%d)" % mem.number) + if mem.number < 0 or mem.number > (max(thd72.THD72_SPECIAL.values()) + 1): + raise errors.InvalidMemoryLocation( + "Number must be between 0 and 999") + + # weather channels can only change name, nothing else + if mem.number >= 1020 and mem.number < 1030: + self.set_channel_name(mem.number, mem.name) + return + + flag = self._memobj.flag[mem.number] + self.add_dirty_block(self._memobj.flag[mem.number]) + + # only delete non-WX channels + was_empty = flag.disabled == 0xf + if mem.empty: + flag.disabled = 0xf + return + flag.disabled = 0 + + bank = mem.number // 6 + idx = mem.number % 6 + + print("seting memory #%d bank %d entry %d" %(mem.number, bank, idx)) + _mem = self._memobj.memory[bank].mem[idx] + self.add_dirty_block(_mem) + if was_empty: + self.initialize(_mem) + + _mem.freq = mem.freq + + if mem.number < 999: + self.set_channel_name(mem.number, mem.name) + + _mem.tone_mode = thd72.TMODES_REV[mem.tmode] + _mem.rtone = chirp_common.TONES.index(mem.rtone) + _mem.ctone = chirp_common.TONES.index(mem.ctone) + _mem.dtcs = chirp_common.DTCS_CODES.index(mem.dtcs) + _mem.cross_mode = chirp_common.CROSS_MODES.index(mem.cross_mode) + _mem.duplex = thd72.DUPLEX_REV[mem.duplex] + _mem.offset = mem.offset + _mem.mode = thd72.MODES_REV[mem.mode] + + prog_vfo = thd72.get_prog_vfo(mem.freq) + #flag.prog_vfo = prog_vfo + + #if mem.number < 999: + # flag.skip = chirp_common.SKIP_VALUES.index(mem.skip) + + + @staticmethod + def _add_00_pad(val, length): + return val.ljust(length, "\x00")[:length] + + + @classmethod + def apply_callsign(cls, setting, obj): + callsign = setting.value.get_value().upper() + setattr(obj, "callsign", cls._add_00_pad(callsign, 8)) + + + @classmethod + def apply_power_on_msg(cls, setting, obj): + msg = setting.value.get_value() + setattr(obj, "power_on_msg", cls._add_00_pad(msg, 16)) + + + def _get_general_settings(self): + menu = RadioSettingGroup("general", "General") + cs = self._memobj.callsign + + val = RadioSettingValueString( + 0, 6, str(cs.callsign).rstrip("\x00")) + rs = RadioSetting("cs.callsign", "Callsign", val) + rs.set_apply_callback(self.apply_callsign, cs) + menu.append(rs) + + msg = self._memobj.onmsg_name + + val = RadioSettingValueString( + 0, 16, str(msg.power_on_msg).rstrip("\x00")) + rs = RadioSetting("msg.power_on_msg", "Power on message", val) + rs.set_apply_callback(self.apply_power_on_msg, msg) + menu.append(rs) + + return menu + + + def _get_settings(self): + top = RadioSettings(self._get_general_settings()) + return top + + + def get_settings(self): + try: + return self._get_settings() + except: + import traceback + LOG.error("Failed to parse settings: %s", traceback.format_exc()) + return None +

4 4

[chirp_devel] Python3 Update - Need Help Testing
by Matthew Poletiek 23 May '21

23 May '21

Hi All, I've made a lot of progress on getting the latest py3 branch working across multiple platforms. I'm maintaining all my working changes here for now: https://github.com/mpoletiek/py3-CHIRP I've even made a list of supported devices and am marking the ones I've personally tested: https://github.com/mpoletiek/py3-CHIRP/blob/main/RADIOS.md Currently I only own a BF-F8HP so I've marked all the Radios that use that driver `TESTED`. I've been playing around with Tox and testing the other drivers that way too. With a few changes I was able to get it working and run every test against every driver. A lot of them passed every test just fine, but a lot of them are failing here and there. As expected the debug.log is quite long and I figured I'd go through the drivers one by one that way, but the recommended syntax for doing that doesn't seem to work as expected. https://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess `tox -e driver -- -d Icom_IC-2820H` Running this command gives me the following in a Python3.7 environment: `ERROR: MISSING test execution (tx) nodes: please specify --tx` When I add '-n 2' or `--tx popen//python=python3.7` to the pytest command it exits with `code: 5 (no tests run)` Anyone familiar enough with tox to help me out with this? There's also a py3driver env setup in the tox.ini file, but that doesn't work either. Thanks, ------------------------------------------- Matthew Poletiek 303.810.9082 matthew.poletiek(a)gmail.com www.matthewpoletiek.com

2 1

[chirp_devel] Fwd: [PATCH] [BF-F8HP] Fix for out-of-range TXP values in VFOs
by Jim Unroe 24 Feb '21

24 Feb '21

---------- Forwarded message --------- From: Jim Unroe <kc9hi(a)comcast.net> Date: Wed, Feb 24, 2021 at 5:23 PM Subject: [PATCH] [BF-F8HP] Fix for out-of-range TXP values in VFOs To: <Rock.Unroe(a)gmail.com> # HG changeset patch # User Jim Unroe <rock.unroe(a)gmail.com> # Date 1614205381 18000 # Wed Feb 24 17:23:01 2021 -0500 # Node ID 9e2559a3722e1bf4ce7eb9d24e93197a6e162084 # Parent 9302d496db2b2082e99fab333d3c943d948a954d [BF-F8HP] Fix for out-of-range TXP values in VFOs This patch forces out-of-range TXP values to a valid value. Fixes #8539 diff -r 9302d496db2b -r 9e2559a3722e chirp/drivers/uv5r.py --- a/chirp/drivers/uv5r.py Tue Feb 23 21:28:16 2021 -0500 +++ b/chirp/drivers/uv5r.py Wed Feb 24 17:23:01 2021 -0500 @@ -1488,16 +1488,24 @@ workmode.append(rs) if self._tri_power: + if _vfoa.txpower3 > 0x02: + val = 0x00 + else: + val = _vfoa.txpower3 rs = RadioSetting("vfoa.txpower3", "VFO A Power", RadioSettingValueList( TXPOWER3_LIST, - TXPOWER3_LIST[_vfoa.txpower3])) + TXPOWER3_LIST[val])) workmode.append(rs) + if _vfob.txpower3 > 0x02: + val = 0x00 + else: + val = _vfob.txpower3 rs = RadioSetting("vfob.txpower3", "VFO B Power", RadioSettingValueList( TXPOWER3_LIST, - TXPOWER3_LIST[_vfob.txpower3])) + TXPOWER3_LIST[val])) workmode.append(rs) else: rs = RadioSetting("vfoa.txpower", "VFO A Power",

1 0

[chirp_devel] Fwd: [PATCH 2 of 2] [TK-862] Add valid_tuning_steps for Kenwood TK-862 (and others)
by Jim Unroe 23 Feb '21

23 Feb '21

---------- Forwarded message --------- From: Jim Unroe <kc9hi(a)comcast.net> Date: Tue, Feb 23, 2021 at 9:37 PM Subject: [PATCH 2 of 2] [TK-862] Add valid_tuning_steps for Kenwood TK-862 (and others) To: <Rock.Unroe(a)gmail.com> # HG changeset patch # User Jim Unroe <rock.unroe(a)gmail.com> # Date 1614133696 18000 # Tue Feb 23 21:28:16 2021 -0500 # Node ID 9302d496db2b2082e99fab333d3c943d948a954d # Parent 91985c182076023b6172634c2910fa050d119f0b [TK-862] Add valid_tuning_steps for Kenwood TK-862 (and others) This patch adds valid tuning steps for the Kenwood TK-862 and the following Kenwood radio models. TK76x, TK-86x fixes #8245 diff -r 91985c182076 -r 9302d496db2b chirp/drivers/tk760.py --- a/chirp/drivers/tk760.py Tue Feb 23 21:27:44 2021 -0500 +++ b/chirp/drivers/tk760.py Tue Feb 23 21:28:16 2021 -0500 @@ -403,6 +403,7 @@ rf.valid_dtcs_codes = DTCS_CODES rf.valid_bands = [self._range] rf.memory_bounds = (1, self._upper) + rf.valid_tuning_steps = [5., 6.25, 10., 12.5] return rf def sync_in(self):

1 0

[chirp_devel] Fwd: [PATCH 1 of 2] Driver Maintenance: tk760.py
by Jim Unroe 23 Feb '21

23 Feb '21

An image to run tests against is attached. Jim KC9HI ---------- Forwarded message --------- From: Jim Unroe <kc9hi(a)comcast.net> Date: Tue, Feb 23, 2021 at 9:37 PM Subject: [PATCH 1 of 2] Driver Maintenance: tk760.py To: <Rock.Unroe(a)gmail.com> # HG changeset patch # User Jim Unroe <rock.unroe(a)gmail.com> # Date 1614133664 18000 # Tue Feb 23 21:27:44 2021 -0500 # Node ID 91985c182076023b6172634c2910fa050d119f0b # Parent b4a7f3f45f2894428173a7c9d3f3a345ce11246c Driver Maintenance: tk760.py 1. Add to PEP8 manifest 2. Perform PEP8 cleanup in preperaton to address #8245 diff -r b4a7f3f45f28 -r 91985c182076 chirp/drivers/tk760.py --- a/chirp/drivers/tk760.py Tue Feb 23 20:05:24 2021 -0500 +++ b/chirp/drivers/tk760.py Tue Feb 23 21:27:44 2021 -0500 @@ -13,12 +13,6 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -import time -import struct -import logging - -LOG = logging.getLogger(__name__) - from chirp import chirp_common, directory, memmap from chirp import bitwise, errors, util from chirp.settings import RadioSettingGroup, RadioSetting, \ @@ -27,6 +21,12 @@ RadioSettings from textwrap import dedent +import time +import struct +import logging + +LOG = logging.getLogger(__name__) + MEM_FORMAT = """ #seekto 0x0000; struct { @@ -92,7 +92,8 @@ 0x06: "Scan", 0x07: "Scan Del/Add", 0x08: "Home Channel", - 0x09: "Operator Selectable Tone" + 0x09: "Operator Selectable Tone", + 0x0C: "Unknown" } MEM_SIZE = 0x400 @@ -108,7 +109,7 @@ MODES = ["NFM", "FM"] SKIP_VALUES = ["", "S"] TONES = chirp_common.TONES -#TONES.remove(254.1) +# TONES.remove(254.1) DTCS_CODES = chirp_common.DTCS_CODES TOT = ["off"] + ["%s" % x for x in range(30, 330, 30)] @@ -120,7 +121,7 @@ data = "" try: data = radio.pipe.read(amount) - #print("<= %02i: %s" % (len(data), util.hexprint(data))) + # print("<= %02i: %s" % (len(data), util.hexprint(data))) except: raise errors.RadioError("Error reading data from radio") @@ -131,7 +132,7 @@ """Raw send to the radio device""" try: radio.pipe.write(data) - #print("=> %02i: %s" % (len(data), util.hexprint(data))) + # print("=> %02i: %s" % (len(data), util.hexprint(data))) except: raise errors.RadioError("Error sending data from radio") @@ -162,7 +163,7 @@ ack = rawrecv(radio, 1) # check ACK if ack != ACK_CMD: - #close_radio(radio) + # close_radio(radio) mesg = "Handshake failed: " + msg raise errors.RadioError(mesg) @@ -229,7 +230,7 @@ ident = rawrecv(radio, 8) # validate the input - if len(ident) != 8: + if len(ident) != 8: LOG.debug("Wrong ID, get only %s bytes, we expect 8" % len(ident)) LOG.debug(hexprint(ident)) msg = "Bad ID received, just %s bytes, we want 8" % len(ident) @@ -253,7 +254,7 @@ """This is your download function""" open_radio(radio) - # UI progress + # UI progress status = chirp_common.Status() status.cur = 0 status.max = MEM_SIZE / BLOCK_SIZE @@ -280,7 +281,7 @@ """Upload info to radio""" open_radio(radio) - # UI progress + # UI progress status = chirp_common.Status() status.cur = 0 status.max = MEM_SIZE / BLOCK_SIZE @@ -324,7 +325,7 @@ rid = get_rid(data) # DEBUG - #print("Full ident string is %s" % util.hexprint(rid)) + # print("Full ident string is %s" % util.hexprint(rid)) if (rid in cls.VARIANTS): # correct model @@ -333,7 +334,8 @@ return False -class Kenwood_M60_Radio(chirp_common.CloneModeRadio, chirp_common.ExperimentalRadio): +class Kenwood_M60_Radio(chirp_common.CloneModeRadio, + chirp_common.ExperimentalRadio): """Kenwood Mobile Family 60 Radios""" VENDOR = "Kenwood" _range = [136000000, 500000000] # don't mind, it will be overwritten @@ -346,7 +348,7 @@ rp = chirp_common.RadioPrompts() rp.experimental = \ ('This driver is experimental; not all features have been ' - 'implemented, but it has those features most used by hams.\n' + 'implemented, but it has those features most used by hams.\n' '\n' 'This radios are able to work slightly outside the OEM ' 'frequency limits. After testing, the limit in Chirp has ' @@ -736,28 +738,28 @@ basic.append(clone) # front keys - mon = RadioSetting("settings.kMON", "MON", - RadioSettingValueList(KEYS.values(), - KEYS.values()[KEYS.keys().index( - int(sett.kMON))])) + rs = RadioSettingValueList(KEYS.values(), + KEYS.values()[KEYS.keys().index( + int(sett.kMON))]) + mon = RadioSetting("settings.kMON", "MON", rs) fkeys.append(mon) - a = RadioSetting("settings.kA", "A", - RadioSettingValueList(KEYS.values(), - KEYS.values()[KEYS.keys().index( - int(sett.kA))])) + rs = RadioSettingValueList(KEYS.values(), + KEYS.values()[KEYS.keys().index( + int(sett.kA))]) + a = RadioSetting("settings.kA", "A", rs) fkeys.append(a) - scn = RadioSetting("settings.kSCN", "SCN", - RadioSettingValueList(KEYS.values(), - KEYS.values()[KEYS.keys().index( - int(sett.kSCN))])) + rs = RadioSettingValueList(KEYS.values(), + KEYS.values()[KEYS.keys().index( + int(sett.kSCN))]) + scn = RadioSetting("settings.kSCN", "SCN", rs) fkeys.append(scn) - da = RadioSetting("settings.kDA", "D/A", - RadioSettingValueList(KEYS.values(), - KEYS.values()[KEYS.keys().index( - int(sett.kDA))])) + rs = RadioSettingValueList(KEYS.values(), + KEYS.values()[KEYS.keys().index( + int(sett.kDA))]) + da = RadioSetting("settings.kDA", "D/A", rs) fkeys.append(da) return top @@ -803,7 +805,7 @@ # Apply al configs done # DEBUG - #print("%s: %s" % (setting, value)) + # print("%s: %s" % (setting, value)) setattr(obj, setting, value) diff -r b4a7f3f45f28 -r 91985c182076 tools/cpep8.manifest --- a/tools/cpep8.manifest Tue Feb 23 20:05:24 2021 -0500 +++ b/tools/cpep8.manifest Tue Feb 23 21:27:44 2021 -0500 @@ -92,6 +92,7 @@ ./chirp/drivers/th_uvf8d.py ./chirp/drivers/thd72.py ./chirp/drivers/thuv1f.py +./chirp/drivers/tk760.py ./chirp/drivers/tk8102.py ./chirp/drivers/tk8180.py ./chirp/drivers/tmd710.py

1 0

[chirp_devel] Missing 'Radio' Menu Tab
by Rick (AA0RD) DeWitt 22 Feb '21

22 Feb '21

Has anyone ever seen this? A user from Portugal installed the Jan 07 download... but the 'Radio" menu tab is blank/missing??? I have asked him to update to the Feb 12 version. We will see what happens. --

3 3

[chirp_devel] Another spammer
by Bernhard Hailer 18 Feb '21

18 Feb '21

Hi Dan, there's another spammer who is trying to hide links in seemingly valid looking messages (#37; messages removed). Please remove "Alon Gorevits" from the list of subscribers. Thanks and 73, Bernhard

1 0

[chirp_devel] Fwd: [PATCH] [TH-UV88] Fix missing settings tab due to out-of-range value. #8683
by Jim Unroe 17 Feb '21

17 Feb '21

---------- Forwarded message --------- From: Jim Unroe <kc9hi(a)comcast.net> Date: Wed, Feb 17, 2021 at 7:39 PM Subject: [PATCH] [TH-UV88] Fix missing settings tab due to out-of-range value. #8683 To: <Rock.Unroe(a)gmail.com> # HG changeset patch # User Jim Unroe <rock.unroe(a)gmail.com> # Date 1613608180 18000 # Wed Feb 17 19:29:40 2021 -0500 # Node ID bb57aa1dd1b7f3fb279f3455bbab584d61e14c41 # Parent 5249ae1ee57bb1e7cd45ddba6bde11a68a507673 [TH-UV88] Fix missing settings tab due to out-of-range value. #8683 This patch addresses the out-of-range (or lack of) region code that seems to be present in more recent firmware versions by... - extending the region code list for unknown values from 5 to 15. - logging region code values from 5 to 15 to debug.log file. With contributions from Ruddolph Gutzerhagen. diff -r 5249ae1ee57b -r bb57aa1dd1b7 chirp/drivers/th_uv88.py --- a/chirp/drivers/th_uv88.py Thu Feb 11 15:40:16 2021 -0800 +++ b/chirp/drivers/th_uv88.py Wed Feb 17 19:29:40 2021 -0500 @@ -168,10 +168,13 @@ #seekto 0x191E; struct { - u8 region; // 0x191E Radio Region (read only) + u8 unknown191e:4, // + region:4; // 0x191E Radio Region (read only) // 0 = Unlocked TX: 136-174 MHz / 400-480 MHz + // 2-3 = Unknown // 3 = EU TX: 144-146 MHz / 430-440 MHz // 4 = US TX: 144-148 MHz / 420-450 MHz + // 5-15 = Unknown } settings2; #seekto 0x1940; @@ -878,6 +881,14 @@ advanced.append(rset) options = ['Unlocked', 'Unknown 1', 'Unknown 2', 'EU', 'US'] + # extend option list with unknown description for values 5 - 15. + for ix in range(len(options), _settings2.region + 1): + item_to_add = 'Unknown {region_code}'.format(region_code=ix) + options.append(item_to_add) + # log unknown region codes greater than 4 + if _settings2.region > 4: + LOG.debug("Unknown region code: {value}". + format(value=_settings2.region)) rx = RadioSettingValueList(options, options[_settings2.region]) rx.set_mutable(False) rset = RadioSetting("settings2.region", "Region", rx)

1 0

[chirp_devel] Dan comments: needs a bug reference according to our process.
by Rudolph Gutzerhagen 12 Feb '21

12 Feb '21

Could you please arrange to edit a page in the developer wiki: at page: https://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess at secion: Submitting a patch at text: "You must include an Issue Number (#123 <https://chirp.danplanet.com/issues/123>) somewhere in the commit message to tie each patch to an issue for tracking purposes." somehow re-iterate or hammer home the point that the bug reference has to be actually in the patch itself, in the patch message. Maybe to change 'commit message' to Mercurial commit message in the patch itself'? I'm not sure of the exact wording to use, but consider the following: For those of you familiar with "Thinking, Fast and Slow" I breezed through that section of the developer process and got an understanding based on fast thinking, that we commit patches by a message to the maillist and that message must have the bug reference, and then seeing many such messages in the list with those numbers referenced in the subject line, and perhaps the mail message body, I follow and do the same. Now based on slow thinking, after getting comments about including a bug reference when I did so, and re-reading the instructions, I come to the conclusion that I come from a different planet than dan planet. Yep, so when I check for a definition of 'mercurial commit message' I see dan planet's meaning reinforced, and realize I have understood 'commit message' to refer to the message sent to the maillist. Dan, again, my apologies and thanks for your patience with off-worlders!

2 1

[chirp_devel] Language translation strategy
by Rudolph Gutzerhagen 12 Feb '21

12 Feb '21

Dan, in a recent message: Re: [chirp_devel] #4849, #8415 - Japanese and Chinese translation Bernhard wrote: >> I know we're going away from the old way of providing translations; <...> Can you indicate the strategy that you have decided upon for language translation? Will it affect the coding of strings during development (continue to code as if 'gettext' is used), or just change the backend process during build to use Google or Watson apis to fill in the gaps on missing translated strings? My lazy search on this didn't help me. Thanks.

2 1