[chirp_devel] TS590 broke File->New?
Hi all,
While working with chirp today I noticed something recently broke. File->New gives me this:
IOError: [Errno 2] No such file or directory: 'Untitled.csv'
I bisected this down to Rick's recent TS590 patch:
https://chirp.danplanet.com/projects/chirp/repository/revisions/0d1c22a40797
Specifically, if I de-register the ts590 driver, it works again:
diff -r 0d1c22a40797 chirp/drivers/ts590.py --- a/chirp/drivers/ts590.py Sun Nov 10 10:03:49 2019 -0800 +++ b/chirp/drivers/ts590.py Wed Dec 04 12:30:01 2019 -0800 @@ -562,7 +562,7 @@ return
-@directory.register +#@directory.register class TS590Radio(chirp_common.CloneModeRadio):
I have not done any further debugging. However, if this is really broken like this (File->New is kinda important) then I'm just going to remove the driver from the registry until it is resolved.
Can anyone verify this behavior or show me that it works for them real quick?
--Dan
On Wed, Dec 4, 2019 at 3:33 PM Dan Smith via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
Hi all,
While working with chirp today I noticed something recently broke. File->New gives me this:
IOError: [Errno 2] No such file or directory: 'Untitled.csv'
I bisected this down to Rick's recent TS590 patch:
https://chirp.danplanet.com/projects/chirp/repository/revisions/0d1c22a40797
Specifically, if I de-register the ts590 driver, it works again:
diff -r 0d1c22a40797 chirp/drivers/ts590.py --- a/chirp/drivers/ts590.py Sun Nov 10 10:03:49 2019 -0800 +++ b/chirp/drivers/ts590.py Wed Dec 04 12:30:01 2019 -0800 @@ -562,7 +562,7 @@ return
-@directory.register +#@directory.register class TS590Radio(chirp_common.CloneModeRadio):
I have not done any further debugging. However, if this is really broken like this (File->New is kinda important) then I'm just going to remove the driver from the registry until it is resolved.
Can anyone verify this behavior or show me that it works for them real quick?
--Dan
Dan,
I tested on Linux and Windows. I don't get an error, but no tab is created to allow the CHIRP user to start editing. Definitely broken.
Jim
I tested on Linux and Windows. I don't get an error, but no tab is created to allow the CHIRP user to start editing. Definitely broken.
Okay, you'd need CHIRP_DEBUG=y set to see it probably.
I'll push a patch to unregister, related to this:
https://chirp.danplanet.com/issues/7409
Thanks for the confirmation!
--Dan
open file ok file new, does nothing, no error.
----- Original Message ----- From: "Dan Smith via chirp_devel" chirp_devel@intrepid.danplanet.com To: "chirp-devel" chirp_devel@intrepid.danplanet.com Sent: Wednesday, December 04, 2019 9:24 PM Subject: Re: [chirp_devel] TS590 broke File->New?
I tested on Linux and Windows. I don't get an error, but no tab is created to allow the CHIRP user to start editing. Definitely broken.
Okay, you'd need CHIRP_DEBUG=y set to see it probably.
I'll push a patch to unregister, related to this:
https://chirp.danplanet.com/issues/7409
Thanks for the confirmation!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
When I delete the ts590.py and .pyc from my local workspace the error is gone and File > New works. I will open an issue on this and then I will start with my blank template and gradually add the 590 code segments until I find what breaks it again locally. Will keep you posted on what I find....
On 12/4/2019 1:24 PM, Dan Smith via chirp_devel wrote:
I tested on Linux and Windows. I don't get an error, but no tab is created to allow the CHIRP user to start editing. Definitely broken.
Okay, you'd need CHIRP_DEBUG=y set to see it probably.
I'll push a patch to unregister, related to this:
https://chirp.danplanet.com/issues/7409
Thanks for the confirmation!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
23/11/2019 its not working either :)
----- Original Message ----- From: "Rick DeWitt AA0RD via chirp_devel" chirp_devel@intrepid.danplanet.com To: "Dan Smith via chirp_devel" chirp_devel@intrepid.danplanet.com Sent: Thursday, December 05, 2019 5:19 AM Subject: Re: [chirp_devel] TS590 broke File->New?
When I delete the ts590.py and .pyc from my local workspace the error is gone and File > New works. I will open an issue on this and then I will start with my blank template and gradually add the 590 code segments until I find what breaks it again locally. Will keep you posted on what I find....
On 12/4/2019 1:24 PM, Dan Smith via chirp_devel wrote:
I tested on Linux and Windows. I don't get an error, but no tab is created to allow the CHIRP user to start editing. Definitely broken.
Okay, you'd need CHIRP_DEBUG=y set to see it probably.
I'll push a patch to unregister, related to this:
https://chirp.danplanet.com/issues/7409
Thanks for the confirmation!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
-- Rick DeWitt AA0RD Sequim, Washington, USA 98382 (360) 681-3494
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
new is working in 20191022
----- Original Message ----- From: "Neil B via chirp_devel" chirp_devel@intrepid.danplanet.com To: "Rick DeWitt AA0RD" aa0rd@yahoo.com; chirp_devel@intrepid.danplanet.com Sent: Thursday, December 05, 2019 5:35 AM Subject: Re: [chirp_devel] TS590 broke File->New?
23/11/2019 its not working either :)
----- Original Message ----- From: "Rick DeWitt AA0RD via chirp_devel" chirp_devel@intrepid.danplanet.com To: "Dan Smith via chirp_devel" chirp_devel@intrepid.danplanet.com Sent: Thursday, December 05, 2019 5:19 AM Subject: Re: [chirp_devel] TS590 broke File->New?
When I delete the ts590.py and .pyc from my local workspace the error is gone and File > New works. I will open an issue on this and then I will start with my blank template and gradually add the 590 code segments until I find what breaks it again locally. Will keep you posted on what I find....
On 12/4/2019 1:24 PM, Dan Smith via chirp_devel wrote:
I tested on Linux and Windows. I don't get an error, but no tab is created to allow the CHIRP user to start editing. Definitely broken.
Okay, you'd need CHIRP_DEBUG=y set to see it probably.
I'll push a patch to unregister, related to this:
https://chirp.danplanet.com/issues/7409
Thanks for the confirmation!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
-- Rick DeWitt AA0RD Sequim, Washington, USA 98382 (360) 681-3494
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
participants (4)
-
Dan Smith -
Jim Unroe -
Neil B -
Rick DeWitt AA0RD