[chirp_devel] [PATCH 0 of 1] Fix #3743
Hi all,
The following trivial patch removes a spurious newline in the NOAA Weather stations stock config. It fixes issue #3743 (Error when importing NOAA stock config). Please review carefully, as this is my first look into the CHIRP codebase.
Dave
# HG changeset patch # User Dave Allan danplanet@dpallan.com # Date 1472488103 14400 # Mon Aug 29 12:28:23 2016 -0400 # Node ID a28365eeb3561d09d333342fa978679165e5b40e # Parent 3e366aeabfb583ef55ba5830e49cc8be9e5bfa23 Remove spurious newline causing stock config import error. Fixes #3743
diff -r 3e366aeabfb5 -r a28365eeb356 stock_configs/NOAA Weather Alert.csv --- a/stock_configs/NOAA Weather Alert.csv Sun Aug 28 15:15:30 2016 -0700 +++ b/stock_configs/NOAA Weather Alert.csv Mon Aug 29 12:28:23 2016 -0400 @@ -1,4 +1,4 @@ -Location,Name,Frequency,Duplex,Offset,Tone,rToneFreq,cToneFreq,DtcsCode,DtcsPolarity,Mode,TStep,Skip,Comment,URCALL,RPT1CALL,RPT2CALL +Location,Name,Frequency,Duplex,Offset,Tone,rToneFreq,cToneFreq,DtcsCode,DtcsPolarity,Mode,TStep,Skip,Comment,URCALL,RPT1CALL,RPT2CALL 1,WX1PA7,162.550000,,0.000000,,88.5,88.5,023,NN,FM,5.00,,,,, 2,WX2PA1,162.400000,,0.000000,,88.5,88.5,023,NN,FM,5.00,,,,, 3,WX3PA4,162.475000,,0.000000,,88.5,88.5,023,NN,FM,5.00,,,,,
Hi Dave,
# HG changeset patch # User Dave Allan danplanet@dpallan.com # Date 1472488103 14400 # Mon Aug 29 12:28:23 2016 -0400 # Node ID a28365eeb3561d09d333342fa978679165e5b40e # Parent 3e366aeabfb583ef55ba5830e49cc8be9e5bfa23 Remove spurious newline causing stock config import error. Fixes #3743
Thanks for this. It's actually an extra CR character (0x0d) that is in there, and the patch process seemed to strip it out anyway. I fixed it and committed the change with your original message and authorship. Just FYI in case you notice the hash is actually different :)
Thanks!
--Dan
participants (2)
-
Dan Smith -
Dave Allan