[chirp_devel] [PATCH 0 of 1 ] Bug 937 Fix (FT-857D crashes) - second try
This is the second try to fix the (radio) bug that have been discovered by Robert. Again I suggest we wait for him to confirm this really solve the problem before to commit.
73 de IZ3GME Marco
# HG changeset patch # User Marco Filippi iz3gme.marco@gmail.com # Date 1372258225 -7200 # Node ID 7f70ba4a94d38bb52627915c50c006fc0336ea33 # Parent 598c397d39c0ab9366256a4fef6ef9e7d426ec50 [ft8x7] pad labels with blanks the bug seems to be limited to a few production lot of ft857d but padding is safe for all radios in ft8x7 family and it can avoid future problems Fix #937
diff --git a/chirp/ft817.py b/chirp/ft817.py --- a/chirp/ft817.py +++ b/chirp/ft817.py @@ -687,12 +687,11 @@ _mem.rit = 0 # not supported in chirp _mem.freq = mem.freq / 10 _mem.offset = mem.offset / 10 - for i in range(0, min(len(mem.name.rstrip()),8)): - _mem.name[i] = ord(mem.name[i]) - # rfill with 0xff to mimic radio - # "quick&dirty" use of i from previous cicle - for i in range(i+1,8): - _mem.name[i] = 0xff + # there are ft857D that have problems with short labels, see bug #937 + # some of the radio fill with 0xff and some with blanks + # the latter is safe for all ft8x7 radio so why should i do it only for some? + for i in range(0, 8): + _mem.name[i] = self.CHARSET.index(mem.name.ljust(8)[i])
for setting in mem.extra: setattr(_mem, setting.get_name(), setting.value)
On 26/06/2013 16:52, Marco Filippi IZ3GME wrote:
This is the second try to fix the (radio) bug that have been discovered by Robert. Again I suggest we wait for him to confirm this really solve the problem before to commit.
73 de IZ3GME Marco
Ok .... shit happens ... please forget this patch. I'm going to send the third (and good) one.
Sorry ...
73 de IZ3GME Marco
participants (2)
-
IZ3GME Marco
-
Marco Filippi IZ3GME