[chirp_users] [CHIRP] #115: duplex setting getting automatically overwritten when frequency gets focus.
#115: duplex setting getting automatically overwritten when frequency gets focus. -------------------------------+-------------------------------------------- Reporter: rct+chirp@… | Type: Bug Status: new | Priority: Stability Milestone: | Component: Memory Editor Version: (tip) | Keywords: Platform: Linux | -------------------------------+-------------------------------------------- If the frequency field gets focus, the duplex setting gets overwritten with the band plan duplex for that frequency, even if the frequency doesn't change.
I first noticed this with 6 meter frequencies. they would loose their duplex setting if the frequency field gets focus. Note: the frequency actually hasn't changed, I just double clicked on it. There are no STD_6M_OFFSETS defined so the duplex settings all got changed to none.
On a 2M frequency that had an offset that doesn't match the standard offsets, touching the frequency would cause the duplex setting to be silently changed.
To reproduce: 1. Enter a 6m frequency, 52.500, + offset by 0.500 2. Double click the frequency, observer the + duplex has changed to none.
Alternatively. 1. Enter 147.375, notice that + and .600 get set automatically. 2. Change to - shift. 3. Double click on 147.375 so it gets & looses focus, note the shift (duplex0 has changed back to +.
First if the frequency doesn't actually get changed, no other automatic changes should be applied.
Second, I think automatically setting the shift/direction should only occur the first time the frequency is set. Subsequent changes to the frequency shouldn't cause automatic defaults to be applied.
Aren't the current set of standard 2m/70cm offsets somewhat US specific?
#115: duplex setting getting automatically overwritten when frequency gets focus. --------------------------------+------------------------------------------- Reporter: rct+chirp@… | Owner: kk7ds Type: Bug | Status: accepted Priority: Stability | Milestone: Component: Memory Editor | Version: (tip) Resolution: | Keywords: Platform: Linux | --------------------------------+------------------------------------------- Changes (by kk7ds):
* owner: => kk7ds * status: new => accepted
Comment:
Well, I understand why the current behavior is not quite right. However, I'm not sure that making it only auto-select the duplex on the first edit is what we want. I think users will be confused if they change a 2m frequency to a 70cm one and don't notice (until in the field) that their offset is wrong. Certainly resetting the duplex and offset if the field is entered but not changed is not the right behavior.
One possible change is making the trigger be when the entered frequency's band changes? In other words, you would get an automatic duplex/offset setting if you changed from 0.00 to 146.90, from 146.90 to 443.10, but not from 146.90 to 147.32. The problem here, however, is going from 146.52 to 146.9000 does not properly enable duplex mode.
Perhaps an alternative would be to only change the duplex/offset if the frequency changes from one automatic range to another. So, if you went from 146.52 to 147.90, the range went from simplex to (-), so we auto-set the duplex. We could also make it so that it only does this if your duplex/offset was default on the old frequency. So, if you had 146.52+1.0 and change the frequency to 146.90, it wouldn't auto-set the duplex/offset because you had something non-standard in there. Does that sound reasonable?
Regarding the US ranges, yes, of course the ones in there now are for the US. Nobody has complained thus far and I'm happy to work out a solution for other countries if someone will offer up the schemes. Alternatively, I could make the automatic-ness be a toggle so that people can turn off that behavior if it's not right for them, or otherwise undesirable.
#115: duplex setting getting automatically overwritten when frequency gets focus. --------------------------------+------------------------------------------- Reporter: rct+chirp@… | Owner: kk7ds Type: Bug | Status: accepted Priority: Stability | Milestone: Component: Memory Editor | Version: (tip) Resolution: | Keywords: Platform: Linux | --------------------------------+-------------------------------------------
Comment (by Robert Terzi <rct+chirp@…>):
First, here's the easy stuff to agree on I think:
* If the frequency doesn't change, no auto updates should occur. Right now, at least under linux, a double-click on the frequency column triggers an automatic update. Note, after a double-click the cell is *not* left in edit mode, you don't even really see it go into edit mode and back out, which is why it's sort of insidious.
* There should be no automatic updates if the frequency isn't contained one of the auto ranges. I might not even have noticed this if I hadn't been touching the block of 6 meter repeaters on my VX-8 or if the 6 meter default shifts were defined. Personally I think no automatic update when out of range vs. forcing simplex is the right behavior.
* There should be a way to turn the automatic updates on/off.
If we agree on the above, the fine tuning of the automatic shift settings that you are describing probably aren't necessary.
#115: duplex setting getting automatically overwritten when frequency gets focus. --------------------------------+------------------------------------------- Reporter: rct+chirp@… | Owner: kk7ds Type: Bug | Status: accepted Priority: Stability | Milestone: Component: Memory Editor | Version: (tip) Resolution: | Keywords: Platform: Linux | --------------------------------+-------------------------------------------
Comment (by Robert Terzi <rct+chirp@…>):
Also this applies to 1.25 meters as well. Currently if you touch any of those frequencies it will be changed to simplex.
#115: duplex setting getting automatically overwritten when frequency gets focus. --------------------------------+------------------------------------------- Reporter: rct+chirp@… | Owner: kk7ds Type: Bug | Status: accepted Priority: Stability | Milestone: Component: Memory Editor | Version: (tip) Resolution: | Keywords: Platform: Linux | --------------------------------+-------------------------------------------
Comment (by Robert Terzi <rct+chirp@…>):
Another test case to consider when testing any fix, if I double-click on a memory that isn't covered by one of the existing ranges (like 1.25 m or 6m) duplex field, it will retain it's value (-/+) however the offset will be zeroed out.
#115: duplex setting getting automatically overwritten when frequency gets focus. --------------------------------+------------------------------------------- Reporter: rct+chirp@… | Owner: kk7ds Type: Bug | Status: closed Priority: Stability | Milestone: Component: Memory Editor | Version: (tip) Resolution: Fixed | Keywords: Platform: Linux | --------------------------------+------------------------------------------- Changes (by kk7ds):
* status: accepted => closed * resolution: => Fixed
Comment:
Fixed in changeset:1007 and changeset:1008
participants (1)
-
CHIRP Tracker