[chirp_devel] Dialog quirks on Linux(es)
I'm seeing some differences in how the Edit Memory dialog is displayed on different platforms. Since I'm not in a position to isolate the source, I thought perhaps others could chime in with what they see.
On MacOS / Python 3.7.0 / wxPython 4.2.0, the dialog looks good.
On Xubuntu 18.04 / Python 3.7.5 / wxPython 4.1.1, the left column is not wide enough for the labels, and the dialog is too _short_, so that it needs to be scrolled to see the last few entries. (The dialog is not resizable, but it shouldn't need to be.)
On Linux Mint 20.04 / Python 3.8.10 / wxPython 4.2.0, the left column is not wide enough for the labels (as with Xubuntu, above), and the dialog is too _tall_, with quite a bit of whitespace below the entries.
The issue with the label column being too narrow seems like FitColumns just not working on Linux. The height issue could be a difference between wxPython versions - or something else.
Any other data points, or perhaps thoughts on how to fix the rendering?
Martin. KD6YAM
Also, the triple-quoted instructions pop-ups have lost all newline formatting (Windows anyway). The entire string is now displayed as if on one line.
On 12/15/2022 9:42 AM, Martin Cooper via chirp_devel wrote:
I'm seeing some differences in how the Edit Memory dialog is displayed on different platforms. Since I'm not in a position to isolate the source, I thought perhaps others could chime in with what they see.
On MacOS / Python 3.7.0 / wxPython 4.2.0, the dialog looks good.
On Xubuntu 18.04 / Python 3.7.5 / wxPython 4.1.1, the left column is not wide enough for the labels, and the dialog is too _short_, so that it needs to be scrolled to see the last few entries. (The dialog is not resizable, but it shouldn't need to be.)
On Linux Mint 20.04 / Python 3.8.10 / wxPython 4.2.0, the left column is not wide enough for the labels (as with Xubuntu, above), and the dialog is too _tall_, with quite a bit of whitespace below the entries.
The issue with the label column being too narrow seems like FitColumns just not working on Linux. The height issue could be a difference between wxPython versions - or something else.
Any other data points, or perhaps thoughts on how to fix the rendering?
Martin. KD6YAM
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs:http://chirp.danplanet.com/projects/chirp/wiki/Developers
Also, the triple-quoted instructions pop-ups have lost all newline formatting (Windows anyway). The entire string is now displayed as if on one line.
Yeah, I know about this. Unfortunately some of the drivers have also embedded the GTKism of honoring a few html-like markup tags in their instructions, which I think we need to avoid in general. If you want to open a bug against py3 in the tracker, I'll take a look at this, I keep forgetting to do it.
Thanks!
--Dan
It appears that at least on ubuntu 22.04 python 3.10.6 wxpython 4.0.7 (standard install for 22.04) wx breaks accessibility. I can get to the menu and open an image but after that I can't see the memories or settings etc. Still looking at this to try to get more informatioh in my spare time.
Tom
On Thu, 15 Dec 2022, Dan Smith via chirp_devel wrote:
Also, the triple-quoted instructions pop-ups have lost all newline formatting (Windows anyway). The entire string is now displayed as if on one line.
Yeah, I know about this. Unfortunately some of the drivers have also embedded the GTKism of honoring a few html-like markup tags in their instructions, which I think we need to avoid in general. If you want to open a bug against py3 in the tracker, I'll take a look at this, I keep forgetting to do it.
Thanks!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
It appears that at least on ubuntu 22.04 python 3.10.6 wxpython 4.0.7 (standard install for 22.04) wx breaks accessibility. I can get to the menu and open an image but after that I can't see the memories or settings etc. Still looking at this to try to get more informatioh in my spare time.
What do you mean "breaks accessibility"? Are you talking about something like a screen reader or other assistive technology?
--Dan
Sorry yes I mean a screen reader as that is how I use chirp.
Tom
On Thu, 15 Dec 2022, Dan Smith via chirp_devel wrote:
It appears that at least on ubuntu 22.04 python 3.10.6 wxpython 4.0.7 (standard install for 22.04) wx breaks accessibility. I can get to the menu and open an image but after that I can't see the memories or settings etc. Still looking at this to try to get more informatioh in my spare time.
What do you mean "breaks accessibility"? Are you talking about something like a screen reader or other assistive technology?
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
Also, the triple-quoted instructions pop-ups have lost all newline formatting (Windows anyway). The entire string is now displayed as if on one line.
Yeah, I know about this. Unfortunately some of the drivers have also embedded the GTKism of honoring a few html-like markup tags in their instructions, which I think we need to avoid in general. If you want to open a bug against py3 in the tracker, I'll take a look at this, I keep forgetting to do it.
Well, Rick, looks like I didn't try very hard... Luckily, wx supports the same sort of markup if I just tell it to. If you're in a position to try this on windows and with whatever radios you noticed it on, that would be cool:
https://github.com/kk7ds/chirp/pull/255
If not, I can just put it in as I think it's what we want. I tried with the Yaesu VX-7 driver which has a multi-line list of instructions with bold markup and it works well:
--Dan
I'm seeing some differences in how the Edit Memory dialog is displayed on different platforms. Since I'm not in a position to isolate the source, I thought perhaps others could chime in with what they see.
On MacOS / Python 3.7.0 / wxPython 4.2.0, the dialog looks good.
On Xubuntu 18.04 / Python 3.7.5 / wxPython 4.1.1, the left column is not wide enough for the labels, and the dialog is too _short_, so that it needs to be scrolled to see the last few entries. (The dialog is not resizable, but it shouldn't need to be.)
On Linux Mint 20.04 / Python 3.8.10 / wxPython 4.2.0, the left column is not wide enough for the labels (as with Xubuntu, above), and the dialog is too _tall_, with quite a bit of whitespace below the entries.
The issue with the label column being too narrow seems like FitColumns just not working on Linux. The height issue could be a difference between wxPython versions - or something else.
Any other data points, or perhaps thoughts on how to fix the rendering?
Can you tell me the git hash of what you're testing? I just made some changes to this yesterday (and broke something in the process, the fix for which is in the queue).
Also, can you show screenshots? It sounds like the two linuxes are opposite of each other, which I wouldn't expect to be the case, but pictures might help.
--Dan
Can you tell me the git hash of what you're testing? I just made some
changes to this yesterday (and broke something in the process, the fix for which is in the queue).
I've just pulled, and re-tested. Whatever you changed yesterday has made both Linuxes the same now, which is good. The column sizing issue is fixed, and that was the bigger issue. The dialog is too tall in both cases now, though that's better than too short, IMHO.
Also, can you show screenshots? It sounds like the two linuxes are opposite
of each other, which I wouldn't expect to be the case, but pictures might help.
Screenshots from both Linuxes below.
Linux Mint 20.04 / Python 3.8.10 / wxPython 4.2.0:
[image: Mint_20.04_Python_3.8.10_wxPython_4.2.0.png] Xubuntu 18.04 / Python 3.7.5 / wxPython 4.1.1
[image: Xubuntu_18.04_Python_3.7.5_wxPython_4.1.1.png]
Martin. KD6YAM
--Dan
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
I've just pulled, and re-tested. Whatever you changed yesterday has made both Linuxes the same now, which is good. The column sizing issue is fixed, and that was the bigger issue. The dialog is too tall in both cases now, though that's better than too short, IMHO.
Excellent, glad to hear it. I'm not exactly sure what to do with the too tall issue. Perhaps I should set a shorter min height and let the dialog scrunch itself to fit. If you want to test some options I can post some stuff. There were several dialogs in the legacy UI that were too small and scrunched to look right, which I always hated, and which GTK made kinda difficult. Most of the stuff I have in the new UI looks a lot better I think, but I agree this one being square is kinda weird.
The change yesterday moved FitColumns to after the initial render so that GTK had a chance to measure the minimum necessary width before fitting. On macos, Cocoa seems to always know the size of things right away, and GTK never does. Windows usually does, but not always.
Screenshots from both Linuxes below.
Excellent, thanks, these match what I'm seeing (post yesterday's fixes) on both of the linuxes I'm testing on.
--Dan
participants (4)
-
Dan Smith -
Martin Cooper -
Rick DeWitt -
Tom Masterson