[chirp_devel] Quick Multi-bank editor
Hi all,
Attached is a quick patch hacked up on the plane. With Jon's vx8 patch, it loads bank names and (should load) bank membership of the first ten memories. I don't actually have a VX-8 image with memories in banks with me, and I forgot my friggin programming cable.
Anyway, it lets you select membership information, but just echos a message to the console about "set x in y" right now. There's a lot of work to be done on this to make it not reload all the memories from the radio a second time (in addition to the normal editor) and to synchronize changes from the other tab.
It's just a start, but should provide something to play with. I look forward to a patch that can set the bank membership on the VX-8 so I can wire up the rest :)
Here's one.
Thanks.
I don't have time to look at why at the moment, but it appears to be misinterpreting the bank names in a rather severe way. From my basically empty image, I see the default "BANK1", "BANK2" names, so I figured it was working properly.
I'll take a look later, or maybe Jon has an idea.
On 05/19/2011 10:55 PM, Dan Smith wrote:
Here's one.
Thanks.
I don't have time to look at why at the moment, but it appears to be misinterpreting the bank names in a rather severe way. From my basically empty image, I see the default "BANK1", "BANK2" names, so I figured it was working properly.
I'll take a look later, or maybe Jon has an idea.
The names from Robert's image look fine here. However, the members don't show up in the grid. The cb in refresh_membership does get called with the correct list of members.
Jon LA4RT
I'll take a look later, or maybe Jon has an idea.
Ah, he was embedding the channels in the bank names temporarily. Also a bug in my patch. The attached on top of it all seems to work for me, although I don't know what banks are what in your image. Seems like they're all in all banks or no banks, which I'm sure isn't right.
The first patch applies fine but the bankfixes.patch doesn't apply to a uptodate hg... is this stuff on a branch?
I can't even find the context bits of vx8.py referenced in the patch.
Grant.
On Fri, May 20, 2011 at 7:43 AM, Dan Smith dsmith@danplanet.com wrote:
I'll take a look later, or maybe Jon has an idea.
Ah, he was embedding the channels in the bank names temporarily. Also a bug in my patch. The attached on top of it all seems to work for me, although I don't know what banks are what in your image. Seems like they're all in all banks or no banks, which I'm sure isn't right.
-- Dan Smith www.danplanet.com KK7DS
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
ok so I've got 4 patches vx8-banks.diff, vx8.diff and the two from this thread quickmultibank and bankfixes.patch
applying the first two to current hg jon's first patch applies fine. then the second patch fails on two hunks
pulling from http://d-rats.com/hg/chirp.hg searching for changes no changes found nevyn@cetacea:~/repos/chirp.hg$ hg stat nevyn@cetacea:~/repos/chirp.hg$ patch -p1 < ~/Downloads/vx-banks.diff patching file chirp/vx3.py patching file chirp/vx6.py patching file chirp/vx8.py nevyn@cetacea:~/repos/chirp.hg$ patch -p1 < ~/Downloads/vx8.diff patching file chirp/vx8.py Hunk #1 FAILED at 19. Hunk #2 succeeded at 90 (offset 6 lines). Hunk #3 FAILED at 175. 2 out of 3 hunks FAILED -- saving rejects to file chirp/vx8.py.rej nevyn@cetacea:~/repos/chirp.hg$ patch -p1 < ~/Downloads/quick_multibank.patch patching file chirpui/editorset.py patching file chirpui/membankedit.py nevyn@cetacea:~/repos/chirp.hg$ patch -p1 < ~/Downloads/bankfixes.patch patching file chirp/vx8.py Reversed (or previously applied) patch detected! Assume -R? [n] n Apply anyway? [n] n Skipping patch. 2 out of 2 hunks ignored -- saving rejects to file chirp/vx8.py.rej patching file chirpui/membankedit.py
So what am I missing/doing wrong would it be possible for someone to create a consolidated patch against hg current and post it?
Grant.
On Sat, May 21, 2011 at 9:27 PM, Dan Smith dsmith@danplanet.com wrote:
I can't even find the context bits of vx8.py referenced in the patch.
Sorry, I should have said, both of those patches were supposed to be applied on top of Jon's vx8diff patch from 17-May.
-- Dan Smith www.danplanet.com KK7DS _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
ok worked it out shouldn't apply vx-banks.diff
then everything's good.
On Sat, May 21, 2011 at 10:18 PM, Grant Diffey gdiffey@gmail.com wrote:
ok so I've got 4 patches vx8-banks.diff, vx8.diff and the two from this thread quickmultibank and bankfixes.patch
applying the first two to current hg jon's first patch applies fine. then the second patch fails on two hunks
pulling from http://d-rats.com/hg/chirp.hg searching for changes no changes found nevyn@cetacea:~/repos/chirp.hg$ hg stat nevyn@cetacea:~/repos/chirp.hg$ patch -p1 < ~/Downloads/vx-banks.diff patching file chirp/vx3.py patching file chirp/vx6.py patching file chirp/vx8.py nevyn@cetacea:~/repos/chirp.hg$ patch -p1 < ~/Downloads/vx8.diff patching file chirp/vx8.py Hunk #1 FAILED at 19. Hunk #2 succeeded at 90 (offset 6 lines). Hunk #3 FAILED at 175. 2 out of 3 hunks FAILED -- saving rejects to file chirp/vx8.py.rej nevyn@cetacea:~/repos/chirp.hg$ patch -p1 < ~/Downloads/quick_multibank.patch patching file chirpui/editorset.py patching file chirpui/membankedit.py nevyn@cetacea:~/repos/chirp.hg$ patch -p1 < ~/Downloads/bankfixes.patch patching file chirp/vx8.py Reversed (or previously applied) patch detected! Assume -R? [n] n Apply anyway? [n] n Skipping patch. 2 out of 2 hunks ignored -- saving rejects to file chirp/vx8.py.rej patching file chirpui/membankedit.py
So what am I missing/doing wrong would it be possible for someone to create a consolidated patch against hg current and post it?
Grant.
On Sat, May 21, 2011 at 9:27 PM, Dan Smith dsmith@danplanet.com wrote:
I can't even find the context bits of vx8.py referenced in the patch.
Sorry, I should have said, both of those patches were supposed to be applied on top of Jon's vx8diff patch from 17-May.
-- Dan Smith www.danplanet.com KK7DS _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
On 05/24/2011 12:21 AM, Dan Smith wrote:
def make_cb(i): def cb(members): self._bank_members[i] = members return cbCan you explain this change?
'i' was always the number of the last bank when cb was called. Looks like 'cb' got redefined with a new 'i' for each iteration.
Regards
Jon LA4RT
On 05/24/2011 07:56 AM, Jon Kåre Hellan wrote:
On 05/24/2011 12:21 AM, Dan Smith wrote:
def make_cb(i): def cb(members): self._bank_members[i] = members return cb
Can you explain this change?
'i' was always the number of the last bank when cb was called. Looks like 'cb' got redefined with a new 'i' for each iteration.
i.e. all the threads which use 'cb' executed *after* the last iteration, and used the definition of 'i' which corresponds to the last bank.
Regards
Jon LA4RT
Sorry for the delay in replying...
i.e. all the threads which use 'cb' executed *after* the last iteration, and used the definition of 'i' which corresponds to the last bank.
Okay, well, I'd like to solve that a bit differently, but I see what you mean.
So, I've been consumed trying to clean up some other things recently. Where are we on the bank stuff?
On 05/27/2011 04:52 PM, Dan Smith wrote:
Sorry for the delay in replying...
i.e. all the threads which use 'cb' executed *after* the last iteration, and used the definition of 'i' which corresponds to the last bank.
Okay, well, I'd like to solve that a bit differently, but I see what you mean.
So, I've been consumed trying to clean up some other things recently. Where are we on the bank stuff?
We know the layout for the VX-6 and VX-8, both bank names and bank membership. For the VX-3, we know where the names are, but not the members. For the FT-7800, we know the memory layout for bank membership, names can't be changed.
We've got code to read all of this. I think I've sent you all of it, but I'm attaching a refreshed patch.
Regards
Jon LA4RT
participants (4)
-
Dan Smith -
Grant Diffey -
Jon Kåre Hellan -
Robert Terzi