[chirp_devel] Patch for #5679
Hope I did this correctly. As an Orca user, I noticed that while radio settings were individually labeled, the labels weren't associated with the widgets so they're presented accessibly. Had to use a couple methods to achieve this, since for some reason Orca can't just use the accessible name everywhere.
Thanks.
Hi Nolan,
The patch looks okay, although I haven't tested it personally, and want to make sure it doesn't have any adverse effects for the visuals either. But, just to be sure, it works for you and makes Orca do what you need, right?
If so, I'll apply this after I get a chance to test it.
Thanks!
--Dan
On Mar 29, 2018, at 1:51 PM, Nolan Darilek via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
Hope I did this correctly. As an Orca user, I noticed that while radio settings were individually labeled, the labels weren't associated with the widgets so they're presented accessibly. Had to use a couple methods to achieve this, since for some reason Orca can't just use the accessible name everywhere.
Thanks.
<5679.patch>_______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
Yup, works fine. I haven't gone through every single setting, and I only have a GT-3, but it definitely fixes presentation of those controls. I can't speak for every settings widget, but it should work for any that descend from the common GTK widgets.
On 03/29/2018 09:48 PM, Dan Smith via chirp_devel wrote:
Hi Nolan,
The patch looks okay, although I haven't tested it personally, and want to make sure it doesn't have any adverse effects for the visuals either. But, just to be sure, it works for you and makes Orca do what you need, right?
If so, I'll apply this after I get a chance to test it.
Thanks!
--Dan
On Mar 29, 2018, at 1:51 PM, Nolan Darilek via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
Hope I did this correctly. As an Orca user, I noticed that while radio settings were individually labeled, the labels weren't associated with the widgets so they're presented accessibly. Had to use a couple methods to achieve this, since for some reason Orca can't just use the accessible name everywhere.
Thanks.
<5679.patch>_______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
Hi Nolan,
Looks okay to me, I've applied it for tomorrow's build. I won't be around to do this myself, but if you verify that it works in the build tomorrow, you might send an email to the users list highlighting that this got added.
Thanks!
--Dan
On Mar 29, 2018, at 8:28 PM, Nolan Darilek via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
Yup, works fine. I haven't gone through every single setting, and I only have a GT-3, but it definitely fixes presentation of those controls. I can't speak for every settings widget, but it should work for any that descend from the common GTK widgets.
On 03/29/2018 09:48 PM, Dan Smith via chirp_devel wrote:
Hi Nolan,
The patch looks okay, although I haven't tested it personally, and want to make sure it doesn't have any adverse effects for the visuals either. But, just to be sure, it works for you and makes Orca do what you need, right?
If so, I'll apply this after I get a chance to test it.
Thanks!
--Dan
On Mar 29, 2018, at 1:51 PM, Nolan Darilek via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
Hope I did this correctly. As an Orca user, I noticed that while radio settings were individually labeled, the labels weren't associated with the widgets so they're presented accessibly. Had to use a couple methods to achieve this, since for some reason Orca can't just use the accessible name everywhere.
Thanks.
<5679.patch>_______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
Thanks, will do. I may not be around tomorrow either, but I'll send something as soon as I can.
On 03/30/2018 09:52 AM, Dan Smith via chirp_devel wrote:
Hi Nolan,
Looks okay to me, I've applied it for tomorrow's build. I won't be around to do this myself, but if you verify that it works in the build tomorrow, you might send an email to the users list highlighting that this got added.
Thanks!
--Dan
On Mar 29, 2018, at 8:28 PM, Nolan Darilek via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
Yup, works fine. I haven't gone through every single setting, and I only have a GT-3, but it definitely fixes presentation of those controls. I can't speak for every settings widget, but it should work for any that descend from the common GTK widgets.
On 03/29/2018 09:48 PM, Dan Smith via chirp_devel wrote:
Hi Nolan,
The patch looks okay, although I haven't tested it personally, and want to make sure it doesn't have any adverse effects for the visuals either. But, just to be sure, it works for you and makes Orca do what you need, right?
If so, I'll apply this after I get a chance to test it.
Thanks!
--Dan
On Mar 29, 2018, at 1:51 PM, Nolan Darilek via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
Hope I did this correctly. As an Orca user, I noticed that while radio settings were individually labeled, the labels weren't associated with the widgets so they're presented accessibly. Had to use a couple methods to achieve this, since for some reason Orca can't just use the accessible name everywhere.
Thanks.
<5679.patch>_______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
participants (2)
-
Dan Smith
-
Nolan Darilek