[chirp_devel] Kenwood TM-D710/G Clone Mode Driver
Re-submitted. I may have missed a response from an earlier submission...
Hi Rick,
Re-submitted. I may have missed a response from an earlier submission...
No, you didn't miss anything. I'm still having a hard time getting happy with the download process that you've got and using that and other distractions as reasons to procrastinate. That's my bad, not yours.
However, I'm going to just trust your assertion that at least it currently mirrors the MCP file (minus headers), so thanks for doing that. I've gone ahead and merged this, although I did have to fix a style issue that caused that check to fail.
One thing I think we need to change, is the way you've defined the subclasses inside the "if futures" thing, which just squeezes them because they're all indented another level. All we need to do is add another level there I think and avoid having to do indent the whole class. I think this also fails python3 now worse than before, just from looking at it, so we probably need to do some fixup to that as well. Anyway, I'll try to queue that up at some point.
--Dan
participants (2)
-
Dan Smith
-
Rick (AA0RD) DeWitt