[chirp_devel] [PATCH] [py2 default branch] Stock config-files handling #6079
tested in windows and linux.
stock-config-files-handling #6079 o stock-config files handling on program load to preserve any user changes to config files (move to archive directory) and allow copy in of freshest version of shipped stock config files. o enhance stock-config menu to handle access to archive directories. - also extended to the 'radio/import from stock config' menu.
Additional note on stock configuration files: In order to prevent overwriting user-copy stock config files with shipped versions, CHIRP skips the copy of those files which already exist in the user-copy directory, leaving any new data in shipped versions in the shipped stock config directory. This function examines each pair (shipped vs user copy) and if different, moves the user-copy stock config to an archive directory, thereby permitting CHIRP to copy the newer shipped version to the user-copy directory. This new archive retains any user-modified data.
# HG changeset patch # User Rudolph Gutzerhagen rudolph.gutzerhagen@gmail.com # Date 1611481781 18000 # Sun Jan 24 04:49:41 2021 -0500 # Node ID cf925f4379458bd3f4750faf19ce22123b4e865c # Parent c0a9082a09259db344e5aa7eff824c37cc61e312 [mq]: stock-config-files-handling #6079 o stock-config files handling on program load to preserve any user changes to config files (move to archive directory) and allow copy in of freshest version of shipped stock config files. o enhance stock-config menu to handle access to archive directories. - also extended to the 'radio/import from stock config' menu.
Additional note on stock configuration files: In order to prevent overwriting user-copy stock config files with shipped versions, CHIRP skips the copy of those files which already exist in the user-copy directory, leaving any new data in shipped versions in the shipped stock config directory. This function examines each pair (shipped vs user copy) and if different, moves the user-copy stock config to an archive directory, thereby permitting CHIRP to copy the newer shipped version to the user-copy directory. This new archive retains any user-modified data.
I'm not opposed to this necessarily, but it seems a little overkill (although I . Could we not just rename the existing (but changed) ones to "%(orig)s MODIFIED.csv" or something similar? I'd probably rather a File->Open Stock Dir which just browses them to their stock file location so they can sort out the conflicts. I'll note, however, that my dev machine doesn't run gnome, so I'm not sure there's really a way to do that stably, and it'd need to work for Finder in macos too...
I guess I'd like to hear from some others about whether they like Rudolph's approach here, or would prefer a less complicated one.
In the meantime, this breaks for me, if I try to click on the folder you're adding to the stock menu:
Traceback (most recent call last): File "/danplanet/users/dan/dev/chirp/chirp/ui/mainapp.py", line 737, in <lambda> self.do_open(start_dir=dir_entry), TypeError: do_open() got an unexpected keyword argument 'start_dir'
--Dan
participants (2)
-
Dan Smith -
Rudolph Gutzerhagen