[chirp_devel] [PATCH] Shorten a pydoc line in icf.py to fix tests
# HG changeset patch # User Rhett Robinson rrhett@gmail.com # Date 1515978395 28800 # Sun Jan 14 17:06:35 2018 -0800 # Node ID eda97f883de3cf5909942298b56cce3e0cae91cd # Parent 0ac31753af9e0d92855b94b9adc18ab3835d47a5 Shorten a pydoc line in icf.py to fix tests.
diff -r 0ac31753af9e -r eda97f883de3 chirp/drivers/icf.py --- a/chirp/drivers/icf.py Sun Jan 14 16:11:48 2018 -0800 +++ b/chirp/drivers/icf.py Sun Jan 14 17:06:35 2018 -0800 @@ -605,7 +605,7 @@ return data
def get_payload(self, data, checksum): - """Returns the data with optional checksum BCD-encoded for the radio.""" + """Returns the data with optional checksum BCD-encoded for the radio""" payload = "" for byte in data: payload += "%02X" % ord(byte)
# HG changeset patch # User Rhett Robinson rrhett@gmail.com # Date 1515978395 28800 # Sun Jan 14 17:06:35 2018 -0800 # Node ID eda97f883de3cf5909942298b56cce3e0cae91cd # Parent 0ac31753af9e0d92855b94b9adc18ab3835d47a5 Shorten a pydoc line in icf.py to fix tests.
I applied this, thanks. Note that the precommit hook requires a bug id, even for trivial patches for this. For super simple ones like this I will often just use "#0" as I did to fix yours just now. For anything other than super trivial stuff like this we usually have a bug, just FYI.
Thanks!
--Dan
Thanks for letting me know, and sorry again for the brief breakage!
Rhett
On Sun, Jan 14, 2018 at 7:14 PM, Dan Smith via chirp_devel < chirp_devel@intrepid.danplanet.com> wrote:
# HG changeset patch # User Rhett Robinson rrhett@gmail.com # Date 1515978395 28800 # Sun Jan 14 17:06:35 2018 -0800 # Node ID eda97f883de3cf5909942298b56cce3e0cae91cd # Parent 0ac31753af9e0d92855b94b9adc18ab3835d47a5 Shorten a pydoc line in icf.py to fix tests.
I applied this, thanks. Note that the precommit hook requires a bug id, even for trivial patches for this. For super simple ones like this I will often just use "#0" as I did to fix yours just now. For anything other than super trivial stuff like this we usually have a bug, just FYI.
Thanks!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
participants (2)
-
Dan Smith -
Rhett Robinson