[chirp_devel] [PATCH] Slight improvement to memory editor container
# HG changeset patch # User K. Arvanitis kosta@alumni.uvic.ca # Date 1420969023 28800 # Sun Jan 11 01:37:03 2015 -0800 # Node ID 310c66295ef033650ae6c4171efbb83f6f425abe # Parent 5c8cf7aa6ab3d12598a3eaabf69ffdc074c4bcd2 [PATCH] Slight improvement to memory editor container
This change simple encapsulates the memory editor scrolling window in an hbox to allow for smooth transition beteween the controls.
Bug #2177
diff -r 5c8cf7aa6ab3 -r 310c66295ef0 chirpui/memedit.py --- a/chirpui/memedit.py Sat Jan 10 15:44:20 2015 -0800 +++ b/chirpui/memedit.py Sun Jan 11 01:37:03 2015 -0800 @@ -929,6 +929,8 @@ self.view.get_selection().set_mode(gtk.SELECTION_MULTIPLE) self.view.set_rules_hint(True)
+ hbox = gtk.HBox() + sw = gtk.ScrolledWindow() sw.set_policy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC) sw.add(self.view) @@ -1004,10 +1006,13 @@
self.view.show() sw.show() + hbox.pack_start(sw, 1, 1, 1)
self.view.connect("button_press_event", self.click_cb)
- return sw + hbox.show() + + return hbox
def col(self, caption): try:
# Node ID 310c66295ef033650ae6c4171efbb83f6f425abe # Parent 5c8cf7aa6ab3d12598a3eaabf69ffdc074c4bcd2 [PATCH] Slight improvement to memory editor container
This change simple encapsulates the memory editor scrolling window in an hbox to allow for smooth transition beteween the controls.
In the future, can you please wrap your commit messages at 79 columns?
sw.show()
hbox.pack_start(sw, 1, 1, 1) self.view.connect("button_press_event", self.click_cb)
return sw
hbox.show()return hbox
I don't understand why this makes anything better (or changes anything at all for that matter).
Can you explain?
--Dan
I attached two screenshots to the bug report (before and after); this does a better job of illustrating the change then I can.
http://chirp.danplanet.com/issues/2177
Its simply an aesthetic fix and does not alter the behaviour in any way.
Date: Thu, 15 Jan 2015 15:47:36 -0800 From: dsmith@danplanet.com To: chirp_devel@intrepid.danplanet.com Subject: Re: [chirp_devel] [PATCH] Slight improvement to memory editor container
# Node ID 310c66295ef033650ae6c4171efbb83f6f425abe # Parent 5c8cf7aa6ab3d12598a3eaabf69ffdc074c4bcd2 [PATCH] Slight improvement to memory editor container
This change simple encapsulates the memory editor scrolling window in an hbox to allow for smooth transition beteween the controls.
In the future, can you please wrap your commit messages at 79 columns?
sw.show()
hbox.pack_start(sw, 1, 1, 1) self.view.connect("button_press_event", self.click_cb)
return sw
hbox.show()return hbox
I don't understand why this makes anything better (or changes anything at all for that matter).
Can you explain?
--Dan
_______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
I attached two screenshots to the bug report (before and after); this does a better job of illustrating the change then I can.
Ah, yeah, I don't see that change on Linux, so it must be something with the win32 renderer.
--Dan
participants (2)
-
Dan Smith -
Kosta Arvanitis