[chirp_devel] Issue #1667 - Support for Wouxun KG-UV8D
Attached is my driver for the Wouxun KG-UV6D.
At present this can Download & Upload all 999 memories to the radio and will display some of the settings (but not upload new values to the radio).
Hi Ron,
Attached is my driver for the Wouxun KG-UV6D.
Has anyone else (Ron, you included) looked at this code and compared it to others to see if it's an obvious clone of something else? It didn't appear to be obvious to me. Jim?
At present this can Download & Upload all 999 memories to the radio and will display some of the settings (but not upload new values to the radio).
Thanks for this! Some comments below:
req = chr(i/256) + chr(i%256) + chr(blocksize)
This is kindof nitish, but can you put spaces around the operators here? There are several occurrences of this (and the comments below) so I'll just point each out once and let you find the rest.
+# +# Configuration Settings +#
This should be indented to the same level as the code it pertains to.
rs = RadioSetting("ponmsg", "Poweron message",RadioSettingValueList(PONMSG_LIST,PONMSG_LIST[self._memobj.settings.ponmsg]))- cfg_grp.append(rs)
rs = RadioSetting("voice", "Voice Guide", RadioSettingValueBoolean(self._memobj.settings.voice))cfg_grp.append(rs)rs = RadioSetting("timeout", "Timeout Timer",RadioSettingValueInteger(15, 900,self._memobj.settings.timeout * 15, 15))cfg_grp.append(rs)- rs = RadioSetting("toalarm", "Timeout Alarm",
RadioSettingValueInteger(0, 10,self._memobj.settings.toalarm))- cfg_grp.append(rs)
- rs = RadioSetting("channel_menu", "Menu available in channel mode",
RadioSettingValueBoolean(self._memobj.settings.channel_menu))- cfg_grp.append(rs)
rs = RadioSetting("power_save", "Power save",RadioSettingValueBoolean(self._memobj.settings.power_save))cfg_grp.append(rs)
Looks like some alignment issues here. Just to be clear, each indent level should be four spaces.
Again, thanks a lot. This looks really close and I'll be glad to get this into the tree soon!
--Dan
On Thu, Sep 25, 2014 at 5:41 PM, Dan Smith dsmith@danplanet.com wrote:
Hi Ron,
Attached is my driver for the Wouxun KG-UV6D.
Has anyone else (Ron, you included) looked at this code and compared it to others to see if it's an obvious clone of something else? It didn't appear to be obvious to me. Jim?
As far as I know it is different. It seems that Wouxun changed how they do thing with their mobile radios and the KG-UV8D.
This it the kind of help that I was looking for to get going with the KG-UV920P mobile radio (and possibly the UV950-P after that).
This should be indented to the same level as the code it pertains to.
rs = RadioSetting("ponmsg", "Poweron message",RadioSettingValueList(PONMSG_LIST,PONMSG_LIST[self._memobj.settings.ponmsg]))cfg_grp.append(rs)rs = RadioSetting("voice", "Voice Guide",RadioSettingValueBoolean(
self._memobj.settings.voice))cfg_grp.append(rs)rs = RadioSetting("timeout", "Timeout Timer",RadioSettingValueInteger(15, 900,self._memobj.settings.timeout * 15, 15))cfg_grp.append(rs)rs = RadioSetting("toalarm", "Timeout Alarm",RadioSettingValueInteger(0, 10,self._memobj.settings.toalarm))cfg_grp.append(rs)rs = RadioSetting("channel_menu", "Menu available in channel mode",RadioSettingValueBoolean(self._memobj.settings.channel_menu))cfg_grp.append(rs)rs = RadioSetting("power_save", "Power save",RadioSettingValueBoolean(self._memobj.settings.power_save))cfg_grp.append(rs)Looks like some alignment issues here. Just to be clear, each indent level should be four spaces.
Yeah. I have to convert tabs to spaces with my editor and everything was indented as it should be. There are a few links longer than 80 characters that should be addressed too.
Again, thanks a lot. This looks really close and I'll be glad to get this into the tree soon!
I was so hoping to get this going to at least attempt a download with my KG-UV920P. Unfortunately, I get this error.
Traceback (most recent call last): File "C:\Users\Root\chirp.hg\chirpui\mainapp.py", line 1391, in mh self.do_download(*args) File "C:\Users\Root\chirp.hg\chirpui\mainapp.py", line 641, in do_download not self._confirm_experimental(rclass): File "C:\Users\Root\chirp.hg\chirpui\mainapp.py", line 599, in _confirm_experi mental can_squelch=True) File "C:\Users\Root\chirp.hg\chirpui\common.py", line 350, in show_warning textview = _add_text(d, text) File "C:\Users\Root\chirp.hg\chirpui\common.py", line 310, in _add_text v.get_buffer().set_text(text) TypeError: GtkTextBuffer.set_text() argument 1 must be string or read-only buffe r, not None
I couldn't find the debug.log file. Doesn't the developer version write the debug.log to the same place as a regular install of CHIRP? Do I not have something enabled?
Jim
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Now I am back and recovered from the National Hamfest in Newark (UK) I can reply & address the issues raised.
On 26/09/14 01:17, Jim Unroe wrote:
On Thu, Sep 25, 2014 at 5:41 PM, Dan Smith <dsmith@danplanet.com mailto:dsmith@danplanet.com> wrote:
Hi Ron,
Attached is my driver for the Wouxun KG-UV6D.
Has anyone else (Ron, you included) looked at this code and compared it to others to see if it's an obvious clone of something else? It didn't appear to be obvious to me. Jim?
As far as I know it is different. It seems that Wouxun changed how they do thing with their mobile radios and the KG-UV8D.
I went through most of the radio interfaces and found a few similar but sufficiently different to prevent code reuse. I initially started trying to include the code in wouxun.py, but soon realised that I was writing new code (or cutting and pasting) but not using anything from the rest of the file.
This it the kind of help that I was looking for to get going with the KG-UV920P mobile radio (and possibly the UV950-P after that).
This should be indented to the same level as the code it pertains to.
rs = RadioSetting("ponmsg", "Poweron message", +RadioSettingValueList( + PONMSG_LIST, +
PONMSG_LIST[self._memobj.settings.ponmsg]))
cfg_grp.append(rs) + rs = RadioSetting("voice","Voice Guide",
RadioSettingValueBoolean(
self._memobj.settings.voice)) +cfg_grp.append(rs) + rs = RadioSetting("timeout", "Timeout Timer", + RadioSettingValueInteger(15, 900, + self._memobj.settings.timeout
- 15, 15)) + cfg_grp.append(rs) + rs =
RadioSetting("toalarm", "Timeout Alarm", + RadioSettingValueInteger(0, 10, + self._memobj.settings.toalarm)) + cfg_grp.append(rs) + rs = RadioSetting("channel_menu", "Menu available in channel
mode",
RadioSettingValueBoolean( +self._memobj.settings.channel_menu)) + cfg_grp.append(rs) + rs = RadioSetting("power_save", "Power save", + RadioSettingValueBoolean( + self._memobj.settings.power_save)) + cfg_grp.append(rs)
Looks like some alignment issues here. Just to be clear, each indent level should be four spaces.
Yeah. I have to convert tabs to spaces with my editor and everything was indented as it should be. There are a few links longer than 80 characters that should be addressed too.
I will get my editor settings sorted out and tidy up the indenting/code.
Again, thanks a lot. This looks really close and I'll be glad to get this into the tree soon!
I was so hoping to get this going to at least attempt a download with my KG-UV920P. Unfortunately, I get this error.
Traceback (most recent call last): File "C:\Users\Root\chirp.hg\chirpui\mainapp.py", line 1391, in mh self.do_download(*args) File "C:\Users\Root\chirp.hg\chirpui\mainapp.py", line 641, in do_download not self._confirm_experimental(rclass): File "C:\Users\Root\chirp.hg\chirpui\mainapp.py", line 599, in _confirm_experi mental can_squelch=True) File "C:\Users\Root\chirp.hg\chirpui\common.py", line 350, in show_warning textview = _add_text(d, text) File "C:\Users\Root\chirp.hg\chirpui\common.py", line 310, in _add_text v.get_buffer().set_text(text) TypeError: GtkTextBuffer.set_text() argument 1 must be string or read-only buffe r, not None
I couldn't find the debug.log file. Doesn't the developer version write the debug.log to the same place as a regular install of CHIRP? Do I not have something enabled?
Jim
- -- Ron Wellsted ron@wellsted.org.uk http://www.wellsted.org.uk Call Sign: M0RNW / Linux Counter No. 202120
Hi,
Please find attached my tidied up module for the Wouxun KG-UV8D.
Hi Ron,
Please find attached my tidied up module for the Wouxun KG-UV8D.
Sorry for the delay in getting to this. I've applied this to the tree for tomorrow. Can you add this to the list on the front page so people know it's supported?
Thanks!
--Dan
On 14/10/14 18:39, Dan Smith wrote:
Hi Ron,
Please find attached my tidied up module for the Wouxun KG-UV8D.
Sorry for the delay in getting to this. I've applied this to the tree for tomorrow. Can you add this to the list on the front page so people know it's supported?
Thanks!
--Dan
Hi Dan, Thanks for that.
I will quite happily add the KG-UV8D to the front page, however I don't seem to have the relevant permissions to do so. It may also be worth assigning issue #1667 to me.
My wiki username is rjwellsted.
TIA
I will quite happily add the KG-UV8D to the front page, however I don't seem to have the relevant permissions to do so. It may also be worth assigning issue #1667 to me.
Done. I'll let you close it.
Also, there is a bug related to the UV8 reported this morning (#1969). A different user also emailed me last night, having tried it from the source tree before the build even went out. I've assigned that one to you as well.
Can you send an image of a UV8 for me to put in the tests directory so that we get some test runs of that driver in the build process?
Thanks!
--Dan
On Wed, Oct 15, 2014 at 9:30 AM, Dan Smith dsmith@danplanet.com wrote:
I will quite happily add the KG-UV8D to the front page, however I don't seem to have the relevant permissions to do so. It may also be worth assigning issue #1667 to me.
Done. I'll let you close it.
Also, there is a bug related to the UV8 reported this morning (#1969). A different user also emailed me last night, having tried it from the source tree before the build even went out. I've assigned that one to you as well.
Can you send an image of a UV8 for me to put in the tests directory so that we get some test runs of that driver in the build process?
Thanks!
--Dan
I continue to get the error that I mentioned a few messages back. I don't have a KG-UV8D but I would think I would at least see CHIRP try to handshake with the radio and it doesn't seem to get that far.
Jim
participants (3)
-
Dan Smith -
Jim Unroe -
Ron Wellsted