[chirp_devel] FT70 Driver - New Model #5329
Hi,
Have attached the latest and previous patches.
I now have enough of the driver working to be useful. Read / write memories, a number of the settings, and import from RepeaterBook work. Saving modes dn,vw and AMS in memory channels, do not currently work. Banks have not been tested - may now work, VFO settings not implemented (etc)
Regards Nicolas
Have attached the latest and previous patches.
With just the original patch applied, I get this while trying to run tests against the factory image you sent previously:
Traceback (most recent call last): File "/danplanet/users/dan/dev/chirp/tests/run_tests.py", line 1244, in <module> failed = tr.run_one(options.driver) File "/danplanet/users/dan/dev/chirp/tests/run_tests.py", line 1176, in run_one "%s.img" % drv_name)) File "/danplanet/users/dan/dev/chirp/tests/run_tests.py", line 1148, in run_rclass_image tw = TestWrapper(rclass, testimage) File "/danplanet/users/dan/dev/chirp/tests/run_tests.py", line 113, in __init__ self.open() File "/danplanet/users/dan/dev/chirp/tests/run_tests.py", line 125, in open self._dst = self._dstclass(self._filename) File "../chirp/chirp_common.py", line 1159, in __init__ self.load_mmap(pipe) File "../chirp/chirp_common.py", line 1128, in load_mmap self.process_mmap() File "../chirp/drivers/ft70.py", line 634, in process_mmap self._memobj = bitwise.parse(mem_format % self._mem_params, self._mmap) File "../chirp/bitwise.py", line 893, in parse return p.parse(ast) File "../chirp/bitwise.py", line 886, in parse self.parse_block(lang) File "../chirp/bitwise.py", line 878, in parse_block self.parse_struct(d) File "../chirp/bitwise.py", line 860, in parse_struct return self.parse_struct_decl(struct[0][1]) File "../chirp/bitwise.py", line 849, in parse_struct_decl self._generators[name] = result File "../chirp/bitwise.py", line 679, in __setitem__ self._generators[key].set_value(value) File "../chirp/bitwise.py", line 160, in set_value raise Exception("Not implemented for %s" % self.__class__) Exception: Not implemented for chirp.bitwise.structDataElement
--Dan
You need the second patch. I am still struggling with Mercurial to - add - one - file.
Another factory image attached, but previous should be fine
On 8 March 2018 at 19:26, Dan Smith via chirp_devel < chirp_devel@intrepid.danplanet.com> wrote:
Have attached the latest and previous patches.
With just the original patch applied, I get this while trying to run tests against the factory image you sent previously:
Traceback (most recent call last): File "/danplanet/users/dan/dev/chirp/tests/run_tests.py", line 1244, in
<module> failed = tr.run_one(options.driver) File "/danplanet/users/dan/dev/chirp/tests/run_tests.py", line 1176, in run_one "%s.img" % drv_name)) File "/danplanet/users/dan/dev/chirp/tests/run_tests.py", line 1148, in run_rclass_image tw = TestWrapper(rclass, testimage) File "/danplanet/users/dan/dev/chirp/tests/run_tests.py", line 113, in __init__ self.open() File "/danplanet/users/dan/dev/chirp/tests/run_tests.py", line 125, in open self._dst = self._dstclass(self._filename) File "../chirp/chirp_common.py", line 1159, in __init__ self.load_mmap(pipe) File "../chirp/chirp_common.py", line 1128, in load_mmap self.process_mmap() File "../chirp/drivers/ft70.py", line 634, in process_mmap self._memobj = bitwise.parse(mem_format % self._mem_params, self._mmap) File "../chirp/bitwise.py", line 893, in parse return p.parse(ast) File "../chirp/bitwise.py", line 886, in parse self.parse_block(lang) File "../chirp/bitwise.py", line 878, in parse_block self.parse_struct(d) File "../chirp/bitwise.py", line 860, in parse_struct return self.parse_struct_decl(struct[0][1]) File "../chirp/bitwise.py", line 849, in parse_struct_decl self._generators[name] = result File "../chirp/bitwise.py", line 679, in __setitem__ self._generators[key].set_value(value) File "../chirp/bitwise.py", line 160, in set_value raise Exception("Not implemented for %s" % self.__class__) Exception: Not implemented for chirp.bitwise.structDataElement
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
You need the second patch. I am still struggling with Mercurial to - add - one - file.
Okay if I apply both, I see that it runs now. The first patch includes apple noise like this:
diff -r a95a7ce22722 -r 8339092e3580 chirp/drivers/.DS_Store Binary file chirp/drivers/.DS_Store has changed
The second one removes the tox.ini file from the tree and includes some just random whitespace damage to the code the first one adds.
Since the first one is untestable, I don't really want to apply it even with the second one behind it. Squashing them together would mean I'm just re-writing the commit message for you and removing the damage to other files in the tree. I try to stick to the process of applying whole patches from people unless they really can't do it themselves.
Can you squash them together and re-send as a unified patch that works? I'll handle getting the image into it before I push.
Thanks!
--Dan
Yes. working on it.
On 8 March 2018 at 20:11, Dan Smith via chirp_devel < chirp_devel@intrepid.danplanet.com> wrote:
You need the second patch. I am still struggling with Mercurial to -
add - one - file.
Okay if I apply both, I see that it runs now. The first patch includes apple noise like this:
diff -r a95a7ce22722 -r 8339092e3580 chirp/drivers/.DS_Store Binary file chirp/drivers/.DS_Store has changed
The second one removes the tox.ini file from the tree and includes some just random whitespace damage to the code the first one adds.
Since the first one is untestable, I don't really want to apply it even with the second one behind it. Squashing them together would mean I'm just re-writing the commit message for you and removing the damage to other files in the tree. I try to stick to the process of applying whole patches from people unless they really can't do it themselves.
Can you squash them together and re-send as a unified patch that works? I'll handle getting the image into it before I push.
Thanks!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
participants (2)
-
Dan Smith
-
Nicolas Pike