[chirp_devel] [ft50] Yaesu FT-50 new Driver info, patch, & image. Fixes #1233.
Hello everyone!
I've gotten enough completed on the FT-50 driver that I thought it was time for a patch. I'd like some eyes on it to make sure I'm not doing something really wrong or going in a bad direction.
I'm no expert on all of the advanced features of the radio, but I've done the best I can to map out the important stuff. If anyone sees something missing just let me know.
Feel free to critique away and send me questions or suggestions. I've been a developer for quite a while, but this is my first python project.
The image I've attached is an empty image. It's what I got from the radio after a master reset and enabling extended reception.
NOTE: the chirp/drivers/ft50_ll.py file is no longer needed and should be removed. I don't know how to include that change in the soft-commit and patch.
Thanks! -mark
Hi Mark,
Sorry for the delayed response.
I've gotten enough completed on the FT-50 driver that I thought it was time for a patch. I'd like some eyes on it to make sure I'm not doing something really wrong or going in a bad direction.
I've had a quick skim and it seems fine to me. If it works, then I'd say we should put it in the tree and see how it goes. Any reservations from you?
NOTE: the chirp/drivers/ft50_ll.py file is no longer needed and should be removed. I don't know how to include that change in the soft-commit and patch.
What you did should be fine.
Thanks!
--Dan
Dan (& group),
Sorry it took me a couple of days to get back to you. I made some minor improvements including fixing a few pep8 issues and improving upload reliability. I think this is now ready to go into the tree.
This new patch completely replaces the first patch. It includes the removal of the ft50_II.py file this time.
Feel free to let me know if there are any issues.
Thanks, -mark
On Sat, Jan 9, 2016 at 8:39 PM, Dan Smith via chirp_devel < chirp_devel@intrepid.danplanet.com> wrote:
Hi Mark,
Sorry for the delayed response.
I've gotten enough completed on the FT-50 driver that I thought it was time for a patch. I'd like some eyes on it to make sure I'm not doing something really wrong or going in a bad direction.
I've had a quick skim and it seems fine to me. If it works, then I'd say we should put it in the tree and see how it goes. Any reservations from you?
NOTE: the chirp/drivers/ft50_ll.py file is no longer needed and should be removed. I don't know how to include that change in the soft-commit and patch.
What you did should be fine.
Thanks!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
I noticed my changes to the FT-50 driver are in the tree now. However, my test image did not make it yet. I guess Dan needs to get that checked in so the driver is covered by the testing.
Also, someone can update the web page to indicate support for this model whenever you guys want.
Thanks for all the help! -mark
On Fri, Jan 15, 2016 at 5:26 PM, Mark Adams madams74@gmail.com wrote:
Dan (& group),
Sorry it took me a couple of days to get back to you. I made some minor improvements including fixing a few pep8 issues and improving upload reliability. I think this is now ready to go into the tree.
This new patch completely replaces the first patch. It includes the removal of the ft50_II.py file this time.
Feel free to let me know if there are any issues.
Thanks, -mark
On Sat, Jan 9, 2016 at 8:39 PM, Dan Smith via chirp_devel < chirp_devel@intrepid.danplanet.com> wrote:
Hi Mark,
Sorry for the delayed response.
I've gotten enough completed on the FT-50 driver that I thought it was time for a patch. I'd like some eyes on it to make sure I'm not doing something really wrong or going in a bad direction.
I've had a quick skim and it seems fine to me. If it works, then I'd say we should put it in the tree and see how it goes. Any reservations from you?
NOTE: the chirp/drivers/ft50_ll.py file is no longer needed and should be removed. I don't know how to include that change in the soft-commit and patch.
What you did should be fine.
Thanks!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
participants (2)
-
Dan Smith -
Mark Adams