[chirp_devel] [PATCH] [anytone_iii] Add the new radio AnyTone 5888UV-III
I suppose I should promise not to touch this for at least a week. Here's hopefully my last submission for this feature. It passes cpep8. Quick...get it in before he touches it again! Ha!
Brad Schuler K0BAS
I suppose I should promise not to touch this for at least a week. Here’s hopefully my last submission for this feature. It passes cpep8. Quick…get it in before he touches it again! Ha!
Thanks for getting it to pass. I'm going to go ahead and apply this since it's been through several revisions and passes all the tests. I'd really appreciate it if you would follow up with a patch to fix the mix of CamelCase and under_score variable and function names. It's typical in python to use CamelCase for class names only. Functions, methods, and variables should be under_score format. You've got a mix of both in here. By far the most common style in chirp is only to use CamelCase for class names.
Thanks!
--Dan
Thanks Dan. Will do.
Brad Schuler K0BAS
-----Original Message----- From: chirp_devel-bounces@intrepid.danplanet.com chirp_devel-bounces@intrepid.danplanet.com On Behalf Of Dan Smith via chirp_devel Sent: Tuesday, November 24, 2020 9:51 AM To: chirp-devel chirp_devel@intrepid.danplanet.com Subject: Re: [chirp_devel] [PATCH] [anytone_iii] Add the new radio AnyTone 5888UV-III
I suppose I should promise not to touch this for at least a week. Here’s hopefully my last submission for this feature. It passes cpep8. Quick…get it in before he touches it again! Ha!
Thanks for getting it to pass. I'm going to go ahead and apply this since it's been through several revisions and passes all the tests. I'd really appreciate it if you would follow up with a patch to fix the mix of CamelCase and under_score variable and function names. It's typical in python to use CamelCase for class names only. Functions, methods, and variables should be under_score format. You've got a mix of both in here. By far the most common style in chirp is only to use CamelCase for class names.
Thanks!
--Dan
_______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
participants (2)
-
Brad & Cindy Schuler -
Dan Smith