[chirp_devel] [PATCH] [thd72] Re-enable clone mode driver as experimental. #81
# HG changeset patch # User Tom Hayward tom@tomh.us # Date 1357329832 28800 # Node ID 7b345f7a65fed900a07ff96f1be9e3a442da2076 # Parent 3ee0597a03ef71a53c154ea2046569f65386ea0a [thd72] Re-enable clone mode driver as experimental. #81
diff -r 3ee0597a03ef -r 7b345f7a65fe chirp/kenwood_live.py --- a/chirp/kenwood_live.py Fri Jan 04 00:49:35 2013 +0100 +++ b/chirp/kenwood_live.py Fri Jan 04 12:03:52 2013 -0800 @@ -891,7 +891,7 @@ @directory.register class THD72Radio(TMD710Radio): """Kenwood TH-D72""" - MODEL = "TH-D72" + MODEL = "TH-D72 (live mode)" HARDWARE_FLOW = sys.platform == "darwin" # only OS X driver needs hw flow
def _parse_mem_spec(self, spec): diff -r 3ee0597a03ef -r 7b345f7a65fe chirp/thd72.py --- a/chirp/thd72.py Fri Jan 04 00:49:35 2013 +0100 +++ b/chirp/thd72.py Fri Jan 04 12:03:52 2013 -0800 @@ -15,7 +15,7 @@
from chirp import chirp_common, errors, util, directory from chirp import bitwise, memmap -import time, struct +import time, struct, sys
DEBUG = True
@@ -162,17 +162,27 @@
# Uploads result in "MCP Error" and garbage data in memory # Clone driver disabled in favor of error-checking live driver. -#@directory.register -class THD72Radio(chirp_common.CloneModeRadio): +@directory.register +class THD72Radio(chirp_common.CloneModeRadio, + chirp_common.ExperimentalRadio): BAUD_RATE = 9600 VENDOR = "Kenwood" - MODEL = "TH-D72" + MODEL = "TH-D72 (clone mode)" + HARDWARE_FLOW = sys.platform == "darwin" # only OS X driver needs hw flow
mem_upper_limit = 1022 _memsize = 65536 _model = "" # FIXME: REMOVE _dirty_blocks = []
+ @classmethod + def get_experimental_warning(cls): + return ('Please ensure you have installed the most recent Silicon Labs ' + 'CP210x virtual comm port driver. Versions prior to 3.0 are ' + 'known to lock up when attempting to upload to a TH-D72 with ' + 'Chirp. You can download the driver at ' + 'http://www.silabs.com/products/mcu/Pages/USBtoUARTBridgeVCPDrivers.aspx') + def get_features(self): rf = chirp_common.RadioFeatures() rf.memory_bounds = (0, 1031)
On Fri, Jan 4, 2013 at 12:06 PM, Tom Hayward esarfl@gmail.com wrote:
- @classmethod
- def get_experimental_warning(cls):
return ('Please ensure you have installed the most recent Silicon Labs '
'CP210x virtual comm port driver. Versions prior to 3.0 are '
'known to lock up when attempting to upload to a TH-D72 with '
'Chirp. You can download the driver at '
'http://www.silabs.com/products/mcu/Pages/USBtoUARTBridgeVCPDrivers.aspx')
Looks like this message is only valid for OS X. How can I make the driver experimental only for OS X? Maybe something like this...
def get_experimental_warning(cls): return sys.platform == "darwin" and 'Please ensure you have installed the most recent Silicon Labs..'
Tom
Looks like this message is only valid for OS X. How can I make the driver experimental only for OS X? Maybe something like this...
def get_experimental_warning(cls): return sys.platform == "darwin" and 'Please ensure you have
installed the most recent Silicon Labs..'
Well, the UI will still show it because it's a subclass of experimental. I think it's fine to leave it marked experimental for a while anyway, but isn't this just a driver bug? If they're running the latest then it works fine, right? I'd say handle that like any other unrelated-to-chirp issue.
On Fri, Jan 4, 2013 at 2:01 PM, Dan Smith dsmith@danplanet.com wrote:
Well, the UI will still show it because it's a subclass of experimental. I think it's fine to leave it marked experimental for a while anyway, but isn't this just a driver bug? If they're running the latest then it works fine, right? I'd say handle that like any other unrelated-to-chirp issue.
Yeah, I can just remove the experimental notice and if anyone reports the problem described in http://chirp.danplanet.com/issues/81 we can just tell them to update their USB serial driver. I suspect the number of people that have the broken driver version installed is pretty small.
Tom
participants (2)
-
Dan Smith
-
Tom Hayward