[chirp_devel] [PATCH] [uv-b5] add additional ACK value
# HG changeset patch # User Jim Unroe rock.unroe@gmail.com # Date 1385220952 18000 # Node ID 409ecf4c129224a4850880f763f2bfaee5e08052 # Parent fc6b4cd40403f4bb3f2b9bc3578366fdf20a85c6 [uv-b5] add additional ACK value 'unexpected response' caused by '0x48' not in list of expected ACK values related to bug #1111
diff -r fc6b4cd40403 -r 409ecf4c1292 chirp/uvb5.py --- a/chirp/uvb5.py Sun Nov 17 11:15:47 2013 -0800 +++ b/chirp/uvb5.py Sat Nov 23 10:35:52 2013 -0500 @@ -194,7 +194,7 @@ raise errors.RadioError("Invalid response for address 0x%04x" % i) radio.pipe.write("\x06") ack = radio.pipe.read(1) - if ack not in ('\x74', '\x78', '\x1f'): + if ack not in ('\x48', '\x74', '\x78', '\x1f'): print util.hexprint(ack) raise errors.RadioError("Unexpected response") data += result[4:]
Dan, If you haven't applied this patch already (didn't see it committed to trunk yet), I'll supercede this patch with another (attached) that adds 0x29 for issue #1263, and factors this out to a package "constant" list.
If you have already committed, I'll update and resubmit patch...
[uv-b5] more acks for radio (0x48, 0x29) #1263
-Jens
________________________________ From: Jim Unroe rock.unroe@gmail.com To: chirp_devel@intrepid.danplanet.com Sent: Saturday, November 23, 2013 9:51 AM Subject: [chirp_devel] [PATCH] [uv-b5] add additional ACK value
# HG changeset patch # User Jim Unroe rock.unroe@gmail.com # Date 1385220952 18000 # Node ID 409ecf4c129224a4850880f763f2bfaee5e08052 # Parent fc6b4cd40403f4bb3f2b9bc3578366fdf20a85c6 [uv-b5] add additional ACK value 'unexpected response' caused by '0x48' not in list of expected ACK values related to bug #1111
diff -r fc6b4cd40403 -r 409ecf4c1292 chirp/uvb5.py --- a/chirp/uvb5.py Sun Nov 17 11:15:47 2013 -0800 +++ b/chirp/uvb5.py Sat Nov 23 10:35:52 2013 -0500 @@ -194,7 +194,7 @@ raise errors.RadioError("Invalid response for address 0x%04x" % i) radio.pipe.write("\x06") ack = radio.pipe.read(1) - if ack not in ('\x74', '\x78', '\x1f'): + if ack not in ('\x48', '\x74', '\x78', '\x1f'): print util.hexprint(ack) raise errors.RadioError("Unexpected response") data += result[4:] _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
If you haven't applied this patch already (didn't see it committed to trunk yet), I'll supercede this patch with another (attached) that adds 0x29 for issue #1263, and factors this out to a package "constant" list.
If you have already committed, I'll update and resubmit patch...
Sorry, I was just marching through and applying. I'll push in a few minutes. Can you send a delta on top?
Thanks!
--Dan
updated patch
----- Original Message ----- From: Dan Smith dsmith@danplanet.com To: chirp_devel@intrepid.danplanet.com Cc: Sent: Wednesday, November 27, 2013 3:16 PM Subject: Re: [chirp_devel] [PATCH] [uv-b5] add additional ACK value
If you haven't applied this patch already (didn't see it committed to trunk yet), I'll supercede this patch with another (attached) that adds 0x29 for issue #1263, and factors this out to a package "constant" list.
If you have already committed, I'll update and resubmit patch...
Sorry, I was just marching through and applying. I'll push in a few minutes. Can you send a delta on top?
Thanks!
--Dan
_______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
participants (3)
-
Dan Smith
-
Jens J.
-
Jim Unroe