[chirp_devel] [PATCH][BTECH] Improved _recv() procedure to be less intensive, fixes #3015
The _recv() procedure has been rewote to read big chunks of data to lower the system load as requested.
- # catching ack
- ack = _rawrecv(radio, 1)
- # get the whole block
- block = _rawrecv(radio, BLOCK_SIZE + 5)
It's not terrible to read just the ack, especially if you could get back a NAK and need to notice immediately. However, unless you were going to retry I think reading the ack and the block in one go is better anyway.
I will apply this when you guys say I should.
--Dan
El 29/03/16 a las 18:44, Dan Smith via chirp_devel escribió:
- # catching ack
- ack = _rawrecv(radio, 1)
- # get the whole block
- block = _rawrecv(radio, BLOCK_SIZE + 5)
It's not terrible to read just the ack, especially if you could get back a NAK and need to notice immediately. However, unless you were going to retry I think reading the ack and the block in one go is better anyway.
I will apply this when you guys say I should.
Nope, the driver is not build to retry so it's safe this way, you can apply it safely.
73
participants (2)
-
Dan Smith -
M.Sc. Pavel Milanes Costa