Re: [chirp_devel] Build test results: Failure
I looked at this, I'm pretty sure my patch did not cause this.
However, if you look in the file it modified, mainapp.py, there are linewraps in the existing code near lines 256, 714, 790, 805, 1052, 1113, 1229, 1356, 1516-1559, 1625, and 1693.
-dan
On Jul 11, 2014, at 3:23 PM, Build System - donotreply@danplanet.com wrote:
Tested changes:
[Dan Drogichen chirp.cordless@xoxy.net] [developer] Add diffs-only mode to file diff utility - #1699
Adds an alternate display mode to the developer tools whole-file hex dump/diff utility in which only lines which are different are printed. Ranges of one or more lines that do not differ are replaced with a single blank line.
This mode is invoked by setting the first memory location in the "Diff Radios" popup to -2. The existing functionality invoked by -1 is not affected.
#1699 ... ================================================ Tests FAILED: style tests Build step 'Execute shell' marked build as failure Email was triggered for: Failure Sending email for trigger: Failure
I looked at this, I'm pretty sure my patch did not cause this.
However, if you look in the file it modified, mainapp.py, there are linewraps in the existing code near lines 256, 714, 790, 805, 1052, 1113, 1229, 1356, 1516-1559, 1625, and 1693.
Yep, it just runs on any file touched by the top patch. If you modified a file that had existing offenses in it, then it will report the issue(s). Ideally we'd get all the style to be clean so that new offenses would be flagged, but that's a long road :)
--Dan
participants (2)
-
chirp.cordless＠xoxy.net -
Dan Smith