[chirp_devel] Patch for issue 1155: chirpw crashes on "pyver.split" on OpenSuSE 11.4
Sorry about that. I qpopped the non-conforming patch and junked the comments in the code. Revised patch is attached. It does not depend upon the earlier patch. I believe that's how you'd want it.
Thank you for walking me through the process! Your DevelopersProcess wiki page is excellent, sorry I needed more help.
73 de AC2LQ
Sorry about that. I qpopped the non-conforming patch and junked the comments in the code. Revised patch is attached. It does not depend upon the earlier patch. I believe that's how you'd want it.
Yep, thanks.
# HG changeset patch # User ac2lq DrVigg@gmail.com # Date 1380558220 14400 # Node ID 1babcaf7d572e5047a0d6bb3829744c47b8bf486 # Parent ac65038940f227d46ba28186627b42108dae6447 Addressed a crash at launch of chirpw on OpenSuSE 11.4. The build of Python for this distro appears to define sys.version in a different format than expected.
A better approach may be to use sys.hex_version, but I lack the expertise with Python to deal with potential endian issues and to parse it.
This commit message needs to have a bug number in it in the proper format or our commit hook refuses to accept it:
remote: transaction abort! remote: rollback completed remote: abort: pretxnchangegroup.bugid hook exited with status 1
This helps us enforce documentation of each change through the bug tracker. You've got the number in the subject of the email (although not in the format the hook recognizes) but not in the commit message which is what actually goes into the tree.
See the "Patch Guidelines" part of the process document, specifically the "you must include a bug number" part:
http://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess#Patch-Guide...
Thanks!
participants (2)
-
Dan Smith
-
J A Stephen Viggiano