[chirp_devel] [Bug 821] Add VX8 memory layout in preparation for APRS settings menu
Hi,
This patch adds the APRS menu settings to the memory description for the VX8 series of radios. I intend on adding an APRS entry to the Settings tab, enabling users to alter the settings.
I've successfully checked the attached layout against memory images for: VX8-DR VX8-DE VX8-GE I've attached an image of my VX8-DR to http://chirp.danplanet.com/issues/821for addition to the tests/images directory.
The settings memory layout doesn't exactly match the VX-R in chirp/tests/images/, and since I don't have VX8-R to examine I won't enable the settings menu for that model. The APRS beacons memories for that model parse OK.
Hi Sean,
Sorry for the delay. Work has been busy.
changeset: 1977:ff8811642690 user: Sean Burford sburford@google.com date: Wed May 01 08:14:17 2013 +1000 summary: [VX8] Add APRS settings menu
Hrm, I see the memory layout mapping (which is awesome). The description makes it sound like there should be stuff in here that actually makes these accessible via the settings tab. I'm happy to commit this, but I just want to make sure it's not missing something you intended to include.
Thanks!
Hi,
On Fri, May 3, 2013 at 9:14 AM, Dan Smith dsmith@danplanet.com wrote:
Sorry for the delay. Work has been busy.
changeset: 1977:ff8811642690 user: Sean Burford sburford@google.com date: Wed May 01 08:14:17 2013 +1000 summary: [VX8] Add APRS settings menu
Hrm, I see the memory layout mapping (which is awesome). The description makes it sound like there should be stuff in here that actually makes these accessible via the settings tab. I'm happy to commit this, but I just want to make sure it's not missing something you intended to include.
I don't know if you like large patches or small patches, so I favoured a smaller self contained patch that didn't add any functionality. I'm half way there on populating the settings menu, so if you prefer you can wait a few days and receive a patch that has the memory layout and the settings menu code. Your call.
Thanks!
-- Dan Smith www.danplanet.com KK7DS
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
I don't know if you like large patches or small patches, so I favoured a smaller self contained patch that didn't add any functionality. I'm half way there on populating the settings menu, so if you prefer you can wait a few days and receive a patch that has the memory layout and the settings menu code. Your call.
I prefer small, I was just confused by the subject :)
Thanks!
Hi,
On Sat, May 4, 2013 at 12:12 PM, Dan Smith dsmith@danplanet.com wrote:
I don't know if you like large patches or small patches, so I favoured a smaller self contained patch that didn't add any functionality. I'm half way there on populating the settings menu, so if you prefer you can wait a few days and receive a patch that has the memory layout and the settings menu code. Your call.
I prefer small, I was just confused by the subject :)
The attached patch adds menus to Chirp for the APRS settings in the VX-8[DG][RE] series radios. I don't have a VX-8D to test against and I can see that it has a different memory layout so the menu is not enabled for that model. This patch should add all of the options available in the APRS menu for the supported radios.
There is a memory image from me VX-8DR attached to bug 821 that you can use for testing.
The patch from earlier in this thread is no longer needed, it's included in this patch.
The VX-8 directly uses some enumerated values from the APRS standards. I've added these to chirp_common as they may appear in other radios. They are unmodified, in that the indexes of the items match the indexes from the standards. Other constants that are local to these radios are included in vx8.py.
The latitude/longitude conversion code might do well in chirp_common, but it's in vx8.py for now. Latitude/longitude conversion is included so that they can be displayed in the users preferred format and the user can enter them in either accepted format.
I would have liked to have altered some displayed fields based on the users actions in real time, for example changing the latitude/longitude display format when the user changes their lat/long display format preference.
Robert Terzi put me in contact with Geoffrey Merck (F4FXL), who contributed testing, suggestions and some memory locations to this patch. He also tested it against the VX8-GE, which is newly supported in Chirp with this patch.
The attached patch adds menus to Chirp for the APRS settings in the VX-8[DG][RE] series radios.
Awesome!
I don't have a VX-8D to test against and I can see that it has a different memory layout so the menu is not enabled for that model.
Would an image from an 8R likely be enough to go on? I think maybe the list of changes from the 8R to the 8DR and an image might be good enough. My 8R was converted by the factory to an 8DR, so I don't have an original model to test against either (although I have images), but I imagine someone in the community does.
Hi,
There's an 8R image in the tests directory :) I could have a look to see what appears to have disappeared and changed and try to match that with the published differences between the 8R and later models, but I wasn't sure it would be worthwhile since I expect most 8R owners took advantage of the upgrade option. Ok, I'll take a look and let you know if I need more images.
On Tue, May 21, 2013 at 9:25 AM, Dan Smith dsmith@danplanet.com wrote:
The attached patch adds menus to Chirp for the APRS settings in the VX-8[DG][RE] series radios.
Awesome!
I don't have a VX-8D to test against and I can see that it has a different memory layout so the menu is not enabled for that model.
Would an image from an 8R likely be enough to go on? I think maybe the list of changes from the 8R to the 8DR and an image might be good enough. My 8R was converted by the factory to an 8DR, so I don't have an original model to test against either (although I have images), but I imagine someone in the community does.
-- Dan Smith www.danplanet.com KK7DS
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
There's an 8R image in the tests directory :)
Ah, cool, I didn't realize I had updated that one.
I could have a look to see what appears to have disappeared and changed and try to match that with the published differences between the 8R and later models, but I wasn't sure it would be worthwhile since I expect most 8R owners took advantage of the upgrade option. Ok, I'll take a look and let you know if I need more images.
Well, it's not a huge deal, as I'm sure you're right. I wouldn't spend much time on it, I just thought I'd ask.
Again, thanks!
participants (2)
-
Dan Smith -
Sean Burford