[chirp_devel] [PATCH] [vx5] bugfix, power levels, and 8-char names
Here are 3 patches for the VX5 driver. I hope attachments work; I don't know how to use hg email!
Here is a summary:
changeset: 1395:693766bb1594 branch: vx5 tag: tip user: Tom Hayward KD7LXL esarfl@gmail.com date: Sat Mar 10 17:10:27 2012 -0700 summary: [vx5] allow 8-character names
changeset: 1394:c0f877c47900 branch: vx5 user: Tom Hayward KD7LXL esarfl@gmail.com date: Sat Mar 10 16:41:25 2012 -0700 summary: [vx5] add power level support
changeset: 1393:35b6ec0749d2 branch: vx5 parent: 954:09af2a62cf91 user: Tom Hayward KD7LXL esarfl@gmail.com date: Sat Mar 10 16:01:04 2012 -0700 summary: [vx5] bugfix: set non-empty memories visible.
This last one was a significant bug. The VX5 has a bit for each memory called "visible". From the VX5, you can mask a memory, rendering it invisible. When chirp was creating a new memory, it was not setting this bit, so newly added memories were invisible! The original tester must have only tried editing existing memories where the "visible" bit was already set.
Tom KD7LXL
changeset: 1395:693766bb1594 branch: vx5 tag: tip user: Tom Hayward KD7LXL esarfl@gmail.com date: Sat Mar 10 17:10:27 2012 -0700 summary: [vx5] allow 8-character names
Applied, thanks!
changeset: 1394:c0f877c47900 branch: vx5 user: Tom Hayward KD7LXL esarfl@gmail.com date: Sat Mar 10 16:41:25 2012 -0700 summary: [vx5] add power level support
This does not apply. It looks like you generated this against a snap of the code before the dynamic registration stuff went in.
changeset: 1393:35b6ec0749d2 branch: vx5 parent: 954:09af2a62cf91 user: Tom Hayward KD7LXL esarfl@gmail.com date: Sat Mar 10 16:01:04 2012 -0700 summary: [vx5] bugfix: set non-empty memories visible.
Applied, thanks!
On Mon, Mar 12, 2012 at 18:37, Dan Smith dsmith@danplanet.com wrote:
changeset: 1394:c0f877c47900 branch: vx5 user: Tom Hayward KD7LXL esarfl@gmail.com date: Sat Mar 10 16:41:25 2012 -0700 summary: [vx5] add power level support
This does not apply. It looks like you generated this against a snap of the code before the dynamic registration stuff went in.
Ok, it turns out I don't know how to merge with Mercurial :)
This patch should apply cleanly.
Note that two of these patches (this one included) required changing your bit layout for the VX5. Flipping the "power" bits on the old version would lockup the radio! This is one of the reasons I was having so much trouble programming my VX5 before. I think I have the memory layout sorted now, so no more lockups.
Tom
Note that two of these patches (this one included) required changing your bit layout for the VX5. Flipping the "power" bits on the old version would lockup the radio! This is one of the reasons I was having so much trouble programming my VX5 before. I think I have the memory layout sorted now, so no more lockups.
Yep, I saw. Seeing that I wrote the driver without laying a hand on an actual radio, that doesn't surprise me a bit :)
Applied, thanks!
participants (2)
-
Dan Smith -
Tom Hayward