[chirp_devel] [PATCH] [KG-UV920P-A] Add Wouxun KG-UV920P-A
Matthew and Chirp-Devel,
Nice! Thank you for developing this driver. I am going to try to find time today to dig my Wouxun KG-UV920P-A out of mothballs and give this a go. It looks great!
Below are a couple of things that you might have to address before it gets accepted (unless Dan takes care of it for you):
1. I think it was requested that the commit message be broken up into lines of less than 80 characters. I could be wrong but something got me into the habit of doing it. ;-)
2. I don't see where the driver was added to the cpep8.manifest. It needs to be listed in the manifest so that the build system will know to perform a pep8 style check on it during the build process. The good news is that your driver passes the style check with flying colors.
Thank you again for your work developing this driver.
Jim KC9HI
On Sun, Feb 13, 2022 at 9:46 PM Matthew Handley via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
Hi Jim,
Thank you for the feedback. If you're able to test this against your own KG-UV920P-A, that would be great.
Unless I hear otherwise, I'll create a new patch with those two corrections when I have a chance this evening. Would the convention be to share it in this same email thread, or start a new one?
Thanks, Matt KF7TAL
On Mon, Feb 14, 2022 at 7:59 AM Jim Unroe rock.unroe@gmail.com wrote:
Matthew and Chirp-Devel,
Nice! Thank you for developing this driver. I am going to try to find time today to dig my Wouxun KG-UV920P-A out of mothballs and give this a go. It looks great!
Below are a couple of things that you might have to address before it gets accepted (unless Dan takes care of it for you):
- I think it was requested that the commit message be broken up into
lines of less than 80 characters. I could be wrong but something got me into the habit of doing it. ;-)
- I don't see where the driver was added to the cpep8.manifest. It
needs to be listed in the manifest so that the build system will know to perform a pep8 style check on it during the build process. The good news is that your driver passes the style check with flying colors.
Thank you again for your work developing this driver.
Jim KC9HI
On Sun, Feb 13, 2022 at 9:46 PM Matthew Handley via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs:
Hello Chirp-Devel,
Attached is an update patch that should be used in place of the original one I submitted in this thread for the KG-UV920P-A. This patch implements suggestions from Jim Unroe on top of my original one. If there are any other issues, please let me know.
Thanks, Matt KF7TAL
On Tue, Feb 15, 2022 at 11:09 AM Matthew Handley kf7tal@gmail.com wrote:
Hi Jim,
Thank you for the feedback. If you're able to test this against your own KG-UV920P-A, that would be great.
Unless I hear otherwise, I'll create a new patch with those two corrections when I have a chance this evening. Would the convention be to share it in this same email thread, or start a new one?
Thanks, Matt KF7TAL
On Mon, Feb 14, 2022 at 7:59 AM Jim Unroe rock.unroe@gmail.com wrote:
Matthew and Chirp-Devel,
Nice! Thank you for developing this driver. I am going to try to find time today to dig my Wouxun KG-UV920P-A out of mothballs and give this a go. It looks great!
Below are a couple of things that you might have to address before it gets accepted (unless Dan takes care of it for you):
- I think it was requested that the commit message be broken up into
lines of less than 80 characters. I could be wrong but something got me into the habit of doing it. ;-)
- I don't see where the driver was added to the cpep8.manifest. It
needs to be listed in the manifest so that the build system will know to perform a pep8 style check on it during the build process. The good news is that your driver passes the style check with flying colors.
Thank you again for your work developing this driver.
Jim KC9HI
On Sun, Feb 13, 2022 at 9:46 PM Matthew Handley via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs:
participants (2)
-
Jim Unroe -
Matthew Handley