[chirp_devel] [PATCH][tk270.py] Increase OEM band edges by +/- 4.0%, fix #4709
Some of this model's variants are in ranges near ham bands but outside them by the OEM stated range, for example from 150 to 174 Mhz, or 148 to 174 Mhz, in the case of the UHF we has the variants in the 450 to 490 Mhz or the 406 to 430 Mhz.
I make some characterizations and most of the radios can work safely with an +/- 4% of the stated range safely and will allow to work near ham bands. (real range is bigger but we stick to a safe value)
Related also to #4789, see this for real edges data measurements.
73 de Pavel CO7WT.
('This driver is experimental and for personal use only.'
I hadn't noticed this before, but it's not okay. Since you're editing this text, can you please remove this "for personal use only" statement? The license does not permit you to place restrictions like this on the users.
'It has a limited set of features, but the most used by hams.\n' '\n'
'This is a first release, so it will contains bugs, use it''on your own risk, keep a mem backup with the original ''software at hand\n'
'All of this radios are able to work a little off the OEM ''frequency limits, by experimentation we set it at ± 4%, '
Please don't use the +/0 symbol. Just say "4% wider at each edge" or something.
--Dan
El 04/05/17 a las 18:07, Dan Smith via chirp_devel escribió:
'It has a limited set of features, but the most used by hams.\n' '\n'
'This is a first release, so it will contains bugs, use it''on your own risk, keep a mem backup with the original ''software at hand\n'
'All of this radios are able to work a little off the OEM ''frequency limits, by experimentation we set it at ± 4%, 'Please don't use the +/0 symbol. Just say "4% wider at each edge" or something.
--Dan
Humm, I think it was my email client, as I write them as +/- in code...
Never mind, I will mod them as per suggested changes and will re submit all patches...
73 and thanks for the comments.
On Wed, May 3, 2017 at 11:02 AM, Pavel Milanes Costa via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
'It has a limited set of features, but the most used by hams.\n'
How about something like "Not all features have been implemented, but it has those features most used by hams."
'All of this radios are able to work a little off the OEM ''frequency limits, by experimentation we set it at +/- 4%, ''that must allow you to work the ham bands in some models.\n'
"The radio is able to work slightly outside the OEM frequency limit. After testing, the limit in Chirp has been set 4% outside the OEM limit. This allows you to use some models on the ham bands."
'Nevertheless, each radio has it\'s own hardware limits and as ''usual your mileage may vary.\n'
"its own", no apostrophe needed.
self._range = [low * 1000000, high * 1000000]
# Frequency ranges: some model/variants are able to work the near# ham bands, even if they are outside the OEM ranges.# By experimentation we found that a +/- 4% at the edges is in most# cases safe and will cover the near ham band in fullself._range = [low * 1000000 * 0.96, high * 1000000 * 1.04] # put the VARIANT in the class, clean the model / CHs / Type # in the same layout as the KPG program self._VARIANT = self.MODEL + " [" + str(self._upper) + "CH]: " self._VARIANT += self._kind + ", "# In the OEM string we show the real OEM ranges self._VARIANT += str(self._range[0]/1000000) + "-" self._VARIANT += str(self._range[1]/1000000) + " Mhz"
You added a comment that the OEM string shows the original range, but you use the variables you just modified. To print the original, you need:
self._VARIANT += "%d-%d MHz" % (low, high)
The other drivers have the same issues. I don't have time to comment on those right now. You could make these changes to all of them and resubmit, or wait and I'll finish my review of the others when I have a chance.
Tom KD7LXL
Roger,
I'm not a native English speaking OM, so this comments helps me a lot: Thanks!
About the string using the mod vars, my bet.
I'm modding the driver with this tips and Dan's ones to re-send the patches...
73.
El 04/05/17 a las 19:25, Tom Hayward escribió:
On Wed, May 3, 2017 at 11:02 AM, Pavel Milanes Costa via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
'It has a limited set of features, but the most used by hams.\n'How about something like "Not all features have been implemented, but it has those features most used by hams."
'All of this radios are able to work a little off the OEM ''frequency limits, by experimentation we set it at +/- 4%, ''that must allow you to work the ham bands in some models.\n'"The radio is able to work slightly outside the OEM frequency limit. After testing, the limit in Chirp has been set 4% outside the OEM limit. This allows you to use some models on the ham bands."
'Nevertheless, each radio has it\'s own hardware limits and as ''usual your mileage may vary.\n'"its own", no apostrophe needed.
self._range = [low * 1000000, high * 1000000]
# Frequency ranges: some model/variants are able to work the near# ham bands, even if they are outside the OEM ranges.# By experimentation we found that a +/- 4% at the edges is in most# cases safe and will cover the near ham band in fullself._range = [low * 1000000 * 0.96, high * 1000000 * 1.04] # put the VARIANT in the class, clean the model / CHs / Type # in the same layout as the KPG program self._VARIANT = self.MODEL + " [" + str(self._upper) + "CH]: " self._VARIANT += self._kind + ", "# In the OEM string we show the real OEM ranges self._VARIANT += str(self._range[0]/1000000) + "-" self._VARIANT += str(self._range[1]/1000000) + " Mhz"You added a comment that the OEM string shows the original range, but you use the variables you just modified. To print the original, you need:
self._VARIANT += "%d-%d MHz" % (low, high)
The other drivers have the same issues. I don't have time to comment on those right now. You could make these changes to all of them and resubmit, or wait and I'll finish my review of the others when I have a chance.
Tom KD7LXL
participants (3)
-
Dan Smith -
Pavel Milanes Costa -
Tom Hayward