[chirp_devel] Dan comments: needs a bug reference according to our process.
Could you please arrange to edit a page in the developer wiki:
at page: https://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess at secion: Submitting a patch at text: "You must include an Issue Number (#123 https://chirp.danplanet.com/issues/123) somewhere in the commit message to tie each patch to an issue for tracking purposes."
somehow re-iterate or hammer home the point that the bug reference has to be actually in the patch itself, in the patch message. Maybe to change 'commit message' to Mercurial commit message in the patch itself'?
I'm not sure of the exact wording to use, but consider the following:
For those of you familiar with "Thinking, Fast and Slow" I breezed through that section of the developer process and got an understanding based on fast thinking, that we commit patches by a message to the maillist and that message must have the bug reference, and then seeing many such messages in the list with those numbers referenced in the subject line, and perhaps the mail message body, I follow and do the same. Now based on slow thinking, after getting comments about including a bug reference when I did so, and re-reading the instructions, I come to the conclusion that I come from a different planet than dan planet. Yep, so when I check for a definition of 'mercurial commit message' I see dan planet's meaning reinforced, and realize I have understood 'commit message' to refer to the message sent to the maillist.
Dan, again, my apologies and thanks for your patience with off-worlders!
at page: https://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess at secion: Submitting a patch at text: "You must include an Issue Number (#123) somewhere in the commit message to tie each patch to an issue for tracking purposes."
somehow re-iterate or hammer home the point that the bug reference has to be actually in the patch itself, in the patch message. Maybe to change 'commit message' to Mercurial commit message in the patch itself'?
There is only one commit message in that process, so I don't know how it could be misconstrued otherwise really. But, I added more words and made one bold so hopefully it will stand out a bit more :)
--Dan
participants (2)
-
Dan Smith
-
Rudolph Gutzerhagen