[chirp_devel] run_test script
The run_test script no longer runs on my Windows computer.
C:\Users\Root\chirp.hg\tests>python run_tests Traceback (most recent call last): File "run_tests", line 30, in <module> os.chdir(scriptdir) WindowsError: [Error 123] The filename, directory name, or volume label syntax i s incorrect: ''
Zach, any thoughts!
Jim KC9HI
Hi Jim,
The run_test script no longer runs on my Windows computer.
C:\Users\Root\chirp.hg\tests>python run_tests Traceback (most recent call last): File "run_tests", line 30, in <module> os.chdir(scriptdir) WindowsError: [Error 123] The filename, directory name, or volume label syntax i s incorrect: ''
Looks like this is related to the following change:
http://chirp.danplanet.com/projects/chirp/repository/revisions/d3a3d61f1779/...
If you just undo those changes locally I think you should be able to run your tests on your patch while we wait for someone to figure out what the real problem is.
Maybe I need to make the build system try running the tests on the Windows box too, although it hasn't been a problem for years and will delay the results quite a bit.
--Dan
On Sun, Mar 15, 2015 at 11:29 AM, Dan Smith dsmith@danplanet.com wrote:
Hi Jim,
The run_test script no longer runs on my Windows computer.
C:\Users\Root\chirp.hg\tests>python run_tests Traceback (most recent call last): File "run_tests", line 30, in <module> os.chdir(scriptdir) WindowsError: [Error 123] The filename, directory name, or volume label syntax i s incorrect: ''
Looks like this is related to the following change:
http://chirp.danplanet.com/projects/chirp/repository/revisions/d3a3d61f1779/...
If you just undo those changes locally I think you should be able to run your tests on your patch while we wait for someone to figure out what the real problem is.
It doesn't help. The error then becomes...
C:\Users\Root\chirp.hg\tests>python run_tests DEBUG: CHIRP 0.3.0dev on WinVista/7 (Python 2.7.3) DEBUG: verbosity=50 Traceback (most recent call last): File "run_tests", line 41, in <module> logger.handle_options(LoggerOpts()) File "../chirp\logger.py", line 177, in handle_options logger.create_log_file(options.log_file) File "../chirp\logger.py", line 123, in create_log_file with file(name, "w") as fh: IOError: [Errno 2] No such file or directory: 'logs\debug.log'
Jim
It doesn't help. The error then becomes...
Well, it *helps* but there's more broken, I guess.
C:\Users\Root\chirp.hg\tests>python run_tests DEBUG: CHIRP 0.3.0dev on WinVista/7 (Python 2.7.3) DEBUG: verbosity=50 Traceback (most recent call last): File "run_tests", line 41, in <module> logger.handle_options(LoggerOpts()) File "../chirp\logger.py", line 177, in handle_options logger.create_log_file(options.log_file) File "../chirp\logger.py", line 123, in create_log_file with file(name, "w") as fh: IOError: [Errno 2] No such file or directory: 'logs\debug.log'
Try commenting out this line:
logger.handle_options(LoggerOpts())
Which looks to be line 41 for you.
Zach, are you going to work on these things, or do I need to?
Thanks!
--Dan
On 03/15/2015 10:50 AM, Jim Unroe wrote:
On Sun, Mar 15, 2015 at 11:29 AM, Dan Smith dsmith@danplanet.com wrote:
Hi Jim,
The run_test script no longer runs on my Windows computer.
C:\Users\Root\chirp.hg\tests>python run_tests Traceback (most recent call last): File "run_tests", line 30, in <module> os.chdir(scriptdir) WindowsError: [Error 123] The filename, directory name, or volume label syntax i s incorrect: ''
Looks like this is related to the following change:
http://chirp.danplanet.com/projects/chirp/repository/revisions/d3a3d61f1779/...
If you just undo those changes locally I think you should be able to run your tests on your patch while we wait for someone to figure out what the real problem is.
It doesn't help. The error then becomes...
C:\Users\Root\chirp.hg\tests>python run_tests DEBUG: CHIRP 0.3.0dev on WinVista/7 (Python 2.7.3) DEBUG: verbosity=50 Traceback (most recent call last): File "run_tests", line 41, in <module> logger.handle_options(LoggerOpts()) File "../chirp\logger.py", line 177, in handle_options logger.create_log_file(options.log_file) File "../chirp\logger.py", line 123, in create_log_file with file(name, "w") as fh: IOError: [Errno 2] No such file or directory: 'logs\debug.log'
FWIW, I was just able to reproduce the issue here on Linux. I never tried running 'python run_tests'; I always invoked it directly. So, I have a patch to fix this properly, and I'll submit it today.
With this change reverted (or fixed), I do not see this second issue. Does the logs/ directory exist inside tests/, or did it somehow get deleted?
No \logs directory.
Just \images and \unit
Jim
On Sun, Mar 15, 2015 at 2:03 PM, Zach Welch zach@mandolincreekfarm.com wrote:
On 03/15/2015 10:50 AM, Jim Unroe wrote:
On Sun, Mar 15, 2015 at 11:29 AM, Dan Smith dsmith@danplanet.com wrote:
Hi Jim,
The run_test script no longer runs on my Windows computer.
C:\Users\Root\chirp.hg\tests>python run_tests Traceback (most recent call last): File "run_tests", line 30, in <module> os.chdir(scriptdir) WindowsError: [Error 123] The filename, directory name, or volume label syntax i s incorrect: ''
Looks like this is related to the following change:
http://chirp.danplanet.com/projects/chirp/repository/revisions/d3a3d61f1779/...
If you just undo those changes locally I think you should be able to run your tests on your patch while we wait for someone to figure out what the real problem is.
It doesn't help. The error then becomes...
C:\Users\Root\chirp.hg\tests>python run_tests DEBUG: CHIRP 0.3.0dev on WinVista/7 (Python 2.7.3) DEBUG: verbosity=50 Traceback (most recent call last): File "run_tests", line 41, in <module> logger.handle_options(LoggerOpts()) File "../chirp\logger.py", line 177, in handle_options logger.create_log_file(options.log_file) File "../chirp\logger.py", line 123, in create_log_file with file(name, "w") as fh: IOError: [Errno 2] No such file or directory: 'logs\debug.log'
FWIW, I was just able to reproduce the issue here on Linux. I never tried running 'python run_tests'; I always invoked it directly. So, I have a patch to fix this properly, and I'll submit it today.
With this change reverted (or fixed), I do not see this second issue. Does the logs/ directory exist inside tests/, or did it somehow get deleted?
-- Zach Welch Mandolin Creek Farm www.mandolincreekfarm.com farm: 541-453-4131 cell: 541-740-3410 _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
On 03/15/2015 11:06 AM, Jim Unroe wrote:
No \logs directory.
Just \images and \unit
Looking at the code, I see that the logs/ directory gets created after the logging setup. It always worked for me, because I never tested it with a clean checkout. A simple workaround is to manually create that directory for now.
I'll include a proper fix for this in my forthcoming patch.
I'll include a proper fix for this in my forthcoming patch.
Thanks. Also, I was just writing a batch file to make running all the tests (including pep8) easier for windows users and realized that this:
python tools\cpep8.py
Still seems to ignore the blacklist and runs on everything (spewing messages all over the console).
So Jim, getting pip and pep8 installed is good, but there's still work to be done to make that work properly for you as well. In the meantime, I'll check things here when committing and fix them up for you.
--Dan
On 03/15/2015 11:18 AM, Dan Smith wrote:
I'll include a proper fix for this in my forthcoming patch.
Thanks. Also, I was just writing a batch file to make running all the tests (including pep8) easier for windows users and realized that this:
python tools\cpep8.py
Still seems to ignore the blacklist and runs on everything (spewing messages all over the console).
So Jim, getting pip and pep8 installed is good, but there's still work to be done to make that work properly for you as well. In the meantime, I'll check things here when committing and fix them up for you.
The workaround for this issue is to specify only the file(s) that you want to have checked on the command line. For example, this should check only the top-level CLI and GUI modules:
python tools\cpep8.py chirpc chirpw
On 03/15/2015 11:18 AM, Dan Smith wrote:
I'll include a proper fix for this in my forthcoming patch.
Thanks. Also, I was just writing a batch file to make running all the tests (including pep8) easier for windows users and realized that this:
python tools\cpep8.py
Still seems to ignore the blacklist and runs on everything (spewing messages all over the console).
FWIW, you will get a lot of spew if you accidentally use the wrong version of the pep8 module. There isn't anything listed in the blacklist anymore, and it only checks files in its manifest. Thus, my money would be on a version mismatch.
Along that same line, the Fedora Linux rpm builds also got broken by whatever drove the change moving the files that used to be in "chirpui" to "chirp/ui" a week or so ago. The scripts compiled the source ok, but the packaging tool was having difficulty with the new directory structure. It's fixed now, but the rpm build scripts run automatically, triggered by the "New Daily Build" e-mails and I didn't notice the problem for a couple of daily build release cycles. Fedora users missed out on a few (2?) daily builds because I didn't see the point in going backwards.
Admittedly, I had not been paying as much attention to the daily build changes as I should have been, I'll pay more attention in the future.
Mike, N0SO
On Mar 15, 2015, at 10:20 AM, Jim Unroe rock.unroe@gmail.com wrote:
The run_test script no longer runs on my Windows computer.
C:\Users\Root\chirp.hg\tests>python run_tests Traceback (most recent call last): File "run_tests", line 30, in <module> os.chdir(scriptdir) WindowsError: [Error 123] The filename, directory name, or volume label syntax i s incorrect: ''
Zach, any thoughts!
Jim KC9HI _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
participants (4)
-
Dan Smith -
Jim Unroe -
Mike Heitmann -
Zach Welch