On 05/17/2011 01:04 AM, Dan Smith wrote:

...

The manual shows a bank named '2 m amateur band' - 15 letters. So the 10 bytes are probably used for longer names. Could the 0x0 bytes be used to store name length, if it is "extra" length? I don't own a VX-8, so I can't try.

Yep, looks like it. Attached is an image with Bank1's name set to "BANK 1AAAAAAAAAA".

Great.

Here's a patch which implements get_banks for VX-3, VX-6 and VX-8. It returns a list of 24 bank names.

For VX-6, I've also implemented get_bank_channels. For bank number n, it returns the list of channels belonging to the bank.

No UI and no writing back yet. A channel can belong to any combination of banks.

Jon LA4RT

---

chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel

On 05/17/2011 11:09 PM, Robert Terzi wrote:

On 5/17/2011 11:11 AM, Jon Kåre Hellan wrote:

...

For VX-6, I've also implemented get_bank_channels. For bank number n, it returns the list of channels belonging to the bank.

I've been meaning to look and maybe you can save me some time:

how are you exercising your changes to the radio drivers?

Are you using chirp.py to load a radio image and test intereactively in the interpreter?

I load the image, and abuse the UI in various ways. If I set 'has_bank_index' to true, I get the 'Banks' pane in the UI. In one version, I appended the channel numbers of the members to the bank names.

Attaching code to show bank members on vx8 in the 'Banks' pane.

Jon LA4RT

---

chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel

On 5/17/2011 7:57 PM, Dan Smith wrote:

...

• # Return channels for a bank. Bank given as number
• def get_bank_channels(self, bank):

This is so that we can present the user with a list of channels belonging to a bank, right? I.e, they want to create a bank by tagging channels into it instead of marking the channel with a specific bank...

For what it's worth the two "commercial" apps I've used for the VX-8 only let you see the bank info in context of the memory channels. each memory channel get 24 columns for each memory bank.

Admittedly much of the time this is how I'd like to work with memory banks, add a new repeater and put it in the bank to tag it's location or what ever property I want to restrict my scanning to.

However, what I'd like see is the by bank view, and this is part of my motivation for working on it. There are times I'd like to work in just the limited view of bank members or have a report by bank.

Don't know if this helps, --Rob

On 05/18/2011 01:57 AM, Dan Smith wrote:

...

• # Return channels for a bank. Bank given as number
• def get_bank_channels(self, bank):

•    nchannels = 0
  

•    size = self._memobj.bank_sizes[bank]
  

•    if size<= 198:
  

•        nchannels = 1 + size/2
  

•    _channels = self._memobj.bank_channels[bank]
  

•    channels = []
  

•    for i in range(0, nchannels):
  

•        channels.append(_channels.channel[i])
  

•    return channels
  

This is so that we can present the user with a list of channels belonging to a bank, right? I.e, they want to create a bank by tagging channels into it instead of marking the channel with a specific bank...

We need it no matter how the UI ends up. It's the most natural way to decode the bank membership information in the image. In turn, it can be directly mapped to a spreadsheet like channels by banks layout, or something different.

So, maybe we need to change the UI to not allow per-memory bank editing for any of the radios, but rather make the bank editor more robust, and capable of handling the one-to-one and one-to-many bank models. I'm definitely in favor of a unified workflow in the UI. We'll just need to change the current bank-supporting drivers to return banks of memories (like you have above) and declare whether they support one-to-one or one-to-many.

Sound reasonable?

It does.

I've seen two different approaches:

- A separate tab for mapping channels to banks - Two different views in the channel editor, one with a column for each possible bank, and one with columns for the other channel attributes.

I can try to hack some of the UI changes up in a prototype patch if this seems like a good path forward.

Looking forward to it.

Jon LA4RT

On 05/17/2011 10:45 PM, Robert Terzi wrote:

I got a chance to do some testing of VX-8DR memory banks:

Bank names:

Bank Names start at 0x135A, two bytes of zeros, 16 bytes of label. The first two bytes are not length, so far I haven't seen them be anything but zero.

#seekto 0x135A; struct { u8 unknown1; char label[16]; } banknames[24];

Bank Linking Flag:

The flag bits for whether banks are linked are stored at offset 0x546-0x548. The flags are stored starting with bank 1 as the LSB for the 16 bit big endian word stored at 0x546. It looks like:

    MSB              LSB

0x546: Bank 16 Bank 9 0x547: Bank 8 Bank 1 0x548: Bank 24 Bank 17

Bank Memory Storage:

The list of memories for Bank 1 starts at 0x198a and contains 100 two byte entries by memory number, zero based, so the first memory is 0. Memory 999 is stored as 0x03 0xe6 (998 zero based) Unused slots are FF FF.

EAI is treated as Memory No. 1000, stored as 0x03e7

The "special memories", Weather 1 is 0x1800, Weather 2 is 0x1801 Marine 1 is 0x2800, 2 is 0x2801, ... , Marine 88 is 0x2838 Radio 1 VOA (1st shortwave) is 0x3000 ... Radio 88 is 0x3058

#seekto 0x198a; struct { u16 channel[100]; } bank_members[24];

Memory Bank In Use:

starting at 0x54a, there are two bytes for each memory bank that indicate whether the bank has anything in it. 0xFFFF if it isn't in use and 0 if it is. I don't know why a 16 bit value is used for something that could be a bit mask.

#seekto 0x54a; struct { u16 in_use; } bank_used[24];

Bank Sizes (or number of entries in each bank):

So far, I can't find any indication that there is a spot to count the number of entries used in each bank the way there is on the vx6 that Jon Hellan provided.

Doesn't have to be. The 0xffff values are enough.

Highest Bank Number in Use:

The oddest part that I found is there seems to be three separate places that seem to indicate the highest bank number in use. There also seem to be two copies of each of them. 0x650 through 0x6cf (128 bytes) seems to be almost, but not completely duplicated started at 0x6d0.

Note zero based bank number

At offset 0x654: ff ff ff ff - no banks are used. 00 00 00 00 - highest bank is Bank 1. 00 01 00 00 - highest bank is Bank 2. 00 17 00 00 - highest bank is Bank 24.

this is repeated 128 bytes later at 0x6d4.

I supposed this could also be the most recently used bank number.

I agree. On the VX-6, the beginning of the image is about current state.

Jon LA4RT