[chirp_devel] [PATCH] Fix some GTK errors in mainapp #7923
# HG changeset patch # User Alex Page a.t.page@gmail.com # Date 1591099370 14400 # Tue Jun 02 08:02:50 2020 -0400 # Branch py3 # Node ID 64ee0e070f2298571c9b2656396c653a59e01b67 # Parent d4e064ee05113349c9cfd7006e4f8cf3d5afc52b Fix some GTK errors in mainapp #7923
diff --git a/chirp/ui/mainapp.py b/chirp/ui/mainapp.py --- a/chirp/ui/mainapp.py +++ b/chirp/ui/mainapp.py @@ -898,9 +898,9 @@
# Do this in case the import process is going to take a while # to make sure we process events leading up to this - gtk.gdk.window_process_all_updates() + gtk.gdk.Window.process_all_updates() while gtk.events_pending(): - gtk.main_iteration(False) + gtk.main_iteration_do(False)
if do_import: eset = self.get_current_editorset() @@ -1030,9 +1030,9 @@ # Do this in case the import process is going to take a while # to make sure we process events leading up to this with compat.py3safe(): - gtk.gdk.window_process_all_updates() + gtk.gdk.Window.process_all_updates() while gtk.events_pending(): - gtk.main_iteration(False) + gtk.main_iteration_do(False)
fn = tempfile.mktemp(".csv") try: @@ -1142,9 +1142,9 @@ # Do this in case the import process is going to take a while # to make sure we process events leading up to this with compat.py3safe(): - gtk.gdk.window_process_all_updates() + gtk.gdk.Window.process_all_updates() while gtk.events_pending(): - gtk.main_iteration(False) + gtk.main_iteration_do(False)
fn = tempfile.mktemp(".csv") try: @@ -1316,9 +1316,9 @@
# Do this in case the import process is going to take a while # to make sure we process events leading up to this - gtk.gdk.window_process_all_updates() + gtk.gdk.Window.process_all_updates() while gtk.events_pending(): - gtk.main_iteration(False) + gtk.main_iteration_do(False)
if do_import: eset = self.get_current_editorset() @@ -1379,9 +1379,9 @@
# Do this in case the import process is going to take a while # to make sure we process events leading up to this - gtk.gdk.window_process_all_updates() + gtk.gdk.Window.process_all_updates() while gtk.events_pending(): - gtk.main_iteration(False) + gtk.main_iteration_do(False)
if do_import: eset = self.get_current_editorset()
Before you get too far down the rabbit hole, Alex, you should know that Dan is working to get chirp on wxWigets since gtk2 has been deprecated.
Tony ________________________________ From: chirp_devel-bounces@intrepid.danplanet.com chirp_devel-bounces@intrepid.danplanet.com on behalf of Alex Page via chirp_devel chirp_devel@intrepid.danplanet.com Sent: Tuesday, June 2, 2020 7:04:20 AM To: chirp_devel@intrepid.danplanet.com chirp_devel@intrepid.danplanet.com Subject: [chirp_devel] [PATCH] Fix some GTK errors in mainapp #7923
# HG changeset patch # User Alex Page a.t.page@gmail.com # Date 1591099370 14400 # Tue Jun 02 08:02:50 2020 -0400 # Branch py3 # Node ID 64ee0e070f2298571c9b2656396c653a59e01b67 # Parent d4e064ee05113349c9cfd7006e4f8cf3d5afc52b Fix some GTK errors in mainapp #7923
diff --git a/chirp/ui/mainapp.py b/chirp/ui/mainapp.py --- a/chirp/ui/mainapp.py +++ b/chirp/ui/mainapp.py @@ -898,9 +898,9 @@
# Do this in case the import process is going to take a while # to make sure we process events leading up to this - gtk.gdk.window_process_all_updates() + gtk.gdk.Window.process_all_updates() while gtk.events_pending(): - gtk.main_iteration(False) + gtk.main_iteration_do(False)
if do_import: eset = self.get_current_editorset() @@ -1030,9 +1030,9 @@ # Do this in case the import process is going to take a while # to make sure we process events leading up to this with compat.py3safe(): - gtk.gdk.window_process_all_updates() + gtk.gdk.Window.process_all_updates() while gtk.events_pending(): - gtk.main_iteration(False) + gtk.main_iteration_do(False)
fn = tempfile.mktemp(".csv") try: @@ -1142,9 +1142,9 @@ # Do this in case the import process is going to take a while # to make sure we process events leading up to this with compat.py3safe(): - gtk.gdk.window_process_all_updates() + gtk.gdk.Window.process_all_updates() while gtk.events_pending(): - gtk.main_iteration(False) + gtk.main_iteration_do(False)
fn = tempfile.mktemp(".csv") try: @@ -1316,9 +1316,9 @@
# Do this in case the import process is going to take a while # to make sure we process events leading up to this - gtk.gdk.window_process_all_updates() + gtk.gdk.Window.process_all_updates() while gtk.events_pending(): - gtk.main_iteration(False) + gtk.main_iteration_do(False)
if do_import: eset = self.get_current_editorset() @@ -1379,9 +1379,9 @@
# Do this in case the import process is going to take a while # to make sure we process events leading up to this - gtk.gdk.window_process_all_updates() + gtk.gdk.Window.process_all_updates() while gtk.events_pending(): - gtk.main_iteration(False) + gtk.main_iteration_do(False)
if do_import: eset = self.get_current_editorset() _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
LOL, thanks. I was hoping the rabbit hole wasn't too deep. I did see Issue #7431, so my goal was just to shore up the Python3 and GTK stuff for now in order to use CHIRP in Ubuntu 20.04. All the features I use seem to be working after the 9 patches I sent.
On Tue, Jun 2, 2020 at 12:34 PM Tony Fuller goldstar611@hotmail.com wrote:
Before you get too far down the rabbit hole, Alex, you should know that Dan is working to get chirp on wxWigets since gtk2 has been deprecated.
Tony
*From:* chirp_devel-bounces@intrepid.danplanet.com < chirp_devel-bounces@intrepid.danplanet.com> on behalf of Alex Page via chirp_devel chirp_devel@intrepid.danplanet.com *Sent:* Tuesday, June 2, 2020 7:04:20 AM *To:* chirp_devel@intrepid.danplanet.com < chirp_devel@intrepid.danplanet.com> *Subject:* [chirp_devel] [PATCH] Fix some GTK errors in mainapp #7923
# HG changeset patch # User Alex Page a.t.page@gmail.com # Date 1591099370 14400 # Tue Jun 02 08:02:50 2020 -0400 # Branch py3 # Node ID 64ee0e070f2298571c9b2656396c653a59e01b67 # Parent d4e064ee05113349c9cfd7006e4f8cf3d5afc52b Fix some GTK errors in mainapp #7923
diff --git a/chirp/ui/mainapp.py b/chirp/ui/mainapp.py --- a/chirp/ui/mainapp.py +++ b/chirp/ui/mainapp.py @@ -898,9 +898,9 @@
# Do this in case the import process is going to take a while # to make sure we process events leading up to this
gtk.gdk.window_process_all_updates()
gtk.gdk.Window.process_all_updates() while gtk.events_pending():
gtk.main_iteration(False)
gtk.main_iteration_do(False) if do_import: eset = self.get_current_editorset()@@ -1030,9 +1030,9 @@ # Do this in case the import process is going to take a while # to make sure we process events leading up to this with compat.py3safe():
gtk.gdk.window_process_all_updates()
gtk.gdk.Window.process_all_updates() while gtk.events_pending():
gtk.main_iteration(False)
gtk.main_iteration_do(False) fn = tempfile.mktemp(".csv") try:@@ -1142,9 +1142,9 @@ # Do this in case the import process is going to take a while # to make sure we process events leading up to this with compat.py3safe():
gtk.gdk.window_process_all_updates()
gtk.gdk.Window.process_all_updates() while gtk.events_pending():
gtk.main_iteration(False)
gtk.main_iteration_do(False) fn = tempfile.mktemp(".csv") try:@@ -1316,9 +1316,9 @@
# Do this in case the import process is going to take a while # to make sure we process events leading up to this
gtk.gdk.window_process_all_updates()
gtk.gdk.Window.process_all_updates() while gtk.events_pending():
gtk.main_iteration(False)
gtk.main_iteration_do(False) if do_import: eset = self.get_current_editorset()@@ -1379,9 +1379,9 @@
# Do this in case the import process is going to take a while # to make sure we process events leading up to this
gtk.gdk.window_process_all_updates()
gtk.gdk.Window.process_all_updates() while gtk.events_pending():
gtk.main_iteration(False)
gtk.main_iteration_do(False) if do_import: eset = self.get_current_editorset()
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
So the rabbit hole extends outside the codebase and IMO won't help users who are not upgrading from an older Ubuntu install. (Did you upgrade or install fresh?)
For instance, it's not feasible for the everyday chirp user to collect all of the dependencies needed for chirp to run on Ubuntu 20.04 from a fresh install because many of those packages aren't in the focal fossa repo.
For instance, try to apt install python-libxml2 python-gtk and you may see a message like "couldn't find package xyz but is referenced by another package" from apt.
Tony.
I'm on a new install of 20.04 and CHIRP is working fine (for me) after those minor patches for Python3 and GTK syntax. I didn't have to jump through any hoops to install prereqs. Actually, I think pyserial was the only thing I needed to install.
I tried running my fork in a fresh 18.04 VM, and only needed to install `future` and `serial`. Unfortunately I don't have a way to test on other platforms (e.g. Windows).
Note that I am operating from the py3 branch, so maybe some work was already done there to remove the problematic dependencies you mentioned.
On Tue, Jun 2, 2020 at 1:11 PM Tony Fuller goldstar611@hotmail.com wrote:
So the rabbit hole extends outside the codebase and IMO won't help users who are not upgrading from an older Ubuntu install. (Did you upgrade or install fresh?)
For instance, it's not feasible for the everyday chirp user to collect all of the dependencies needed for chirp to run on Ubuntu 20.04 from a fresh install because many of those packages aren't in the focal fossa repo.
For instance, try to apt install python-libxml2 python-gtk and you may see a message like "couldn't find package xyz but is referenced by another package" from apt.
Tony.
participants (2)
-
Alex Page -
Tony Fuller