[chirp_devel] [PATCH 0 of 1 ] Damned windows and it's "no com port"
I tried simply disabling the OK button but I didn't success. I think it's not worth spend lot of time working on this as is a very specific case: there must be no serial port on the system and no last_port in the configuration. Nevertheless we have to solve it.
ok Marco, it's windows but you can do it ... you can do it ... you can do it ...
In this patch the simpliest solution: just display an empty list, should user try to download it gets reasonable error and an empty port is saved in config (which is safe).
73 de IZ3GME Marco
# HG changeset patch # User Marco Filippi iz3gme.marco@gmail.com # Date 1380710557 -7200 # Node ID 6bb0ed2ae6bef32a11a0476ce16f236a5b1c3ae3 # Parent 23e2541b4dcde2e9d8be6282a8a0abc28a81a5e3 [ui] Correctly manage "No com port" situation Fix regression introduced fixing #1131
diff --git a/chirpui/clone.py b/chirpui/clone.py --- a/chirpui/clone.py +++ b/chirpui/clone.py @@ -56,6 +56,8 @@ port = conf.get("last_port") elif ports: port = ports[0] + else: + port = "" if not port in ports: ports.insert(0, port)
@@ -120,7 +122,7 @@ self.__table.set_col_spacings(10) self.__row = 0
- self.__port = self.__make_port(settings and settings.port or ["No port detected"]) + self.__port = self.__make_port(settings and settings.port or None) self.__modl = self.__make_model() self.__vend = self.__make_vendor(self.__modl)
On Wed, Oct 2, 2013 at 6:55 AM, Marco Filippi IZ3GME <iz3gme.marco@gmail.com
wrote:
I tried simply disabling the OK button but I didn't success. I think it's not worth spend lot of time working on this as is a very specific case: there must be no serial port on the system and no last_port in the configuration. Nevertheless we have to solve it.
ok Marco, it's windows but you can do it ... you can do it ... you can do it ...
In this patch the simpliest solution: just display an empty list, should user try to download it gets reasonable error and an empty port is saved in config (which is safe).
73 de IZ3GME Marco
Marco, I don't see where this does anything differently under my Windows 7 than it did before you got started on this quest. If I unplug my programming cable and then launch CHIRP, when I go to Radio => Download From Radio, CHIRP still shows and lists the COM port that was available before the cable was removed. If I continue, I do get a "could not open COMx: [Error 2] The system could not find the file specified". Was this your goal? Jim KC9HI
I don't see where this does anything differently under my Windows 7 than it did before you got started on this quest. If I unplug my programming cable and then launch CHIRP, when I go to Radio => Download From Radio, CHIRP still shows and lists the COM port that was available before the cable was removed. If I continue, I do get a "could not open COMx: [Error 2] The system could not find the file specified". Was this your goal?
I think the only difference is if you're a "first run" case.
Go move your chirp.config away from the normal place and re-run. Hopefully you end up with an empty dialog with this patch. Without it, you got no dialog at all, which confused people.
On Wed, Oct 2, 2013 at 6:19 PM, Dan Smith dsmith@danplanet.com wrote:
I don't see where this does anything differently under my Windows 7 than it did before you got started on this quest. If I unplug my programming cable and then launch CHIRP, when I go to Radio => Download From Radio, CHIRP still shows and lists the COM port that was available before the cable was removed. If I continue, I do get a "could not open COMx: [Error 2] The system could not find the file specified". Was this your
goal?
I think the only difference is if you're a "first run" case.
Go move your chirp.config away from the normal place and re-run. Hopefully you end up with an empty dialog with this patch. Without it, you got no dialog at all, which confused people.
Oh... I see!
I've read where others have tried to download from the radio but claimed the menu didn't show up. I had no idea why. Now it makes sense. This is definitely a good patch. Thanks Dan and Marco.
Jim KC9HI
participants (3)
-
Dan Smith -
Jim Unroe -
Marco Filippi IZ3GME