[chirp_devel] TH-UV88 Optional signaling implementation Feature #1110
Hello,
I just commited optional signaling in my chirp repo :
https://github.com/velter/chirp/tree/th_uv88-optsignaling
Some things might still be polished (dynamicly show/hide/clear encode/decode settings based on chanel activation for example). But everything is functional and all tests are passing.
This branch contain an updated image file for TYT-UV88 with more complete parameters coverage
Before I make a pull request, it would be nice to have some feedback :
- Currently the code is activated for TYT UV-88 but also for Retevis RA89 and QRZ-1. It seems from the docs that RA89 support optional signal but I'm not sure for QRZ-1. Test images for both models contains correct datas but from the docs it seems QRZ-1 does not support optional signaling. Can someone with access to these radio can test and tel me ? - While I do software development for more than20 years I'm pretty new to python. Some coding might probably be improved - More tests will be welcomed
When this change will be commited I propose to also work on :
- Handling the vfo settings ("VFo Ch" tab from the original software) - Handling the Frequence range settings ("Frequency Range" tab from the original software - Reorganize Basic/Advanced/Work mode settings in the UI (for exemple the 3 VOX settings are scattered around in 3 different place from 2 differents tabs. I would propose to group the settings in 3 categories UI, Radio and Work mode - Other small fixes (scramble value 8 not handled properly)
cyril
Some things might still be polished (dynamicly show/hide/clear encode/decode settings based on chanel activation for example).
I'm not sure what you mean by this, but just in case it's not clear, you can't selectively add things to mem.extra based on the current state. Doing so will break the UI's ability to column-ify these settings and you'll get a warning in the log.
This branch contain an updated image file for TYT-UV88 with more complete parameters coverage
You mean it just has some more interesting example memories or something? You should not need to change the image to get tests to pass, and if you do, something else is broken.
Before I make a pull request, it would be nice to have some feedback :
It's much easier to comment on things in a PR or patch. Please just create a PR, marked as draft if you want, if you are looking for feedback. It's fine to have a PR outstanding that you're working on, just make it clear :)
• While I do software development for more than20 years I'm pretty new to python. Some coding might probably be improved
I'll be glad to opine here, but it's easier to do so in a PR :)
Handling the vfo settings ("VFo Ch" tab from the original software) • Handling the Frequence range settings ("Frequency Range" tab from the original software • Reorganize Basic/Advanced/Work mode settings in the UI (for exemple the 3 VOX settings are scattered around in 3 different place from 2 differents tabs. I would propose to group the settings in 3 categories UI, Radio and Work mode • Other small fixes (scramble value 8 not handled properly)
If you would, create a bug/feature on the chirp site for these (either independently or "TH-UV88 improvements") and put this stuff in there. Then tag that in your commit messages so they get linked. That's a better place to document the plans and progress since it's viewable to people who have this radio and might be about to complain about missing features :)
Otherwise sounds good to me, thanks for your work on this, I'm sure there are lots of TH-UV88 users who appreciate it :)
--Dan
Some things might still be polished (dynamicly show/hide/clear encode/decode settings based on chanel activation for example).
I'm not sure what you mean by this, but just in case it's not clear, you can't selectively add things to mem.extra based on the current state. Doing so will break the UI's ability to column-ify these settings and you'll get a warning in the log.
Got it. I was thinking about the settings tabs. For example there is signaling channel having : * An "Active" flag * A type * A code
Type and code could be hidden / cleared if active is false
This branch contain an updated image file for TYT-UV88 with more complete parameters coverage
You mean it just has some more interesting example memories or something? You should not need to change the image to get tests to pass, and if you do, something else is broken.
I didn't change the image for passing the automatic tests. I It was for manual tests with the radio : * Upload to radio with chirp * Download from radio with official CPS * compare the settings between chirp and the official CPS
I can can easily revert this change.
Before I make a pull request, it would be nice to have some feedback :
It's much easier to comment on things in a PR or patch. Please just create a PR, marked as draft if you want, if you are looking for feedback. It's fine to have a PR outstanding that you're working on, just make it clear :)
• While I do software development for more than20 years I'm pretty new to python. Some coding might probably be improvedI'll be glad to opine here, but it's easier to do so in a PR :)
Pull request created
Handling the vfo settings ("VFo Ch" tab from the original software) • Handling the Frequence range settings ("Frequency Range" tab from the original software • Reorganize Basic/Advanced/Work mode settings in the UI (for exemple the 3 VOX settings are scattered around in 3 different place from 2 differents tabs. I would propose to group the settings in 3 categories UI, Radio and Work mode • Other small fixes (scramble value 8 not handled properly)
If you would, create a bug/feature on the chirp site for these (either independently or "TH-UV88 improvements") and put this stuff in there. Then tag that in your commit messages so they get linked. That's a better place to document the plans and progress since it's viewable to people who have this radio and might be about to complain about missing features :)
Created issue #11153
Otherwise sounds good to me, thanks for your work on this, I'm sure there are lots of TH-UV88 users who appreciate it :)
OK thanks.
cyril F4LHW
Got it. I was thinking about the settings tabs. For example there is signaling channel having :
- An "Active" flag
- A type
- A code
Type and code could be hidden / cleared if active is false
Well, it's not a good idea to hide (i.e. remove them from the settings tree) because of how the UI expects them from the radio. However, you can mark one as "volatile" which will cause all the settings to be reloaded if/when it changes. Use that with care though as it causes a lot of churn. It's really for settings where it's very important that one setting impacts another.
I didn't change the image for passing the automatic tests. I It was for manual tests with the radio :
- Upload to radio with chirp
- Download from radio with official CPS
- compare the settings between chirp and the official CPS
I can can easily revert this change.
Okay, just making sure :)
If you don't mind putting them in separate PRs just to make sure the image change doesn't affect the tests, I'd appreciate it.
Pull request created
Created issue #11153
++ thanks :)
--Dan
participants (2)
-
Cyril Velter -
Dan Smith