[chirp_devel] Python 3 contributions
Hello, First off, thanks for the excellent DevelopersProcess wiki that helps get new developers started with the contribution process; this was really helpful in getting started.
I do have a couple questions that don't appear to be covered in the wiki, both of which relate to patches as they related to the py3 branch:
First question is is whether the process is the same for contributing to the py3 branch, or if there's a slightly different process. If it's the same process, I assume I should annotate the patch as being intended for the py3 branch?
Second question: The patches I've put together should all be Python 2 compatible. They were developed against the py3 branch, but I'd imagine I can port most of them to the default branch. Should I be sending these against the Python 2 branch or the Python 3 branch?
Apologies if these questions are a bit basic -- I admit I don't have a huge amount of experience with it compared to git.
Thanks in advance, Chris
First question is is whether the process is the same for contributing to the py3 branch, or if there's a slightly different process. If it's the same process, I assume I should annotate the patch as being intended for the py3 branch?
Mercurial will do that for you. But, you might prefer submitting those against the py3 branch here:
https://github.com/kk7ds/chirp
I haven't updated the process doc yet, sorry.
Second question: The patches I've put together should all be Python 2 compatible. They were developed against the py3 branch, but I'd imagine I can port most of them to the default branch. Should I be sending these against the Python 2 branch or the Python 3 branch?
If they're not python3 specific they should go into the default branch first or as well. If they're just python3 fixes, then we don't need to bring them back to the default branch.
--Dan
2021-09-11 14:54 -0700 Dan Smith via chirp_devel chirp_devel@intrepid.danplanet.com:
First question is is whether the process is the same for contributing to the py3 branch, or if there's a slightly different process. If it's the same process, I assume I should annotate the patch as being intended for the py3 branch?
Mercurial will do that for you. But, you might prefer submitting those against the py3 branch here:
Fantastic; I was not aware of this. Thanks for letting me know.
Second question: The patches I've put together should all be Python 2 compatible. They were developed against the py3 branch, but I'd imagine I can port most of them to the default branch. Should I be sending these against the Python 2 branch or the Python 3 branch?
If they're not python3 specific they should go into the default branch first or as well. If they're just python3 fixes, then we don't need to bring them back to the default branch.
Sounds good; will clean these up and organise them into logical chunks, and prepare to send them out this week.
Chris
participants (2)
-
Chris Bracken -
Dan Smith