[chirp_devel] Patch to set VX8-DR channel valid bit
Hi,
I think the attached patch addresses http://chirp.danplanet.com/issues/543
It may also fix bug 409, but I don't quite understand the wording in that bug.
On Mon, Feb 11, 2013 at 12:53 PM, Sean Burford sburford@google.com wrote:
Hi,
I think the attached patch addresses http://chirp.danplanet.com/issues/543
While it looks like your patch will fix the issue, the patch should have a header with your name and commit message. If you follow the process here: http://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess#Submitting-... the patch should come out correctly formatted.
It may also fix bug 409, but I don't quite understand the wording in that bug.
That's an unrelated issue. Similar to memories, each bank has a "valid" bit that isn't being enabled. Looks like Dan was slacking when he wrote the VX8 driver ;-)
Tom KD7LXL
That's an unrelated issue. Similar to memories, each bank has a "valid" bit that isn't being enabled. Looks like Dan was slacking when he wrote the VX8 driver ;-)
Crap, I forgot about that one. Wanted to fix it before 0.3.0.
Sean, any desire to try to tease out the bit that #409 needs? Tom got it for one of the other radios, so he could probably help :)
On Mon, Feb 11, 2013 at 12:59 PM, Tom Hayward esarfl@gmail.com wrote:
On Mon, Feb 11, 2013 at 12:53 PM, Sean Burford sburford@google.com wrote:
Hi,
I think the attached patch addresses http://chirp.danplanet.com/issues/543
While it looks like your patch will fix the issue, the patch should have a header with your name and commit message. If you follow the process here: http://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess#Submitting-... the patch should come out correctly formatted.
Sean,
Did you ever figure this out? I think http://chirp.danplanet.com/issues/575 is another report of this bug and I'd like to get your fix committed.
Tom KD7LXL
Hi,
The attached patch should resolve http://chirp.danplanet.com/issues/409(vx-8dr, banks not working). There is a fair bit in there, let me know which bits you would like to discuss.
On Sun, Feb 17, 2013 at 2:21 PM, Tom Hayward esarfl@gmail.com wrote:
On Mon, Feb 11, 2013 at 12:59 PM, Tom Hayward esarfl@gmail.com wrote:
On Mon, Feb 11, 2013 at 12:53 PM, Sean Burford sburford@google.com
wrote:
Hi,
I think the attached patch addresses
http://chirp.danplanet.com/issues/543
While it looks like your patch will fix the issue, the patch should have a header with your name and commit message. If you follow the process here:
http://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess#Submitting-...
the patch should come out correctly formatted.
Sean,
Did you ever figure this out? I think http://chirp.danplanet.com/issues/575 is another report of this bug and I'd like to get your fix committed.
Tom KD7LXL _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
H,
The attached patch should resolve http://chirp.danplanet.com/issues/543(VX-8 flags.valid is never set). It's pretty straightforward.
On Mon, Feb 18, 2013 at 12:26 PM, Sean Burford sburford@google.com wrote:
Hi,
The attached patch should resolve http://chirp.danplanet.com/issues/409(vx-8dr, banks not working). There is a fair bit in there, let me know which bits you would like to discuss.
On Sun, Feb 17, 2013 at 2:21 PM, Tom Hayward esarfl@gmail.com wrote:
On Mon, Feb 11, 2013 at 12:59 PM, Tom Hayward esarfl@gmail.com wrote:
On Mon, Feb 11, 2013 at 12:53 PM, Sean Burford sburford@google.com
wrote:
Hi,
I think the attached patch addresses
http://chirp.danplanet.com/issues/543
While it looks like your patch will fix the issue, the patch should have a header with your name and commit message. If you follow the process here:
http://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess#Submitting-...
the patch should come out correctly formatted.
Sean,
Did you ever figure this out? I think http://chirp.danplanet.com/issues/575 is another report of this bug and I'd like to get your fix committed.
Tom KD7LXL _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
-- Sean Burford sburford@google.com
Hi,
I've updated banks.patch with a couple more fields (VFO volumes and TX frequency offset).
Do you have any questions about this or enable.patch? This patch: - Adds vfo_info[6] to the memory map. vfo_info[6] is three pairs of vfo_info structures, each pair containing the current VFO settings for one VFO and a backup of those settings. - Adds update_vfo() which updates vfo_info.bank_index, vfo_info.mr_index and vfo_info.bank_enable when banks are modified. vfo_info.bank_index is the current bank for the VFO (when it's in memory recall banks mode) vfo_info.mr_index is the current channel for the VFO (when it's in memory recall mode) vfo_info.bank_enable controls access to memory recall banks mode, ensuring banks mode is not enabled when no suitable banks are defined.
On Mon, Feb 18, 2013 at 12:26 PM, Sean Burford sburford@google.com wrote:
Hi,
The attached patch should resolve http://chirp.danplanet.com/issues/409(vx-8dr, banks not working). There is a fair bit in there, let me know which bits you would like to discuss.
On Sun, Feb 17, 2013 at 2:21 PM, Tom Hayward esarfl@gmail.com wrote:
On Mon, Feb 11, 2013 at 12:59 PM, Tom Hayward esarfl@gmail.com wrote:
On Mon, Feb 11, 2013 at 12:53 PM, Sean Burford sburford@google.com
wrote:
Hi,
I think the attached patch addresses
http://chirp.danplanet.com/issues/543
While it looks like your patch will fix the issue, the patch should have a header with your name and commit message. If you follow the process here:
http://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess#Submitting-...
the patch should come out correctly formatted.
Sean,
Did you ever figure this out? I think http://chirp.danplanet.com/issues/575 is another report of this bug and I'd like to get your fix committed.
Tom KD7LXL _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
-- Sean Burford sburford@google.com
On Tue, Feb 19, 2013 at 10:51 AM, Sean Burford sburford@google.com wrote:
Hi,
I've updated banks.patch with a couple more fields (VFO volumes and TX frequency offset).
Do you have any questions about this or enable.patch? This patch:
- Adds vfo_info[6] to the memory map. vfo_info[6] is three pairs of
vfo_info structures, each pair containing the current VFO settings for one VFO and a backup of those settings.
- Adds update_vfo() which updates vfo_info.bank_index, vfo_info.mr_index
and vfo_info.bank_enable when banks are modified. vfo_info.bank_index is the current bank for the VFO (when it's in memory recall banks mode) vfo_info.mr_index is the current channel for the VFO (when it's in memory recall mode) vfo_info.bank_enable controls access to memory recall banks mode, ensuring banks mode is not enabled when no suitable banks are defined.
Hi Sean,
Your patches look good to me (without testing on VX8), and are formatted perfectly! Dan handles all the committing and he is working with a deadline at work today. I'd expect your patches in daily-20130221 or later.
Tom KD7LXL
participants (3)
-
Dan Smith -
Sean Burford -
Tom Hayward