[chirp_devel] [PATCH] [UV-25X2*] Duplex "split" bug
# HG changeset patch # User Jim Unroe rock.unroe@gmail.com # Date 1494984364 14400 # Node ID ca6d151b3a56acc482846d967703b945944eed1b # Parent 0714032989d2d0ea7fa82c231e4ab374835375b4 [UV-25X2*] Duplex "split" bug
This patch addresses a "split" bug that causes CHIRP to display a memory as a shift direction/offset even if the RX and TX frequencies are each in a different band.
* this affects all mobile radios supported by the btech.py driver
Related to Bug #4825
diff -r 0714032989d2 -r ca6d151b3a56 chirp/drivers/btech.py --- a/chirp/drivers/btech.py Sun Apr 02 10:39:43 2017 -0400 +++ b/chirp/drivers/btech.py Tue May 16 21:26:04 2017 -0400 @@ -635,7 +635,7 @@ return False
# if you get here is because the freq pairs are split - return False + return True
class BTechMobileCommon(chirp_common.CloneModeRadio,
Although this patch was accepted, it doesn't appear to have made it into the build.
Jim KC9HI
On Tue, May 16, 2017 at 9:26 PM, Jim Unroe rock.unroe@gmail.com wrote:
# HG changeset patch # User Jim Unroe rock.unroe@gmail.com # Date 1494984364 14400 # Node ID ca6d151b3a56acc482846d967703b945944eed1b # Parent 0714032989d2d0ea7fa82c231e4ab374835375b4 [UV-25X2*] Duplex "split" bug
This patch addresses a "split" bug that causes CHIRP to display a memory as a shift direction/offset even if the RX and TX frequencies are each in a different band.
- this affects all mobile radios supported by the btech.py driver
Related to Bug #4825
diff -r 0714032989d2 -r ca6d151b3a56 chirp/drivers/btech.py --- a/chirp/drivers/btech.py Sun Apr 02 10:39:43 2017 -0400 +++ b/chirp/drivers/btech.py Tue May 16 21:26:04 2017 -0400 @@ -635,7 +635,7 @@ return False
# if you get here is because the freq pairs are split
- return False
- return True
class BTechMobileCommon(chirp_common.CloneModeRadio,
Although this patch was accepted, it doesn't appear to have made it into the build.
I just grabbed the 20170526 build tarball and it seems like it's in there to me. Are you saying you think it's not included because the commit message is not in an email from the build system or because you think it's really not in the code?
--Dan
On Wed, May 31, 2017 at 11:53 AM, Dan Smith via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
Although this patch was accepted, it doesn't appear to have made it into the build.
I just grabbed the 20170526 build tarball and it seems like it's in there to me. Are you saying you think it's not included because the commit message is not in an email from the build system or because you think it's really not in the code?
--Dan
I'm saying it because the btech.py downloaded from the repository does not have the change and there is no mention of the change in the history.
If I recall, this is one of the patches that build system failed while processing.
Jim
I'm saying it because the btech.py downloaded from the repository does not have the change and there is no mention of the change in the history.
If you look at the latest build tarball, the change is there. Here's a link to the "real" repository, which shows the change was indeed made:
http://d-rats.com/hg/hgwebdir.cgi/chirp.hg/file/7c0d6231a44b/chirp/drivers/b...
and this shows the commit:
http://d-rats.com/hg/hgwebdir.cgi/chirp.hg/rev/bb26bd892973
That's the place from where the builds are actually generated. The redmine (website) view of the repository is just a mirror of that.
If I recall, this is one of the patches that build system failed while processing.
Yep, but I think what you're seeing is actually just that the redmine mirroring of the repo stalled at some point. Looking right now, redmine shows the last change as from 4/30. I just kicked it and it found a bunch of stuff.
Thanks!
--Dan
If I recall, this is one of the patches that build system failed while processing.
Yep, but I think what you're seeing is actually just that the redmine mirroring of the repo stalled at some point. Looking right now, redmine shows the last change as from 4/30. I just kicked it and it found a bunch of stuff.
That got it. As always, thanks Dan.
Jim
participants (2)
-
Dan Smith -
Jim Unroe