[chirp_devel] [PATCH] [ft-7900] fix upload error after clone #597
# HG changeset patch # User Jens Jensen kd4tjx@yahoo.com # Date 1388972740 21600 # Sun Jan 05 19:45:40 2014 -0600 # Node ID 0331c22551fc539ad794c0d90079a3507f04dc59 # Parent 2d995594800cceebb8da5491a43bcf57c12f5164 [ft-7900] fix upload error after clone #597
diff -r 2d995594800c -r 0331c22551fc chirp/ft7800.py --- a/chirp/ft7800.py Sun Jan 05 16:31:54 2014 -0600 +++ b/chirp/ft7800.py Sun Jan 05 19:45:40 2014 -0600 @@ -441,7 +441,8 @@
_model = "AH016" _memsize = 31561 - + _block_lengths = [8, 31552, 1] + def get_bank_model(self): return FT7800BankModel(self)
@@ -455,6 +456,7 @@ self._wipe_memory_banks(memory) FTx800Radio.set_memory(self, memory)
+@directory.register class FT7900Radio(FT7800Radio): """Yaesu FT-7900""" MODEL = "FT-7900"
# HG changeset patch # User Jens Jensen kd4tjx@yahoo.com # Date 1388972740 21600 # Sun Jan 05 19:45:40 2014 -0600 # Node ID 0331c22551fc539ad794c0d90079a3507f04dc59 # Parent 2d995594800cceebb8da5491a43bcf57c12f5164 [ft-7900] fix upload error after clone #597
Can you add some more detail to the commit message here? It's not obvious from looking at the diff what the problem was (aside from the fact that _block_lengths was apparently missing).
Thanks!
--Dan
From what I can tell, these radios, there is an extra 1 byte write/ack sequence at the end of the big blob of memory in the middle.
The 8800/8900 have this similarly set. Not sure why 7900 wasnt set here.
While fixing that, I'm seriously considering refactoring 7800 class, and I really want to use yaesu_common, but it's a beast of a chore. And I dont have 7800, 8800, or 8900 to test with - so would be afraid of breaking those ...
You want me to resend a patch with some distillation of the first sentence above?
________________________________ From: Dan Smith dsmith@danplanet.com To: chirp_devel@intrepid.danplanet.com Sent: Wednesday, January 8, 2014 6:46 PM Subject: Re: [chirp_devel] [PATCH] [ft-7900] fix upload error after clone #597
# HG changeset patch # User Jens Jensen kd4tjx@yahoo.com # Date 1388972740 21600 # Sun Jan 05 19:45:40 2014 -0600 # Node ID 0331c22551fc539ad794c0d90079a3507f04dc59 # Parent 2d995594800cceebb8da5491a43bcf57c12f5164 [ft-7900] fix upload error after clone #597
Can you add some more detail to the commit message here? It's not obvious from looking at the diff what the problem was (aside from the fact that _block_lengths was apparently missing).
Thanks!
--Dan
_______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
From what I can tell, these radios, there is an extra 1 byte write/ack sequence at the end of the big blob of memory in the middle. The 8800/8900 have this similarly set. Not sure why 7900 wasnt set here.
Can you just throw that into the commit message for that patch?
While fixing that, I'm seriously considering refactoring 7800 class, and I really want to use yaesu_common, but it's a beast of a chore. And I dont have 7800, 8800, or 8900 to test with - so would be afraid of breaking those ...
Yeah, same here. That file is a horrific mess, and I would love to get it cleaned up. I have a 7800, but most of the problem comes from the minor yet stark differences between that and its two older brothers. I have no idea why Yaesu can't make three almost-the-same radios more similar in their memory format :(
You want me to resend a patch with some distillation of the first sentence above?
Please :)
--Dan
participants (3)
-
Dan Smith -
Jens J. -
Jens Jensen