[chirp_devel] Patch for bug #1241 : locales not included in Linux builds
A typo in the Makefile was preventing the locale files from being built on Linux.
Attached patch is against trunk, and was tested against Fedora, but should be a generic unix change.
mike
clean: rm -f $(MOFILES) *~ *.orig
- rm -f `find . -name '*.mo'`
- rmdir `find * -depth -type d`
- find . -name '*.mo' -exec echo "{}" ;
- find . -depth -type d -exec echo "{}" ;
How does this prevent anything from building? It's in the clean target...
Also, AFAICT, you're breaking the commands here, which are supposed to delete all .mo files and directories by replacing them with just find commands.
What am I missing?
--Dan
On Fri, Nov 15, 2013 at 5:33 PM, Dan Smith dsmith@danplanet.com wrote:
clean: rm -f $(MOFILES) *~ *.orig
rm -f `find . -name '*.mo'`rmdir `find * -depth -type d`
find . -name '*.mo' -exec echo "{}" \;find . -depth -type d -exec echo "{}" \;How does this prevent anything from building? It's in the clean target...
The clean target gets called when you run 'python setup.py install' or 'python setup.py sdist' I'm using 'python setup.py install' to install in a python virtualenv, so I hit this. When the make fails, setup.py stops.
I also noticed there are no locale files in the daily builds, for example: http://trac.chirp.danplanet.com/chirp_daily/LATEST/chirp-daily-20131031.tar....
I assumed this was the cause of that problem, but I may be mistaken since I don't know how the builds are done.
Also, AFAICT, you're breaking the commands here, which are supposed to delete all .mo files and directories by replacing them with just find commands.
What am I missing?
nothing - bad patch - that was a testing version with echo's in it. Still getting the hang of mq, but I like it so far.
Corrected patch is attached.
mike
On Sat, Nov 16, 2013 at 10:59 AM, Dan Smith dsmith@danplanet.com wrote:
I also noticed there are no locale files in the daily builds, for
example:
Yeah, that's probably just a missing MANIFEST entry thing.
Are you interested in fixing that up too?
--Dan
I'll l take a look at it.
mike
On Sun, Nov 17, 2013 at 6:50 AM, Michael Pittaro mikeyp@lhrc.com wrote:
On Sat, Nov 16, 2013 at 10:59 AM, Dan Smith dsmith@danplanet.com wrote:
I also noticed there are no locale files in the daily builds, for example:
Yeah, that's probably just a missing MANIFEST entry thing.
Are you interested in fixing that up too?
--Dan
I'll l take a look at it.
mike
I took a look, and the manifest looks good.
How are the daily build tarballs generated? If that process uses make_source_release.sh in the build directory, I think that's where the problem is.
mike
participants (2)
-
Dan Smith -
Michael Pittaro