On Tue, Sep 29, 2015 at 4:57 PM, Alex K via chirp_devel chirp_devel@intrepid.danplanet.com wrote:

I long ago left a request to add a new radio (IP-620) to CHIRP. http://chirp.danplanet.com/issues/2033 I learned the basics pyton, a little bit to understand the code CHIRP now graduated driver radio. Please look at it and if you are satisfied, then include it in the repository.

Hi Alex,

This likely isn't getting the attention it deserves because it's not in a format that can be applied to the Chirp code repository. We use Mercurical, so patches must be in Mercurial patch format to be applied. Here's our documentation on submitting a patch for Chirp:

http://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess#Submitting-...

Continuing with code review, I see you have a number of "ok" comments. It's not immediately clear to me what this means or how the information benefits the next developer. Please elaborate on the value of these comments or remove them.

As far as actual testing, I don't have one of these radios so I'm not able to test the code. Some tests can be conducted without a radio using only the radios img file (obviously this won't test the upload and download routines). To run these tests, place an img file at

tests/images/KYD_IP-620.img

Then run run_all_tests.sh (found in the root of the Chirp repo). If any tests fail, please fix them before resubmitting your patch. Please submit this test img file (email attachment is fine) with your patch for inclusion in the repository.

Tom KD7LXL