[chirp_devel] New Kenwood TS-480 Clone mode driver
Kenwood TS-480 clone mode driver patch, img and manifest files attached. Not sure how the manifest should read after already submitting the new ts590.py driver, so this version of the manifest has them both. I guess that means that this patch should be built AFTER the ts590... Sorry these are all hitting at once, but they just finished testing together.
Kenwood TS-480 clone mode driver patch, img and manifest files attached. Not sure how the manifest should read after already submitting the new ts590.py driver, so this version of the manifest has them both. I guess that means that this patch should be built AFTER the ts590... Sorry these are all hitting at once, but they just finished testing together.
You should just stack these changes as patches in your local repo and then you can submit them in order to be applied in order.
+def command(ser, cmd, rsplen, w8t=0.01, exts=""):
Is there any reason not to just use this definition from kenwood_live and modify it to take a terminator parameter? It's not a huge deal, but it'd be good to not replicate this relatively simple procedure everywhere.
- # LOCK.acquire()
I don't remember why the original code had a lock here, but if you're going to remove it in your code, remove this commented-out line, the LOCK definition and the threading import.
I haven't looked at the ts590 file because it's not a patch, but since this one was supposed to come after that one, I'm a little concerned that they seem to share nothing. Aren't they very similar such that they could share a lot of this all-new code?
--Dan
participants (2)
-
Dan Smith
-
Rick DeWitt AA0RD