Re: [chirp_devel] [PATCH] Allow specification of the hexdump address format
On Jul 19, 2014, at 5:04 PM, Dan Smith - dsmith@danplanet.com wrote:
You're welcome to just modify this one and re-submit it and I'll apply the fixed-up one. If you'd rather (for attribution or other reasons) patch this patch, then that's fine too.
Here's my mods to your patch, as discussed. At this point, it's more your work than mine.
One new item observed in testing: I left it for you to decide whether to keep it, but I think this was a debug print added in your patch that you may want to remove?:
diff -r 3bab2acc2cf6 -r 6c8e270a40b1 chirpui/config.py ... + print "Calling get %s with raw=%s" %(key, raw) ...
-dan
One new item observed in testing: I left it for you to decide whether to keep it, but I think this was a debug print added in your patch that you may want to remove?:
diff -r 3bab2acc2cf6 -r 6c8e270a40b1 chirpui/config.py ...
print "Calling get %s with raw=%s" %(key, raw)...
Yes, meant to remove that.
a few other minor edits as per the related 1767 patch submitted # Tue Jul 15 11:40:21 2014 -0700
Note that you need to specify the bug number with a hash in front of it in order to pass my push hook. I just added it to yours here (#1767, instead of 1767) before pushing, but just wanted to point it out for the future.
Applied, thanks.
--Dan
Patch attached. -dan
participants (2)
-
chirp.cordless＠xoxy.net -
Dan Smith