[chirp_devel] Patch to add basic support for Alinco DJ-G7EG (#699)
Hello guys
I didn't get much feedback on my question about the banks (so sorry for the bad line wrapping), hence it's probably best to submit the patch without bank support for review and go from there. I hope it's OK to amend the copyright line, otherwise that can just be scrapped.
The FIXME comments are where things might have to be straightened out. This will probably require a few iterations but I'm happy to follow whatever advice you have.
Best regards and thanks.
Matt
On 2016-11-15 15:43, Mathias Weyland via chirp_devel wrote:
Hi again
Dan was kind enough to ask for a blank image which I'll be attaching to the case in a second. Of course the first version of the patch had failed unit tests because I failed to process the instructions on the web site correctly. Please find attached an improved version of the patch. Changes:
- Set has_bank to False since we don't have banks (yet) - Strip null characters ('\0') from channel name in get_memory() - Properly raise errors.UnsupportedToneError() in set_memory() This radio does not support some of the tones that are used by the BruteForce test.
Regards and thank you
Matt
Implementing Dan's comments in v3 (attached):
- Rephrased some comments - Removed stale code that was commented out
Best regards and thanks for your help!
Matt
participants (1)
-
Mathias Weyland