[chirp_devel] Bad commit
Hi Folks,
Made a commit yesterday for searching RadioReference.com in Canada - but I realized afterwards that it broke RR import. Can that commit be rolled back/uncommited and I'll fix the issue and recommit?
Thanks,
-Mark
New commit is in tip. Allows both querying and importing from RadioReference.com for both Canada and the USA. Forgive me for anything not optimal, I had to learn python on the fly to build this feature.
Thanks,
-Mark
On 2020-11-29 3:46 p.m., Mark Leigh via chirp_devel wrote:
Hi Folks,
Made a commit yesterday for searching RadioReference.com in Canada - but I realized afterwards that it broke RR import. Can that commit be rolled back/uncommited and I'll fix the issue and recommit?
Thanks,
-Mark
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
Sorry, didn't realize it was meant to go by email as well. Here's the patch (attached). Fixes #8021
Thanks,
-Mark
On 2020-11-29 4:58 p.m., Mark Leigh via chirp_devel wrote:
New commit is in tip. Allows both querying and importing from RadioReference.com for both Canada and the USA. Forgive me for anything not optimal, I had to learn python on the fly to build this feature.
Thanks,
-Mark
On 2020-11-29 3:46 p.m., Mark Leigh via chirp_devel wrote:
Hi Folks,
Made a commit yesterday for searching RadioReference.com in Canada - but I realized afterwards that it broke RR import. Can that commit be rolled back/uncommited and I'll fix the issue and recommit?
Thanks,
-Mark
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
Sorry for the delay, I finally got around to being able to test this.
Sorry, didn't realize it was meant to go by email as well. Here's the patch (attached). Fixes #8021
This seems to work for me, although I think you probably want some sort of progress dialog in between the login box and the province selection, because it's not clear why there's a big delay and that you're waiting for that to come back.
Also there were quite a bunch of style test failures. Since I delayed looking at this so long, I fixed these up for you this time, but in the future, please run (and pass) the style checks first.
Thanks!
--Dan
participants (2)
-
Dan Smith -
Mark Leigh