[chirp_devel] [PATCH][TK-760G] Fix the driver in windows and CH with no TX, fixes #2999
The driver was not working on windows, I take a while to learn by the hard way that the timing on windows is different from linux/mac.
Now it works, fixed also the offset = off when you set a channel.
Enjoy.
P.S.: The comment is not in the patch file but I have extended the edges of the bands when they are very close to the ham bands, that's the way we use this radios in Cuba, for example:
The radios with the default sub-band segment 148-174 Mhz can be pulled down to 144 Mhz in the lower edge with no problem, this mod works also in also in UHF.
P.P.S.: Users, wait until the next version of chirp to get support.
- # DEBUG
- #LOG.debug("<== (%d) bytes: %s" % (len(data), util.hexprint(data)))
I'd really rather not have code commented out wherever possible. I think that since this is debug it's probably okay to just leave it on, but if not, can you at least put a flag (or environment check) at the top and gate these on that flag?
--Dan
Oops!
That was a local debug code that slip my inspection into the patch... sorry.
That driver was giving me troubles on windows and I set that code to see what's going on the serial line from inside Chirp; that has not intended to be part of the release code.
Thanks for the advice, don't hesitate to point things that deviate from the Chirp's paradigm in my code, by doing that everyone wins (I learn good practices and the code is more consistent at the end)
I will be more careful on next patches, should I remove this lines via a patch?
73.
El 04/03/16 a las 12:05, Dan Smith via chirp_devel escribió:
- # DEBUG
- #LOG.debug("<== (%d) bytes: %s" % (len(data), util.hexprint(data)))
I'd really rather not have code commented out wherever possible. I think that since this is debug it's probably okay to just leave it on, but if not, can you at least put a flag (or environment check) at the top and gate these on that flag?
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
Doing it now, new patch follow in a few minutes.
73
El 05/03/16 a las 10:53, Dan Smith via chirp_devel escribió:
I will be more careful on next patches, should I remove this lines via a patch?
I haven't applied it yet, so if you could just clean it up and resubmit that would be good.
Thanks!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
The driver was not working on windows, I take a while to learn by the hard way that the timing on windows is different from linux & mac.
Now it works, fixed also the offset = off when you set a channel.
I have extended the edges of the bands when they are very close to the ham bands, that's the way we use this radios in Cuba, for example:
The radios with the default sub-band segment 148-174 Mhz can be pulled down to 144 Mhz in the lower edge with no problem, this mod works also in UHF.
participants (2)
-
Dan Smith -
Pavel Milanes (CO7WT)