[chirp_devel] trouble with tests and custom steps logic
Hi Dan, et al. I'm trying to implement tests on FT-90, but they are failing when running into my custom steps logic.
FT-90 has a known issue with 5kHz step where it acts as if the squelch wont open. (background: http://vk1od.net/equipment/FT90R/Ft90rSquelchReport.htm)
In order to help users with this problem, and because it doesn't matter so much what the step size is in a memory channel, I have put in some custom logic in get_memory that intercepts 5khz step in the radio channel, and boxes it into either 10 or 25 khz for vhf or uhf respectively in chirp memory map.
When I attempt to run_tests on this radio, it understandably fails as it tries to set a 5.0khz step, and gets back something different. So I tried to work around this by ensuring that I remove 5.0 from valid_tuning_step in chirp radio model. However it still doesnt pass the tests. It seems as if chirp is still trying to set 5.0khz step in Edges test, although it's not valid_tuning_step defined in the radio model.
test output: http://pastebin.ca/2468994
current ft90.py code that i'm testing: http://pastebin.ca/2468995
Any ideas? -Jens
I guess I should attach the FT-90 radio test image that I'm using as well...
On Sunday, October 20, 2013 8:04 AM, Jens J. kd4tjx@yahoo.com wrote:
Hi Dan, et al. I'm trying to implement tests on FT-90, but they are failing when running into my custom steps logic.
FT-90 has a known issue with 5kHz step where it acts as if the squelch wont open. (background: http://vk1od.net/equipment/FT90R/Ft90rSquelchReport.htm)
In order to help users with this problem, and because it doesn't matter so much what the step size is in a memory channel, I have put in some custom logic in get_memory that intercepts 5khz step in the radio channel, and boxes it into either 10 or 25 khz for vhf or uhf respectively in chirp memory map.
When I attempt to run_tests on this radio, it understandably fails as it tries to set a 5.0khz step, and gets back something different. So I tried to work around this by ensuring that I remove 5.0 from valid_tuning_step in chirp radio model. However it still doesnt pass the tests. It seems as if chirp is still trying to set 5.0khz step in Edges test, although it's not valid_tuning_step defined in the radio model.
test output: http://pastebin.ca/2468994
current ft90.py code that i'm testing: http://pastebin.ca/2468995
Any ideas? -Jens
_______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
It seems as if chirp is still trying to set 5.0khz step in Edges test, although it's not valid_tuning_step defined in the radio model.
Well, in this case, it's just the test doing it, right?
If the test is trying to set a memory with a tuning step that is not in the list of valid ones, then the test is not testing a reasonable scenario. I think you can just tweak the test to honor the valid_steps in this case.
participants (2)
-
Dan Smith
-
Jens J.