[chirp_devel] [PATCH] FT-818ND US Model - I think this patch may work, I can't test. Bug# 6289
# HG changeset patch # User Vinny Stipo v@xpctech.com # Date 1544661860 28800 # Wed Dec 12 16:44:20 2018 -0800 # Node ID df70e2455c4877c9d58f440690e6161da16c880e # Parent 62b4cbefa86738c37317a133f903500f669baf23 FT-818ND US Model - I think this patch may work, I can't test. Bug# 6289
diff --git a/chirp/drivers/ft818.py b/chirp/drivers/ft818.py --- a/chirp/drivers/ft818.py +++ b/chirp/drivers/ft818.py @@ -250,3 +250,16 @@
SPECIAL_MEMORIES_REV = dict(zip(SPECIAL_MEMORIES.values(), SPECIAL_MEMORIES.keys())) + +@directory.register +class FT818NDUSRadio(FT818Radio): + + """Yaesu FT-818ND (US version)""" + MODEL = "FT-818ND (US)" + + _model = "" + _US_model = True + _memsize = 6703 + + _block_lengths = [2, 40, 208, 208, 208, 208, 198, 53, 130, 118, 130, 130] +
I make a mistake, I think I needed to include rest of FT817ND US class, as I'm not inheriting it. See attached patch.
-Vinny
On Wed, Dec 12, 2018 at 4:52 PM Vinny Stipo v@xpctech.com wrote:
# HG changeset patch # User Vinny Stipo v@xpctech.com # Date 1544661860 28800 # Wed Dec 12 16:44:20 2018 -0800 # Node ID df70e2455c4877c9d58f440690e6161da16c880e # Parent 62b4cbefa86738c37317a133f903500f669baf23 FT-818ND US Model - I think this patch may work, I can't test. Bug# 6289
diff --git a/chirp/drivers/ft818.py b/chirp/drivers/ft818.py --- a/chirp/drivers/ft818.py +++ b/chirp/drivers/ft818.py @@ -250,3 +250,16 @@
SPECIAL_MEMORIES_REV = dict(zip(SPECIAL_MEMORIES.values(), SPECIAL_MEMORIES.keys()))
+@directory.register +class FT818NDUSRadio(FT818Radio):
- """Yaesu FT-818ND (US version)"""
- MODEL = "FT-818ND (US)"
- _model = ""
- _US_model = True
- _memsize = 6703
- _block_lengths = [2, 40, 208, 208, 208, 208, 198, 53, 130, 118, 130,
130]
# HG changeset patch # User Vinny Stipo v@xpctech.com # Date 1544661860 28800 # Wed Dec 12 16:44:20 2018 -0800 # Node ID df70e2455c4877c9d58f440690e6161da16c880e # Parent 62b4cbefa86738c37317a133f903500f669baf23 FT-818ND US Model - I think this patch may work, I can't test. Bug# 6289
I think we should probably try to get someone to test this before we apply it. Are there any users on the bug that might be able to try it for us?
--Dan
On Thu, Dec 13, 2018 at 7:30 PM Dan Smith via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
# HG changeset patch # User Vinny Stipo v@xpctech.com # Date 1544661860 28800 # Wed Dec 12 16:44:20 2018 -0800 # Node ID df70e2455c4877c9d58f440690e6161da16c880e # Parent 62b4cbefa86738c37317a133f903500f669baf23 FT-818ND US Model - I think this patch may work, I can't test. Bug# 6289
I think we should probably try to get someone to test this before we apply it. Are there any users on the bug that might be able to try it for us?
I can test/verify it, but probably not until middle of next week.
mike, kj6vcp
On Thu, Dec 13, 2018 at 8:07 PM Dan Smith via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
I can test/verify it, but probably not until middle of next week.
Great, thanks Mike. Let us know!
This patch is good with the US FT-818ND.
I applied it against trunk as of this morning (3014:d8febd6e81ee), and reads and writes are fine. I also did some general testing of the ft-818 driver, and it all seems good.
Thanks for the driver, Vinny!
mike, kj6vcp
I think the wrong patch was applied to LATEST, I made a correction shortly after submitting first one.
I believe Mike/kj6vcp tested with one I attached again here. He can confirm. Also looks like Addison Guynn tested as well https://chirp.danplanet.com/issues/6289#change-16825
Thanks!
-Vinny
On Tue, Jan 1, 2019 at 10:30 AM Dan Smith via chirp_devel < chirp_devel@intrepid.danplanet.com> wrote:
This patch is good with the US FT-818ND.
Awesome, thanks to you both!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
I think the wrong patch was applied to LATEST, I made a correction shortly after submitting first one.
I applied the one that was on the mailing list, as that's where it needs to go.
I believe Mike/kj6vcp tested with one I attached again here. He can confirm. Also looks like Addison Guynn tested as well https://chirp.danplanet.com/issues/6289#change-16825
Confirmation would be good.
Can you send a patch to the list here that contains the delta between what is now in the tree and what it needs to be?
Thanks!
--Dan
Yeah, I’ll do that now
On Thu, Jan 3, 2019 at 9:18 AM Dan Smith via chirp_devel < chirp_devel@intrepid.danplanet.com> wrote:
I think the wrong patch was applied to LATEST, I made a correction
shortly after submitting first one.
I applied the one that was on the mailing list, as that's where it needs to go.
I believe Mike/kj6vcp tested with one I attached again here. He can
confirm. Also looks like Addison Guynn tested as well https://chirp.danplanet.com/issues/6289#change-16825
Confirmation would be good.
Can you send a patch to the list here that contains the delta between what is now in the tree and what it needs to be?
Thanks!
--Dan _______________________________________________ chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
I tested the first patch, not the second.
I can re-test the latest diff later this evening.
mike / kj6vcp
participants (3)
-
Dan Smith -
Michael Pittaro -
Vinny Stipo