[chirp_devel] [PATCH] [UI] Default "Hide Unused Fields" to enabled. Completes #1779
# HG changeset patch # User Tom Hayward tom@tomh.us # Date 1462507294 25200 # Thu May 05 21:01:34 2016 -0700 # Node ID 44e9390fd40dc92ad3e926246ef903f38867fe86 # Parent 8539639634c23a8d20608ab19e47b40c999501a3 [UI] Default "Hide Unused Fields" to enabled. Completes #1779
The orignal patch to add this feature missed one place the hide_unused value is read from. This caused new installs to show the Hide Unused Fields box as checked, but not actually enable the feature. This patch adds defaut=True to that last remaining line of code so that this feature is enabled on the first run of Chirp.
diff -r 8539639634c2 -r 44e9390fd40d chirp/ui/memedit.py --- a/chirp/ui/memedit.py Wed May 04 19:42:49 2016 -0700 +++ b/chirp/ui/memedit.py Thu May 05 21:01:34 2016 -0700 @@ -1335,7 +1335,7 @@ self.count = 100 self.show_special = self._config.get_bool("show_special") self.show_empty = not self._config.get_bool("hide_empty") - self.hide_unused = self._config.get_bool("hide_unused") + self.hide_unused = self._config.get_bool("hide_unused", default=True) self.read_only = False
self.need_refresh = False
self.hide_unused = self._config.get_bool("hide_unused")
self.hide_unused = self._config.get_bool("hide_unused", default=True)
I've spent more hours on this than I would care to admit trying to solve this. This setting finally works as intended. Thanks for looking into this Tom.
Jim
self.hide_unused = self._config.get_bool("hide_unused")
self.hide_unused = self._config.get_bool("hide_unused", default=True)
I've spent more hours on this than I would care to admit trying to solve this. This setting finally works as intended. Thanks for looking into this Tom.
Doh! Thanks to both of you :)
--Dan
On May 6, 2016 02:30, "Jim Unroe" rock.unroe@gmail.com wrote:
self.hide_unused = self._config.get_bool("hide_unused")
self.hide_unused = self._config.get_bool("hide_unused",
default=True)
I've spent more hours on this than I would care to admit trying to solve this. This setting finally works as intended. Thanks for looking into this Tom.
Jim
Jim,
Sometimes all it takes is a second set of eyes. I'm glad I was able to help.
Tom
participants (4)
-
Dan Smith
-
Jim Unroe
-
Tom Hayward
-
Tom Hayward