[chirp_devel] [PATCH][Feidaxin Driver] Fix PEP8 +new models +images
IMPORTANT!
Please note the updated images, detection has been improved and old img on the tree can make the test fail.
Make the Feidaxin driver PEP8 compatible.
Minor changes in the structure, typos cleaning, fix some sentences with bad/confuse syntax (sorry native Spanish speaking here)
Add support to the following new feidaxin radios: FD-150A FD-160A FD-460A FD-450A FD-288A
This radios was tested hacking a FD-268A with the factory software, so maybe there is some bug in there, please report if so.
73, Merry Xmas to all.
# HG changeset patch # User Pavel Milanes (CO7WT) co7wt@frcuba.co.cu # Date 1450763465 18000 # Tue Dec 22 00:51:05 2015 -0500 # Node ID a608e6ca6313c65457529a52e1aaa606e55088c9 # Parent 8df79446b79c2e08e0988ab156a3b371623d656a IMPORTANT! Please note the updated images, detection has been improved and old img on the tree can make the test fail.
Make the Feidaxin driver PEP8 compatible.
Minor changes in the structure, typos cleaning, fix some sentences with bad/confuse syntax (sorry native Spanish speaking here)
Add support to the following new feidaxin radios: FD-150A FD-160A FD-460A FD-450A FD-288A
This radios was tested hacking a FD-268A with the factory software, so maybe there is some bug in there, please report if so.
73, Merry Xmas to all.
This fails to apply because there is no bug referenced. Can you fix and resubmit please?
Thanks!
--Dan
IMPORTANT! Please note the updated images, detection has been improved and old img on the tree can make the test fail.
Make the Feidaxin driver PEP8 compatible.
Minor changes in the structure, typos cleaning, fix some sentences with bad/confuse syntax (sorry native Spanish speaking here)
Add support to the following new feidaxin radios: FD-150A FD-160A FD-460A FD-450A FD-288A
This radios was tested hacking a FD-268A with the factory software, so maybe there is some bug in there, please report if so.
73, Merry Xmas to all.
# HG changeset patch # User Pavel Milanes (CO7WT) co7wt@frcuba.co.cu # Date 1450763465 18000 # Tue Dec 22 00:51:05 2015 -0500 # Node ID a608e6ca6313c65457529a52e1aaa606e55088c9 # Parent 8df79446b79c2e08e0988ab156a3b371623d656a IMPORTANT! Please note the updated images, detection has been improved and old img on the tree can make the test fail.
Make the Feidaxin driver PEP8 compatible.
Minor changes in the structure, typos cleaning, fix some sentences with bad/confuse syntax (sorry native Spanish speaking here)
Add support to the following new feidaxin radios: FD-150A FD-160A FD-460A FD-450A FD-288A
This radios was tested hacking a FD-268A with the factory software, so maybe there is some bug in there, please report if so.
73, Merry Xmas to all.
Sorry, but the bug number has to be in the commit message, not the email, otherwise the commit hook never sees it.
Also, if you could change the first line of the commit message to something relevant, that would be good. The first line is used as the summary when doing a short log, which means the summary of this patch would just be "IMPORTANT!". Something like "Fix Feidaxin detection, model support, etc" would be good.
Thanks!
--Dan
Roger that,
I'm new to this sorry for the inconvenience, I will re-create the patch and resubmit it.
I was in doubt about if in the patch or the email, holiday kind a party here, also my birthday 35.
Wait for it in a few minutes.
73
El 24/12/15 a las 12:50, Dan Smith via chirp_devel escribió:
Sorry, but the bug number has to be in the commit message, not the email, otherwise the commit hook never sees it.
Also, if you could change the first line of the commit message to something relevant, that would be good. The first line is used as the summary when doing a short log, which means the summary of this patch would just be "IMPORTANT!". Something like "Fix Feidaxin detection, model support, etc" would be good.
Thanks!
--Dan
I hope this time it will work, sorry for the inconvenience.
73
IMPORTANT! Please note the updated images, detection has been improved and old img on the tree can make the test fail.
Make the Feidaxin driver PEP8 compatible.
Minor changes in the structure, typos cleaning, fix some sentences with bad/confuse syntax (sorry native Spanish speaking here)
Add support to the following new feidaxin radios: FD-150A FD-160A FD-460A FD-450A FD-288A
This radios was tested hacking a FD-268A with the factory software, so maybe there is some bug in there, please report if so.
73, Merry Xmas to all.
participants (2)
-
Dan Smith -
M.Sc. Pavel Milanes Costa