Re: [chirp_devel] [CHIRP - Bug #1557] and some procedural questions.
On Apr 11, 2014, at 6:36 PM, donotreply@danplanet.com wrote:
Issue #1557 has been updated by Tom Hayward. • Description updated
Tom, thanks for updating the formatting of that. But let me know the secret to escaping [] so it doesn't become a superscript.
More generally, I couldn't find any way to edit a bug, change bug state, or anything else. Just create, and add more comments. I'm assuming that's because I don't have the appropriate admin privileges, and I'm fine with that. I just want to be sure I'm not missing something and I could have fixed this formatting myself, and/or I'm expected to change the bug state after submitting the patch.
The patch for 1557 is ready to go, but I was waiting for some visible disposition / feedback on the 1447 patch I sent Wednesday. To make sure I did that one correctly before doing another.
Regarding the patch email: Is it necessary to include all the run_tests output? Just the summary? Just assume it ran because that's SOP?
Thanks and regards,
-dan
Some of that is related to privileges, but I think you're just overlooking the link to edit the original post. After clicking update, look up near above the form for a link that says "more". You can expand that then edit the original post.
Tom KD7LXL
On Fri, Apr 11, 2014 at 8:52 PM, chirp.cordless@xoxy.net wrote:
On Apr 11, 2014, at 6:36 PM, donotreply@danplanet.com wrote:
Issue #1557 has been updated by Tom Hayward. • Description updated
Tom, thanks for updating the formatting of that. But let me know the secret to escaping [] so it doesn't become a superscript.
More generally, I couldn't find any way to edit a bug, change bug state, or anything else. Just create, and add more comments. I'm assuming that's because I don't have the appropriate admin privileges, and I'm fine with that. I just want to be sure I'm not missing something and I could have fixed this formatting myself, and/or I'm expected to change the bug state after submitting the patch.
The patch for 1557 is ready to go, but I was waiting for some visible disposition / feedback on the 1447 patch I sent Wednesday. To make sure I did that one correctly before doing another.
Regarding the patch email: Is it necessary to include all the run_tests output? Just the summary? Just assume it ran because that's SOP?
Thanks and regards,
-dan
chirp_devel mailing list chirp_devel@intrepid.danplanet.com http://intrepid.danplanet.com/mailman/listinfo/chirp_devel Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
Regarding the patch email: Is it necessary to include all the run_tests output? Just the summary? Just assume it ran because that's SOP?
Nope, just the patch is fine. In general, I think the act of submitting a patch should imply that "I ran the tests and they worked", even if that's not always the case :P
Thanks!
--Dan
participants (3)
-
chirp.cordless＠xoxy.net -
Dan Smith -
Tom Hayward