[chirp_devel] New driver
Dan,
Would you take a look at the new driver I submitted for the AnyTone 5888UV-III? Cpep8 complains about long lines, but I think any more attempts to reduce line length actually decrease readability. There's also one line that complains about visual indentation being the same as the next logical line, but I think fixing that also reduces readability.
I did find a radio programming issue that I have a fix for. If you have recommendations on the above, I can roll those in with this fix.
Thanks, Brad Schuler K0BAS
On Sun, Nov 22, 2020 at 10:54 PM Brad & Cindy Schuler via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
Dan,
Would you take a look at the new driver I submitted for the AnyTone 5888UV-III? Cpep8 complains about long lines, but I think any more attempts to reduce line length actually decrease readability. There’s also one line that complains about visual indentation being the same as the next logical line, but I think fixing that also reduces readability.
I did find a radio programming issue that I have a fix for. If you have recommendations on the above, I can roll those in with this fix.
Thanks,
Brad Schuler
K0BAS
Brad,
I just took a quick look at your new driver. My feeling is that the lines will need to be shortened. There are over 130 drivers now and they all pass the pep8 test. They weren't all that way (I volunteered to clean up a few of them -- especially the ones that were "mine" ;-) ).
Quite a few should be easy. Especially the ones that are remarks/comments.
Let me know if you need some help with it.
Jim KC9HI
Thanks for the perspective Jim. I'll take another whack at it and look at the other drivers for common techniques.
Brad Schuler K0BAS
-----Original Message----- From: Jim Unroe rock.unroe@gmail.com Sent: Sunday, November 22, 2020 9:48 PM To: Brad & Cindy Schuler cindy@schuler.ws; chirp-devel chirp_devel@intrepid.danplanet.com Subject: Re: [chirp_devel] New driver
On Sun, Nov 22, 2020 at 10:54 PM Brad & Cindy Schuler via chirp_devel chirp_devel@intrepid.danplanet.com wrote:
Dan,
Would you take a look at the new driver I submitted for the AnyTone 5888UV-III? Cpep8 complains about long lines, but I think any more attempts to reduce line length actually decrease readability. There’s also one line that complains about visual indentation being the same as the next logical line, but I think fixing that also reduces readability.
I did find a radio programming issue that I have a fix for. If you have recommendations on the above, I can roll those in with this fix.
Thanks,
Brad Schuler
K0BAS
Brad,
I just took a quick look at your new driver. My feeling is that the lines will need to be shortened. There are over 130 drivers now and they all pass the pep8 test. They weren't all that way (I volunteered to clean up a few of them -- especially the ones that were "mine" ;-) ).
Quite a few should be easy. Especially the ones that are remarks/comments.
Let me know if you need some help with it.
Jim KC9HI
I just took a quick look at your new driver. My feeling is that the lines will need to be shortened. There are over 130 drivers now and they all pass the pep8 test. They weren't all that way (I volunteered to clean up a few of them -- especially the ones that were "mine" ;-) ).
Quite a few should be easy. Especially the ones that are remarks/comments.
Yep, this.
--Dan
participants (3)
-
Brad & Cindy Schuler -
Dan Smith -
Jim Unroe